From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 347383859FA for ; Tue, 5 May 2026 17:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003216; cv=none; b=jghyvR3kVDwkNfy1Il6AxCdPG1AaAUSJ7PFcM8DJJ/PvCglx46PmtZtzcRKiDYIgjCMK+sseIAIVQcU44RjI5Xe5LHzL9MNqmAELm+15+c7hapZcnGsT/VbG7XN+SN52uYzNOnZWZIb7pjGDWEm9VHDxzX2zBMxzPFONkK5jzkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003216; c=relaxed/simple; bh=uvMuNKhl2md9ckDK0UL67dgKZyZldjsAwfjJ3rNNMZg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mK6uNVXmvw22OJ4wAP8TUf+HSRFnNVzQukRvcWo1tevajqbQdaYD+ssSTlhxzBUHISIQ9JUVeqXrUH4hQPJK9oN0wKEtsHsfbD3IoJMlP3ZmEiCyJSv7hIke3JnhOJfupuvo1NnrFSzjQxbSevPj6ib0s1P4vZGGunMVU1YnC7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BBm1PqCZ; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BBm1PqCZ" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-365313b86bfso1893569a91.3 for ; Tue, 05 May 2026 10:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003214; x=1778608014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=thuhrm8tCmZJtgI5sGLEXt+cjZuKnZXihxMoA86J9mU=; b=BBm1PqCZIgT5CYuDLLtZnZ8JIbpOuwxz1/xyiBXIT4GCNBIc1Bv+HjJcAhxJa/LdNZ 4+vSPtVWgosk6iAq4WWM/eAKVhLJgTIywRq5tfIJVQmWP1qh0LqYZWRJVcWy7aGZ+ZQq VMAZ3DWYq6vtnddD3dMe92PNv3QgxAjpf2GBBBd9CJ9T4rFK1LealL2297Q8oe2PZadu nzFRwoanX5g+wEMRtrucxrigB82kwZovDbbjbmx5tKHm1BtSjAhV35eL7FMt2vaHTgHA 7LuEzh/uCjpN5ofcVVsOcnqR1dFDusP/uxL4eLiEa1gEpgvTbJ2ehqkmvC8dh6WRcNte QMlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003214; x=1778608014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=thuhrm8tCmZJtgI5sGLEXt+cjZuKnZXihxMoA86J9mU=; b=p5tP8pc4sGC9zNQeQOCLbyA6eHzFEslEGLHRB1ByweMMaAZdMrua5LWIqY60ffhWmX LFP+trKBM5H6spArGxACKcdNs53mkJ1RRvpzNqZjtxPZLM9Ml32Z2RXvEaqcADDOJQon aZy5aPt0erde+MDclS8ipgWVvxEBhi7HcFV7JxwiocR2NVWp/7vcI9z+dhjXh3hZ2+1M x4bkRcjgLwrOqzsQMLwagRO1uBBpj99IvIJwLHPL7KvtqioEg4KtkKF/+BPiDLV3niQ9 mfXhtGTt1P5I5GKLCJoPbmbHSRBGnOFIPJqjjnE0Wmj6OIFClehCso3iInlpHeJg6Aot YwdQ== X-Forwarded-Encrypted: i=1; AFNElJ9gKrym1JVbK/2WwekZZQJQZd2lNhEXEhbjGb4myXeY8UHNMdC0YyR/pqx/9bxBrmW7lS9/EXoVHJXDL1g=@vger.kernel.org X-Gm-Message-State: AOJu0YxBoROmbNk4g4GGGXdqQC7CBGtzvUQaQdYBoPbnfWVIj6XAgh6x ujJy3D7gGfY9bpBlXNunyuQo0S3jxiCAO3B6cNECL71JQX2o6zZZVU14 X-Gm-Gg: AeBDievviL4G8qW1azfStrc3f9pgX1JPVa0MA7IuzpHMLNsFBwhdjTQYWOPxdwrvGgY naOuUASf+a5D2NxAeY3IOvzAY+FGbTk6D+hoStnEODvsC8+A/jVr3vDhoLqjXGx3h1i0+LeHGwf NOrWmbAvEkDFxpyh+CWqEPMjHoMr34qUjfAxbYkLRE4hZXeBM5+M1te6ddcus2BO+wymd0LmFgh DzFJ1pvpPLqbasMHJ7B0dnULhqDt3Q8EZCC/uWrtneXsFOjneznDilujTmgFF2uVMc1Z0lAyoFk d0Mc98V+iEh62yoXOTvwFK/6mqfeYpV1VupJcXJV/NjzfLKvEvI41jwfFEgNj1asRg2VRlo8iuH KHENRI7rpLkwTjSPXguhRO+TiB1fh1I9n3O+uOawaVzXsObcjcGO57jFXyyaQ4jTaoCuQvygNt2 DcsQGpn0SgWhqlK7uz0q+1IAJ02TgBZWBm0fHbjRdy3xLYEO0IkCMaHqvR4GZOcGKY3wPh+Q== X-Received: by 2002:a17:90b:53c6:b0:365:3154:7b1 with SMTP id 98e67ed59e1d1-36577613d3emr4259663a91.26.1778003214535; Tue, 05 May 2026 10:46:54 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.46.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:46:54 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 02/10] iio: accel: mma8452: switch to non-devm request_threaded_irq() Date: Tue, 5 May 2026 23:16:32 +0530 Message-Id: <20260505174640.3998281-3-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Avoid using devm_request_threaded_irq() as the driver requires explicit error-handling path(s). Using devm_* API together with goto-based unwinding breaks the expected LIFO resource release model. Add explicit IRQ cleanup in the driver teardown paths to follow kernel resource management conventions. Fixes: 28e3427824cc ("iio: mma8452: Basic support for transient events.") Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index cefc7cf4bd83..279a9b364886 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1682,18 +1682,16 @@ static int mma8452_probe(struct i2c_client *client) goto trigger_cleanup; if (client->irq) { - ret = devm_request_threaded_irq(&client->dev, - client->irq, - NULL, mma8452_interrupt, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, - client->name, indio_dev); + ret = request_threaded_irq(client->irq, NULL, mma8452_interrupt, + IRQF_TRIGGER_LOW | IRQF_ONESHOT, + client->name, indio_dev); if (ret) goto buffer_cleanup; } ret = pm_runtime_set_active(&client->dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; pm_runtime_enable(&client->dev); pm_runtime_set_autosuspend_delay(&client->dev, @@ -1702,7 +1700,7 @@ static int mma8452_probe(struct i2c_client *client) ret = iio_device_register(indio_dev); if (ret < 0) - goto buffer_cleanup; + goto free_irq; ret = mma8452_set_freefall_mode(data, false); if (ret < 0) @@ -1713,6 +1711,10 @@ static int mma8452_probe(struct i2c_client *client) unregister_device: iio_device_unregister(indio_dev); +free_irq: + if (client->irq) + free_irq(client->irq, indio_dev); + buffer_cleanup: iio_triggered_buffer_cleanup(indio_dev); @@ -1738,6 +1740,9 @@ static void mma8452_remove(struct i2c_client *client) pm_runtime_disable(&client->dev); pm_runtime_set_suspended(&client->dev); + if (client->irq) + free_irq(client->irq, indio_dev); + iio_triggered_buffer_cleanup(indio_dev); mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); -- 2.34.1