From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E04E1361DD0 for ; Tue, 5 May 2026 17:47:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003235; cv=none; b=kEmpbu/0JPEkUAkdDHo3uS2Tbm7/p6KSrrZOES2lhtEmKVyVaO8W1CzKh2rR+hnbxZZQaEKDPl6u+29UjAts5NZVQkRA/pV2kZz4iKgcwiyupBU0ebKO2sl0Xmu1C8G8fILPkTDYcBtrUK8rjEOBOR/mjBuubvX5AqY6ctR+ZK8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778003235; c=relaxed/simple; bh=74BbHk4KwopHm9jTxcu00JmtdsKxcIk2Jcrc1S6Dfek=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l8O0svkOeIIS+7qt280g5RjmsRwOwdxRow0rF2E2cIrXa18ci//eXXftMUznh5G2GbVRAHa/WoJJgTJRBla5WniGQY2Y6jFdd8ubkoiZpudJPkHYwJ6OcVvZL0L917xSNAQ/1lYYqxZyhW5147t5vrFqjQkgRTKBGP5gVA1QKbg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lEoudPHa; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lEoudPHa" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba17c8cfacso24127635ad.2 for ; Tue, 05 May 2026 10:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778003231; x=1778608031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8o+TU90GRNliwuyGMLuu+yCImBRr1/AI618n8XgB2MA=; b=lEoudPHakK9NmeZfijOa9FfM3ajXZi+wY6lwKYyx/Q8ilYabro33fU2QLvNgrwOKmQ 5JEPWDvswE68ZNvhONBV9rqbd+PE9a3TA+Am4gP56z6UiANLLxKSJx8WG3e66swv/yMk hUG4BAPewy2lvFfmH5S88bl+87AMo2KHXyxlftjsg7bZ+m6awzwHynPT52ZsN/g8TD86 nyUzrEEJpEV2+9TrSaYMkY3x1uM/g/jzFK9Z4sKnxJzQcmUq0SoLmK1CZqFvGpchEckz yrRkf5QBfyKJ6jMuhXvCCpak0ZzhrckIZo8qsAmDXu0UNkGmUowtYPyLAaj1Cw5qx4KY W1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778003231; x=1778608031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8o+TU90GRNliwuyGMLuu+yCImBRr1/AI618n8XgB2MA=; b=QwhgAGrYmPaHc6YWZmwUeRmLBjfr/FfaxIK6Uq+mVFEanPE/lpWp3Gxy0EViw6UJvB Gk7nKOo58YRcVbJEcBdWiUckHGrLTFrHnlKqIi8bYSAPvzRe4rcI337P+Q/OcM2XrSYk FwV9PVqIQZ0SZSuPOpMdf7o9BbUTIniFsZ1DmK+deR1ABZE/NzdmRn6Iq2dDHO5QkB2x HhrLQp8K3mMvI0FuuqZLxtZ/ygZek2zP5IZCr+OedZCuHz5LTd7DdgoWdCr+ab4Z0j6X XDVeU64Q/19ZRpJL8alUQYzveoXaRzGWA4V9XE5g82gtYDlJXAfM3UW7AEPEe+IH2whp CRbg== X-Forwarded-Encrypted: i=1; AFNElJ8txd8/nbD6W2UYd82cgHhZBz38H0uNlfzd0QtQJdl1wYmYerqdaugSe9DgSC+5IcV3pgX645tBrkpjYyo=@vger.kernel.org X-Gm-Message-State: AOJu0YzYDdr1ieRamje7hQKv//QtM8pVAr8DQ0MgrwWzlkuyxSug6PnZ omZws5iFCDZdbhMU88PN8AsN8uC7f884oUfDKa/Ce5KaXAeybuz4F70u X-Gm-Gg: AeBDiesJq661w1RBAs1PlXzelnzcHZbjatVZKw3cVSCVuNz9ytVoDoA1AtOjCsU4IRL bsk/K6txt3forPfu1o29MFOnEIN7m3vL8zBYP/1Xy37z4OQBWFnkEq5tNhniI7cFtco0xEvtJgB nYZf9VkjAhjCRhIO62XoAyuc53a4HQFMOnaYEF92aaFx40MoC8K32G8nmWbvS7QfojoxIhzuLzz CxTMuQpANJA1plO+j/dc9j8Grlyu27134qfMuCJA+5q4E3yqoP1p3i0W6j4Wz/FieikwC5wH1ho FuLEZ7KBoewzkLs/ZxVlhNBMQ5t4blxPOznJzZgxokcRAakbU84qxDIO7QJg8Thy/qZ7xmrGz0e dkzdbafRZcFbF0O/fT23dKhJuKnI5wJSAv/USJO77iPp7exfvKrg521Cuald1Bfcnu3CXrUSL2Q aW53oV1ybV3UJlJM60PkZ77og4xkTKDvAGjCdbF4VoSYLgglI23oHbVVc1U7fE6edinHIDWQ== X-Received: by 2002:a17:903:acb:b0:2b2:5503:1b8d with SMTP id d9443c01a7336-2ba535c157emr40983995ad.6.1778003231163; Tue, 05 May 2026 10:47:11 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b9cae3b169sm148663355ad.63.2026.05.05.10.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 10:47:10 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, sakari.ailus@linux.intel.com, christoph.muellner@theobroma-systems.com, martink@posteo.de, mfuzzey@parkeon.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 06/10] iio: accel: mma8452: convert to bulk regulator usage Date: Tue, 5 May 2026 23:16:36 +0530 Message-Id: <20260505174640.3998281-7-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260505174640.3998281-1-sanjayembedded@gmail.com> References: <20260505174640.3998281-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda The "vdd" and "vddio" regulators are always controlled together. Switch to the regulator bulk API to handle setup, enable, and disable paths in a single call. No functional change intended. Suggested-by: Jonathan Cameron Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/mma8452.c | 59 ++++++++++--------------------------- 1 file changed, 15 insertions(+), 44 deletions(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index b49949792190..1c984c708ec3 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -111,8 +111,7 @@ struct mma8452_data { u8 data_cfg; const struct mma_chip_info *chip_info; int sleep_val; - struct regulator *vdd_reg; - struct regulator *vddio_reg; + struct regulator_bulk_data regs[2]; /* Ensure correct alignment of time stamp when present */ struct { @@ -1570,25 +1569,15 @@ static int mma8452_probe(struct i2c_client *client) if (ret) return ret; - data->vdd_reg = devm_regulator_get(&client->dev, "vdd"); - if (IS_ERR(data->vdd_reg)) - return dev_err_probe(&client->dev, PTR_ERR(data->vdd_reg), - "failed to get VDD regulator!\n"); - - data->vddio_reg = devm_regulator_get(&client->dev, "vddio"); - if (IS_ERR(data->vddio_reg)) - return dev_err_probe(&client->dev, PTR_ERR(data->vddio_reg), - "failed to get VDDIO regulator!\n"); - - ret = regulator_enable(data->vdd_reg); + data->regs[0].supply = "vdd"; + data->regs[1].supply = "vddio"; + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(data->regs), data->regs); if (ret) - return dev_err_probe(dev, ret, "failed to enable VDD regulator!\n"); + return dev_err_probe(dev, ret, "failed to get regulators\n"); - ret = regulator_enable(data->vddio_reg); - if (ret) { - dev_err_probe(dev, ret, "failed to enable VDDIO regulator!\n"); - goto disable_regulator_vdd; - } + ret = regulator_bulk_enable(ARRAY_SIZE(data->regs), data->regs); + if (ret) + return dev_err_probe(dev, ret, "failed to enable regulators\n"); ret = i2c_smbus_read_byte_data(client, MMA8452_WHO_AM_I); if (ret < 0) @@ -1723,10 +1712,7 @@ static int mma8452_probe(struct i2c_client *client) mma8452_trigger_cleanup(indio_dev); disable_regulators: - regulator_disable(data->vddio_reg); - -disable_regulator_vdd: - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); return ret; } @@ -1748,8 +1734,7 @@ static void mma8452_remove(struct i2c_client *client) mma8452_trigger_cleanup(indio_dev); mma8452_standby(iio_priv(indio_dev)); - regulator_disable(data->vddio_reg); - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); } #ifdef CONFIG_PM @@ -1767,15 +1752,9 @@ static int mma8452_runtime_suspend(struct device *dev) return -EAGAIN; } - ret = regulator_disable(data->vddio_reg); - if (ret) { - dev_err(dev, "failed to disable VDDIO regulator\n"); - return ret; - } - - ret = regulator_disable(data->vdd_reg); + ret = regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); if (ret) { - dev_err(dev, "failed to disable VDD regulator\n"); + dev_err(dev, "failed to disable regulators\n"); return ret; } @@ -1788,16 +1767,9 @@ static int mma8452_runtime_resume(struct device *dev) struct mma8452_data *data = iio_priv(indio_dev); int ret, sleep_val; - ret = regulator_enable(data->vdd_reg); - if (ret) { - dev_err(dev, "failed to enable VDD regulator\n"); - return ret; - } - - ret = regulator_enable(data->vddio_reg); + ret = regulator_bulk_enable(ARRAY_SIZE(data->regs), data->regs); if (ret) { - dev_err(dev, "failed to enable VDDIO regulator\n"); - regulator_disable(data->vdd_reg); + dev_err(dev, "failed to enable regulators\n"); return ret; } @@ -1815,8 +1787,7 @@ static int mma8452_runtime_resume(struct device *dev) return 0; runtime_resume_failed: - regulator_disable(data->vddio_reg); - regulator_disable(data->vdd_reg); + regulator_bulk_disable(ARRAY_SIZE(data->regs), data->regs); return ret; } -- 2.34.1