From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f97.google.com (mail-oo1-f97.google.com [209.85.161.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928643E5572 for ; Tue, 5 May 2026 18:27:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.97 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778005645; cv=none; b=Gc8rYiNfKKAj6tKT9deW4bUjR6B9FpMvAIomuaUD+6mCIQEYZr6ryiOs6LQaEtjpkZtmyHKfoVbwYAjcmD4xsNxNKylil4uZItVoZfusJNvWU4oYToJKyW9xcAg+e5YRcXBZcD+3/63bcDLmDU82PDUc20mYVnmflHAudUgOMFI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778005645; c=relaxed/simple; bh=h2AlK+8MmYvPuW3IDG1cxyc7bUV8nvXUFzn2jnDpp6A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nNvJKpMW0v2TrPe3DhUKFtKmduF5Mua/0+as9xMCTyumyqn6yh9NiYRI50Zcw0kQ+iW6I5iWkd9HuzIRa/8+ARaamItRbwpnWSPaDvV/pK9rIEdYDvHxAxZls0pHzVj5eC05IuvxU6vUpkaKCcNKG8cTr7dfOSZbSHRr95aMdi8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=TWlmJD/f; arc=none smtp.client-ip=209.85.161.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="TWlmJD/f" Received: by mail-oo1-f97.google.com with SMTP id 006d021491bc7-6981f0b9b30so136731eaf.1 for ; Tue, 05 May 2026 11:27:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778005643; x=1778610443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGNm7c854bmsEYSmmRpo3hBYxzAKRiuBt/6viyvE9RM=; b=jpCRzJM9mtymMyPcY6uRLXGvjUouZaNlf8SPgGAovoMdJeDN2sLxwFEhxHGhgHx0Ly sXMGtoZ/VBYxe3jsrOnxLTPWvtFyfazt8nzj2TQFWiZZ1ApfjBzjupnaCvNeXanfL2Di s35nJJEYSSgpCzP8SCHdjtdzZRw8OpZWUrzHugOrS28YI2jVexhWPxmQfGdTNGCJbV6r ZnLSyGQ9T0eH+Rtnn76KGcQrkGV9ktpT1UujBA6BS4kSXuW/kCG6IjT2bNXnCcumNTgB p7vBG3hiHZdkGnPH8YS6PrieZKfpUUswHYqljn1hqNjyWgpdotwBUiwOAPZzCFygvcrS b/5w== X-Forwarded-Encrypted: i=1; AFNElJ81Pu9N39mBtLeHXHF/Y/pZmiULWVDgIsZA4KpUyMBfyDIHNlTsy3WMmMBKWL9X/snhm4qdjJtbCAu+7Kw=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2RGRHH1IYxq3HCQGFGupLPapi8KLUfXEcRuLFApOa7hn/spEW yQpGQ2LlZf17ssZmU3zOhQ4HHwmsT/CZPQcoGKZL5iRXbyB0uc4uE69Ent822yv4pPwhkxKyoqr 4SiNTrts6MbEYNOOw78bjpdN6qUouGpXV95dFnqX0jHmDnIsp6cQgEE6wyGEuOojn3ULV9IJGts P8RvqslvNUkgF5ftwW934gMNUrDOPkt6oVNikLTz/8nVBoN1PSNpKw8cJBmJQ1wvrB3jQUo+7vz 1mgcsljwMacRKcyvLQGlKw= X-Gm-Gg: AeBDiesN7kAhvemISt55l8ERpogI9NnMrdmZUzW/USlSP0MRZrvxEqs0rZP2+NG+Ddq Y2+7W0j/44jG/0s8KZ6l8SWz4lqfDAAOYWPeZgKS9wwMGWP2XPovhG+RlRZlMq0oPlr9mrC/Xni gkKt6dOhRYznyVsMpWxePaRS2laD1pPjCP42todGKPU3c5TGVs0KGyO9nhug5PcEW93FFhs9v0x N3abK37MiRBWwOi/nP0869SrAoG36oB3Hqky76TKf21/BvrigKpjcgAnizwUlCCce3XsFJ+V1uo vus5qNnniwxOVk0wRyzLzU3PwCkA9NZueqf3zUhrHuePHSUnIFpxc3valmmIyae46NJeYHOwJ/5 sA7GaJpFpGWBxt9fr1SlcAQeiXEPbgrLWruFH2uLD+9LgqGMU6I1ColRfiFuJ//SClo8SNCnuI+ c1PdcpJvwOcNSaKWOh X-Received: by 2002:a05:6820:c2c7:10b0:696:8fa7:5f20 with SMTP id 006d021491bc7-6998e1dc7f9mr880076eaf.1.1778005643536; Tue, 05 May 2026 11:27:23 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id 006d021491bc7-696893c66c6sm884466eaf.1.2026.05.05.11.27.23 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 May 2026 11:27:23 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8acb4b340f4so10264586d6.1 for ; Tue, 05 May 2026 11:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1778005642; x=1778610442; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nGNm7c854bmsEYSmmRpo3hBYxzAKRiuBt/6viyvE9RM=; b=TWlmJD/fcJT1MZPj75aqWVeWnzjzrf6PsNjZmvGHMuhHCGMgQ0Ul72gJK4GuNMb9DX MiHzWxZIhfZ+UHr/XNXZ7eHEz9WcT0Wk2H9YTlNUi5AWfJ1HgYHQTUgI8IB4A/3Gz/gM +VFic31X8XOafKkvaXvkgq41i04VvcC3gWWMo= X-Forwarded-Encrypted: i=1; AFNElJ9Oyoy2kCGxGWKG4Ok9YSTVY0nCoBzDn3s1mLj1AYk31AYdKVEq16mE7Fu1ikYffhz0GT9KHYLjsCYH4Ik=@vger.kernel.org X-Received: by 2002:ad4:5d4d:0:b0:8ac:afca:a68f with SMTP id 6a1803df08f44-8baf24a16a3mr45786826d6.1.1778005642417; Tue, 05 May 2026 11:27:22 -0700 (PDT) X-Received: by 2002:ad4:5d4d:0:b0:8ac:afca:a68f with SMTP id 6a1803df08f44-8baf24a16a3mr45786396d6.1.1778005641958; Tue, 05 May 2026 11:27:21 -0700 (PDT) Received: from photon-d7fac424c0d3 ([192.19.161.250]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c6b688csm170263516d6.33.2026.05.05.11.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 11:27:21 -0700 (PDT) From: Ankit Jain To: edumazet@google.com Cc: kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net, pabeni@redhat.com, ncardwell@google.com, kuniyu@google.com, horms@kernel.org, shuah@kernel.org, quic_subashab@quicinc.com, quic_stranche@quicinc.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, karen.badiryan@broadcom.com, ajay.kaher@broadcom.com, alexey.makhalov@broadcom.com, vamsi-krishna.brahmajosyula@broadcom.com, yin.ding@broadcom.com, tapas.kundu@broadcom.com Subject: Re: [PATCH net v2 2/2] selftests/net: add packetdrill test for locked SO_RCVBUF SWS Date: Tue, 5 May 2026 18:23:29 +0000 Message-ID: <20260505182329.15353-1-ankit-aj.jain@broadcom.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Thanks for the review. > I do not see the SWS effect you want to avoid in the first place. > > This test is an ad-hoc test about your change, but I still do not see > why recomputing tp->ratio every time the rcvmss is increased is an > issue on loopback interface. For the packetdrill script, it is taking more time. To actually show the window dropping to 0, I have to write a long script with many packets and application reads. This is because TCP does not shrink the right edge of an already open window. Since the C-code fix in Patch 1 is tested and working fine, should I send v3 with just the code fix first? I can work on the packetdrill script and send it later in a separate patch. Or should I wait and send both together? Kindly suggest how I should proceed. Thanks, Ankit