From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC4671E7C18 for ; Tue, 5 May 2026 23:46:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778024767; cv=none; b=QNO7UitrAg/9Y3Y7l012q/P0pxwJ3HEq1VXi7j3C2D8hU6uYHUba/RccaNF3HXASVfx26+Ju6e8qIcT8tIkI4xZBNI8rLscECvQ/llOOT65/dV8g25R9ara91jtJXateIqV//psCCcf3wKLqszO6D+bnwWzD3EUygfuiZfPjLJ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778024767; c=relaxed/simple; bh=NM+OEENnYblwFBqI7ILf5ldnldatXk3aJmPPoPbIhCI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=quxKzfMS8AeIIYrSSRAV2KCiRJ5/TL8MreQlO+61VlF25bVT8SMK8bdHzY93Cut8//gGYI5ESYndQBKwrYd3rTd2ZGLrzrjyymFDFkoKlpmDWCAZMtCxvSGcmw6kDHbIX6FeIPjYekGVe6RPLKowdy0N0w1b1tRrRnfnOm27Tf4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E7Eq5Z/T; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E7Eq5Z/T" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-38eab6cf7d8so49809771fa.1 for ; Tue, 05 May 2026 16:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778024764; x=1778629564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LYEKKpUfVkavdHLKVA6iz5gKTqlOA3vClvdLRGh0BhM=; b=E7Eq5Z/T/HixNVTv/qDkun0/wuSnxWcnjGBNg1Fy5mA3wBukarfZHVoreye54cMEIe PvkrlEXhZf+4uksg1bxM4/oBo6ScNc4e+xlx/JjgaTEVbOc0KH/tArFPz2/wYNe2lyGD qRcP/icXwHiySFKRgfIuByPHvdpCcQh2EFL7+ipwvfmOvmKUO6zX56KPRzB8Et6cGKZ1 c0oiMxQ3UXJVfa++uBS2h3cL3CNJMRcv7zYGT5KgM986Iv2nwfXdxTm761MtxPQjNTB+ 2c6fvM3CLNyd//M1nql/+JxhigYU+3Y/VQdBtkvIbxFvcO2L+NQieta+NNsn7IHyDHro EPfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778024764; x=1778629564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LYEKKpUfVkavdHLKVA6iz5gKTqlOA3vClvdLRGh0BhM=; b=GrNLD8EB/sgo0HHG7SczRiCo7qT2rWpmjSfPaRwS/AWrLfZUmZrNOnC+XufVQX78TJ czfmJ4o7dqltXawK3Oo7svHovQ6pMFffnHjN5U37brHoc7PtnnycxzThZFMjxG7N0sPD 44wl4LcnceELxW8V89ZX5KpCfz80BUe8tLfBwyu2XQ4xSukzcljSp+4HGcUUh9uzXBXF k2TOt1AArswpIU76jVBDUrCk82C3r0srIU6hkQ+yg2uQLDFSEg9GPQVfwC9E2FqTuC8I DINFrLnzW3vPg5UqjA/iK2XfQWgKf9n3UqO36KC/vlAcieYZH6iRtUVh65Oe5ob2JZbu hLWA== X-Forwarded-Encrypted: i=1; AFNElJ/RB79Uw8UUumHaLQQgt/nhhxv0d4+euXJWg06cQtG8NMDv4M6YOmjd7x4TwQFEaoptioICWQeoYyzhJGs=@vger.kernel.org X-Gm-Message-State: AOJu0YyMvylkDurUSQhv3LZEO2RVGjIGthO2sVH3hVy4hEKt4TnCMXBG GpR7DcpXleKxC+yweJlo0y5U5SvTYRKi0LJ7PeNcWhgOK1EmCI0P8oly X-Gm-Gg: AeBDiesAbeqkr31R02hXakcUr+S9Xf4qPvMEmh9orzlpQBrzCKOUp+Atyv0SeuVbLsh 9VS8XxlGCKwoTHCIx/ytq53cShTJqAPIsx7i5cLuQb0gDSc3CFFlZaHScG3wIMIoLXNymgGuUEU cCDJHFN5HQ96mhQR9LATnbFwZj+B9gGEIf1fhqK/FeSOEFsTg+49Wtfy0Hw9JGsj5lRKPr3fT9/ kGwjQPGKDBQK/oARMnOvX3FLnbYyf1XbbLIVSsJWfYt0Aiz3m74bOHkCS3wzBJHMdQJP6EoMjux KK+KQl+cl6ceNcG2HQcCvCSlZr8tiak8Q4dUVSdqveEzicJfbjYLN8C4hZmapFHXxOTlx1EHEno CeVwB/YWomqERngPRtbEADZbkdurw0ue8012Nl4tDPP+ffEAAo2ckQnGNTlPTYhJI8bL3YxOqR4 gdgejQGN4YpH7es71eoUnFVTBgtITN1GynIgmZXjeoLixBKDRAi+9n+PU+u2eYyKJTbAYR4MltK HWLUw== X-Received: by 2002:a2e:84cc:0:b0:38e:2aa7:398f with SMTP id 38308e7fff4ca-393c40f27camr3232221fa.7.1778024763888; Tue, 05 May 2026 16:46:03 -0700 (PDT) Received: from Shofiq.home (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393937ad8b6sm27582841fa.5.2026.05.05.16.46.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 May 2026 16:46:02 -0700 (PDT) From: Md Shofiqul Islam To: linux-arm-kernel@lists.infradead.org Cc: nm@ti.com, ssantosh@kernel.org, linux-kernel@vger.kernel.org, Md Shofiqul Islam Subject: [PATCH v3] soc: ti: knav_qmss_queue: free resources in remove callback Date: Wed, 6 May 2026 02:46:00 +0300 Message-ID: <20260505234600.8196-1-shofiqtest@gmail.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement the TODO in knav_queue_remove() by stopping PDSPs and freeing queue regions and queue ranges before disabling runtime PM, mirroring the cleanup performed in the probe error path. This ensures resources are released on driver unbind and avoids leaking queue/region state. --- drivers/soc/ti/knav_qmss_queue.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 86d7a9c9a..8d8245352 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1873,7 +1873,11 @@ static int knav_queue_probe(struct platform_device *pdev) static void knav_queue_remove(struct platform_device *pdev) { - /* TODO: Free resources */ + struct knav_device *kdev = platform_get_drvdata(pdev); + + knav_queue_stop_pdsps(kdev); + knav_queue_free_regions(kdev); + knav_free_queue_ranges(kdev); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); } -- 2.51.1