Re: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true

[gregkh <gregkh@linuxfoundation.org>]

On Tue, May 05, 2026 at 02:59:34PM +0530, Ashwin Gundarapu wrote:
> >From 833733dda327c72d63bcfb18701fadabae03e4d2 Mon Sep 17 00:00:00 2001
> 
> From: Ashwin Gundarapu < mailto:linuxuser509@zohomail.in >
> 
> Date: Sat, 2 May 2026 17:19:48 +0530
> 
> Subject: [PATCH] staging: rtl8723bs: remove unnecessary comparison to true
> 
> 
> 
> Remove explicit comparison to true in check_fwstate() call and
> 
> add spacing around the bitwise OR operator to improve code style.
> 
> 
> 
> Signed-off-by: Ashwin Gundarapu < mailto:linuxuser509@zohomail.in >
> 
> ---
> 
> drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 3 ++-
> 
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> 
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> 
> index c70541f95a73..c100a0d70fe2 100644
> 
> --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> 
> +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
> 
> @@ -151,7 +151,8 @@ u8 rtw_set_802_11_ssid(struct adapter *padapter, struct ndis_802_11_ssid *ssid)
> 
> else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) == true)
> 
> goto release_mlme_lock;
> 
> 
> 
> -	if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) == true) {
> 
> +	if (check_fwstate(pmlmepriv,
> 
> +		_FW_LINKED | WIFI_ADHOC_MASTER_STATE)) {
> 
> if ((pmlmepriv->assoc_ssid.ssid_length == ssid->ssid_length) &&
> 
>     (!memcmp(&pmlmepriv->assoc_ssid.ssid, ssid->ssid, ssid->ssid_length))) {
> 
> if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) == false) {
> 
> 
> 
> base-commit: 26fd6bff2c050196005312d1d306889220952a99
> 
> --
> 
> 2.43.0

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.


If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot