From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4940D3DB646 for ; Wed, 6 May 2026 11:29:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778066948; cv=none; b=FVD7E4xkG9hICPaiXbRjvcQZX+9PYHdagkzczMV4YosG3k74SyCDC9qh6srJcV3TiLLInR6xxrkVpIABRJ4QfZh1amRG+ZkyOzl7zvIlnF9XGhHM+xkn6kB7NETGg9EeAz7+4lI796FyyypKDINwAzIDuXQTMwnAZ60DiLHpwVE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778066948; c=relaxed/simple; bh=GxLR7YcCdZ1H8oY6mm3UcnwudCwzHYD3vgBjosnOa68=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=KyBpmECUxxvG5CH1Wq+/v5gLP5W5R6Dg6fjUceFni6vQYmj+U2fyUEqwUexUUAjyap2S4YHWB35NvH2cEAY5zXrAY2IvzOYZ0RTF1p1Dnk/jxEUlXBBbt417Ioc482Gczqu6i4PktA6rDVCrxPQuAjmLTqbP6RAZwh0EMLRTWxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q1XEdT/m; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q1XEdT/m" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-36505450d0dso4758516a91.1 for ; Wed, 06 May 2026 04:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778066947; x=1778671747; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8SRkpzBtg7ElKGnjfbnst8QCSHEYY7joA8xwn5z+tF0=; b=Q1XEdT/mugWNxmP3G+r/EUhsQvBJTaVVVA4tk3Dthp3SszKZ4BfeXpz/hevVSphmK6 wKp8HqYlvqYbbBMbOGmUbTzHTPQ5/Ht2jo69jLUhy8YuWszMh94bE3n3I61/8XERsFp8 MNHAegT6GRwX18tpWZKY8GsC7zjNI3PuZFBTOcIisL1j0quo8nSn32281af9Dgn9L3ke 6Z/5mvHmwBjOPbPhK4F1rT4UvH0ZXjK15mceMrtuOJRwzW4lMINDWEAwB+5pcLt7rSD6 3GeVFGx5gM8+nxiX3wzOmuLW4hJnss3bfgmmcuf+aqn1sYeJHK5ZeTeVm86OIGkM8s7+ ySAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778066947; x=1778671747; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8SRkpzBtg7ElKGnjfbnst8QCSHEYY7joA8xwn5z+tF0=; b=hHnoEQbFnpIH7+V8qP0McOYLtis1GHAY+xzYPk1NTjW2ueLNke+444j4X6B09vPSV6 7FNDGrxGKuqVKflvUTzXPbTkSIyB/d2uXfkfvwV/EAXgy05UbbtEDv4wBRt40IIUQ4Ch Ohkqh3GjDLYg8bKeRey8nEU/cqw6cp94iYELTkEcTCGsESgfYo2uOkivG7F9C+5vLvRc T52axl48QEVGt9/ljxPNIiiB1/21ak4uloigQ1VGNuM04JeAXSW/P6VGyc2XW1hjrqJE GrO13aR4SPyFBnNCm5SqlRHdpl2qO8X26kSvdkMHH7XzKO4+iZ6SWsnqwVg6k+EXKY0m lM6g== X-Forwarded-Encrypted: i=1; AFNElJ/9Wr/cqhPanKy1IHXoqXnFhf84X//bAlJkNWygr73lQHaXVjHUz7vCqQSWzfrDp9e6+ew/FgAR7PqBCtw=@vger.kernel.org X-Gm-Message-State: AOJu0YxXx/CCrDdMDk3MY4QeknsVC+KU1N9UVrePjUfZAimxexAxt3IY Rv12aB8/ocEOgUc0LaluYveco+WwLo8LUeJVm+iCvmb6+0DIo4MTQD1C X-Gm-Gg: AeBDievbddcTa2/zO6HCuwr0YeGipQJBLWbZi1o5VwEGRJ2hR6e9PzAh4rJLFgVIhIN sY5WGAUghRa/hWjG0XtaAdCC7mGjpunbrI//a+ZqwhM/RXDBAXlM/G56BE1ZK4az25RZd7JANoj 9Zbfw8ie3wC1AIPdz+1BnFDpTcJy+QrQ0EvFvBFwLMUG34zpmKQuCqBEYLDQ7I/W/5wJNsHAMoe Gr0I45InHdVS17/RlqRFPYX5CBLG4hIiM1MOV9SL7Xs1S8sdwZMdX2teuT+uQc0ifGK6EJZpJ9Q LIz5yBE89Vzd1lPrMH69K/C5oAcUVYJPH2U8vnbqiB7Fgo31S9kKmqCnSN808NQUOhXaVhFQ8nu pXYebeLTbZ5GTcPHxQuabJ3FLgQ4M3MdHHeHplAbWIWmHY24393YS5AySOY/0JZn43905dKCgTc Y+n7Ixe0Gv7oUwkQfRIn8TwXxOeR+0kgvi33p1ymUeMu9kI2udR2zRTScvDuZUlJxsB2V0GAud+ h7XlfXA6IXolkMuvnVcE7MqvYbtOg== X-Received: by 2002:a17:90b:1c8b:b0:35e:3e86:e2d1 with SMTP id 98e67ed59e1d1-365ab9dbfdcmr3031254a91.7.1778066946327; Wed, 06 May 2026 04:29:06 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.166.246.30]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-365df6f88cesm260826a91.3.2026.05.06.04.29.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 04:29:05 -0700 (PDT) From: Felix Gu Date: Wed, 06 May 2026 19:29:02 +0800 Subject: [PATCH] soc: microchip: mpfs-sys-controller: fix resource leak on probe error Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260506-mpfs-v1-1-a690c45178c6@gmail.com> X-B4-Tracking: v=1; b=H4sIAP0l+2kC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDUwMz3dyCtGLdZPNUIyNzMzNjU1MTJaDSgqLUtMwKsDHRsbW1AFftY3R WAAAA X-Change-ID: 20260506-mpfs-c7e227663554 To: Conor Dooley , Daire McNamara , Pierre-Henry Moussay Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778066944; l=1475; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=GxLR7YcCdZ1H8oY6mm3UcnwudCwzHYD3vgBjosnOa68=; b=1mhIdhK4+zckLNj8ftb0Uns6a6Y+qdcCEejfIfD1YMQS37T5wN33NsXjxuAA6pfZvvlrmaekk +0gUCW0q83HD3i3aBnW4DfIynNjIFNoilla/TuGUZ+qubK58aLbS/LL X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In mpfs_sys_controller_probe(), when device_get_match_data() returns NULL, it returns -EINVAL directly without freeing the mbox channel or the allocated sys_controller memory, causing a resource leak. Fixes: 63b5305ad84d ("soc: microchip: mpfs-sys-controller: add support for pic64gx") Signed-off-by: Felix Gu --- drivers/soc/microchip/mpfs-sys-controller.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/microchip/mpfs-sys-controller.c index 92d1142a59e6..0400a01b2338 100644 --- a/drivers/soc/microchip/mpfs-sys-controller.c +++ b/drivers/soc/microchip/mpfs-sys-controller.c @@ -158,8 +158,8 @@ static int mpfs_sys_controller_probe(struct platform_device *pdev) of_data = (struct mpfs_syscon_config *) device_get_match_data(dev); if (!of_data) { - dev_err(dev, "Error getting match data\n"); - return -EINVAL; + ret = dev_err_probe(dev, -EINVAL, "Error getting match data\n"); + goto out_free_channel; } for (i = 0; i < of_data->nb_subdevs; i++) { @@ -173,6 +173,8 @@ static int mpfs_sys_controller_probe(struct platform_device *pdev) return 0; +out_free_channel: + mbox_free_channel(sys_controller->chan); out_free: kfree(sys_controller); return ret; --- base-commit: 9d0d467c3572e93c5faa2e5906a8bbcd70b24efd change-id: 20260506-mpfs-c7e227663554 Best regards, -- Felix Gu