From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20773E0C53 for ; Wed, 6 May 2026 07:58:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778054286; cv=none; b=gt3MFr3hWABjx8KF+giT91+veFmbfxKqnm+6DB65X2XvXn0jq0PMYk3GaCa1ZTMbWPcZ7sAkmWRTCem+gOq84ZCrR/+SKTLX7ksXQ9VqIMthebj5OCeCkeweIvgKWSspi8RSP6nmwacZSq1SCqikfvRIfjMtbDvMjQDHabL8QQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778054286; c=relaxed/simple; bh=NxDn3Yx28HJtPbWuriUuKQ1bU4FkzVJ+n8JDBIb0o2I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VUabYYm8+LNODiqO1zCEY4qB5ioVMV4lTki4PpnnkIoXIeLub1xcvKPVyDrPAHolAJ55JG8WFXpA4H2xLPvNhFqsTH0/4ljL/h0PE0GcrTZDBXBPaXvJpEtQA72TGDSihY62i9pwkaarDQ7hdIuD9WoLgRcJE9f/RKE3NZPT/n8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=q9hTC8TI; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q9hTC8TI" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-2f0d3e07e30so5534780eec.0 for ; Wed, 06 May 2026 00:58:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778054284; x=1778659084; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0yP+mwFYhjefiJc9HNwtug4g60Bu6O6itewJ8verryo=; b=q9hTC8TIg2Uvbz2B18ecXgVKwj25Tc1ez3DbAA9ZeizaGQbAhnSZPHqZ+i/8y0ESDI buKGBdTKEh2sYMjk+S5W+Emb9Ym0mqd6jC0Y2+9QTdIcPM37JYx3W8iKSQrAMtNLGc92 3lFgH12Lx7OPV2B2ag5Wz6Tk8ZLWYMK/PCOpS3CeP+D999I0eWUnKXF4KO+QotjxcfMC qcjkUlZdRe0pTroYJcgY7RudcaXFfy0EH6dzggPoDOEURHKlrGvhZZPvTR0vFd/wK6dm OBtlu2bnQ5f7y4BIpQgDgiace6IqL4YYQM6LOAgTijVtd/qI53S8qdqpAQMebfdkIVJS i38w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778054284; x=1778659084; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0yP+mwFYhjefiJc9HNwtug4g60Bu6O6itewJ8verryo=; b=DljZqTgB4ztxGvra591uvQLOHManrR/U/lvzz9kVtXZBO9gCi5RZSLQwjRo+Lxb3p/ G5RdqFgxNWx8w2QU+6NZT21KJrioGScupfBgIg6GJSqUn/fLyVKZNjfWQZwhDwMXzPLZ iX7fKH+e98LHivRT4N0eCTFGHl30nQhyGAXQ2X3owEGIFbTMf8hNflvkoqVlIZ4k2WeB sUDZYPi3sYTLanRqNeMhU8iVXN6PKRz9nEsUKJePs6jdUfir3RdwIJHeJqyaN7/zc5R1 cbwkW9Kj8kgaKCTVnWCWIIWpdv3RAcl+C1XcgsKeJey09p5w7SQYJ5+zScxAuWhuVrxf OoSQ== X-Forwarded-Encrypted: i=1; AFNElJ/vfAQAISR7xGWrilibJ7lWyqiE6pAfUkl0vUk5ixpvNtdiXFB8MZvUSdim6NIzAB/HjvaIaFORb5QHSzI=@vger.kernel.org X-Gm-Message-State: AOJu0YzmJfUZNnb7fBsCjn8ReSN8uprqVOmA9gdyVrO05yASSn1vhqu7 RZpnkVuxnsQG1tmV0jbkHovlYnUQDKkjB56AyuTQNgrUpJMztvF10gCW X-Gm-Gg: AeBDieuTCWUeHY6zB6qGJBRakLhp2C2ELIY+phwsPEf7mMS24829yruy6n8bT4zAGXI oiOd+eqRGQViZ6S00TACvMJpVLqYBWtpul9sMroHe1tOrQzfoXpWoc49dM+uWoflb2Hl/5IwwQH U37veXFjoQ0XbpNyn6gSGZ87srkG8sipIC4TWyF80fLOJJxgmERVEpyDiYpu70znJzTpVT55t8X rLhdb+5/Y/p9Wlfz+vPjtxM7IYEBbMiyCcyvVta2dzrcGi1tCzWFSybL8C8+Jxd6zsOU0PrR58V XBQyW6zIjEJ6QOYqV/7m31AWW6kmn8gFFyGLlGHNuZ0PaiZC1CO0DDL8sYMvSelJ3KWxnfazrkV 4DumAke2mI0HdWBRQIWrXvO2kpdSGo0maThGP2IyJzzZSreWBNfl76f3JTI6JnnH0Y8QmJZQeCW 3a76ajJ3eKmwmDFDV+DFqH5LkeDzuhpuN4xLmjpoWLELOlQu8KwhOoT6Nh/Nl+oJ2LSQ== X-Received: by 2002:a05:7300:4794:b0:2f2:5726:db4e with SMTP id 5a478bee46e88-2f54ac74abcmr1120763eec.18.1778054283787; Wed, 06 May 2026 00:58:03 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f56d4cf2fdsm2416561eec.8.2026.05.06.00.58.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 00:58:03 -0700 (PDT) From: Hungyu Lin To: thierry.reding@kernel.org, jonathanh@nvidia.com, skomatineni@nvidia.com, luca.ceresoli@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org Cc: hverkuil+cisco@kernel.org, dan.carpenter@linaro.org, linux-media@vger.kernel.org, linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 1/1] media: tegra-video: vi: fix invalid u32 return value in format lookup Date: Wed, 6 May 2026 07:57:45 +0000 Message-Id: <20260506075745.28574-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260506075745.28574-1-dennylin0707@gmail.com> References: <20260506075745.28574-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit tegra_get_format_fourcc_by_idx() returns a u32 but uses -EINVAL to signal an out-of-bounds index. This results in a large unsigned value being returned, which may be interpreted as a valid fourcc. Returning 0 is not a valid fourcc either. This condition should never happen, so use WARN_ON_ONCE() to catch unexpected out-of-bounds access and return a valid fallback format instead. Suggested-by: Hans Verkuil Signed-off-by: Hungyu Lin --- drivers/staging/media/tegra-video/vi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/tegra-video/vi.c b/drivers/staging/media/tegra-video/vi.c index f14cdc7b5211..456134a9e8cf 100644 --- a/drivers/staging/media/tegra-video/vi.c +++ b/drivers/staging/media/tegra-video/vi.c @@ -80,8 +80,8 @@ static int tegra_get_format_idx_by_code(struct tegra_vi *vi, static u32 tegra_get_format_fourcc_by_idx(struct tegra_vi *vi, unsigned int index) { - if (index >= vi->soc->nformats) - return -EINVAL; + if (WARN_ON_ONCE(index >= vi->soc->nformats)) + return vi->soc->video_formats[0].fourcc; return vi->soc->video_formats[index].fourcc; } -- 2.34.1