From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E1313E2779;
	Wed,  6 May 2026 08:11:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778055111; cv=none; b=muPhe7S19bKC4eDTzEifrvvwNUh12dTtgrKhg/RFB+duwxRKDcviSc582Ud5pBzI/V3b+ezF8/bynY03tRHOjzcEff4+ZeVTwqL859T44XktUKPdpFuyPVfIBD2ISKwwtjsXcSCUbEc2vruAO8ihNHjP+aLj7AaJ1Tfm8kl5mb4=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778055111; c=relaxed/simple;
	bh=j3fnrLvGTp6RctkwUexfBhv7NHZhB5KQ2/b1bV9jJ4Y=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=GI5hKDwXFZHvWRIuxWtGO24/VYVKc91tTa/qv6YaWa0/2MbLKKG/IrXsu1yzJVuXY3ZPwpSEbvy3uVr5HOWsTlC/7WhBrptawmoYohHIv8eKDC7cd47aoNlBOjfMSVVz43QO2dwq0vuEBD/XgmK8IeU+ZFGSL5i30TVgSw4gQDE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=uKHoLV5J; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="uKHoLV5J"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73699C4AF09;
	Wed,  6 May 2026 08:11:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1778055111;
	bh=j3fnrLvGTp6RctkwUexfBhv7NHZhB5KQ2/b1bV9jJ4Y=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=uKHoLV5JmOyVnyBEYEGFp0XfSFL/C897jBp1vnjIdMizX+t8lxxPusPUqRNLDMqcT
	 tJAi87Y3fcly6C6vpgxuZlhsrUErQvM7OR1RnE3XijTbbtLJc/ViiQ5fqQ7pgccxi9
	 ladnYkVL3EfhXC2qRLrbihPU6z5FuyiaNMAyBGAtZMcvpfK+q/KJLUBR8GhnFQZytn
	 +mm30/SRACHDibXGjPPZRXjnlSoVI8M+yXeg6TlBTQAns8TEDJnasKY0ZxAkvw1Cbb
	 rc7DGuUrwgyGNWOL0OFS7xv1KQNwnPovKnmelp1olqMMheLYHqIJWxXIXcQhmZCvL3
	 Qy1VfqoyJJKCQ==
Date: Wed, 6 May 2026 09:11:45 +0100
From: Lee Jones <lee@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Heidelberg <david+nfc@ixit.cz>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Kuniyuki Iwashima <kuniyu@google.com>, Kees Cook <kees@kernel.org>,
	Junxi Qian <qjx1298677004@gmail.com>,
	Ingo Molnar <mingo@kernel.org>,
	Samuel Ortiz <sameo@linux.intel.com>, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nfc: llcp: Fix use-after-free in llcp_sock_release()
Message-ID: <20260506081145.GA305027@google.com>
References: <20260429134115.3558604-1-lee@kernel.org>
 <20260501162759.06ef164b@kernel.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260501162759.06ef164b@kernel.org>

On Fri, 01 May 2026, Jakub Kicinski wrote:

> On Wed, 29 Apr 2026 13:40:41 +0000 Lee Jones wrote:
> > llcp_sock_release() unconditionally unlinks the socket from the local
> > sockets list.  However, if the socket is still in connecting state, it
> > is on the connecting list.
> > 
> > Fix this by checking the socket state and unlinking from the correct list.
> > 
> > Fixes: b4011239a08e ("NFC: llcp: Fix non blocking sockets connections")
> > Signed-off-by: Lee Jones <lee@kernel.org>
> 
> Adding David H and dropping from netdev's patchwork..

Is anyone looking at these please?

These are pretty important.

-- 
Lee Jones