From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A1D3E5590 for ; Wed, 6 May 2026 08:46:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778057187; cv=none; b=JZ/tCzRedH+hy3fRdEgRv11iLeIMHDkmhgEAitUaLEopiVUSTVMOv30Iu6uoHuXJDyjHengCO0WS68M/0tYI/51xYvz8DKijTgkH3sbditkyXoUfrMcFPU24gZQfKxNEf1kHWe3QV6S8+IBrtNRib2/0KhUCMdo1LfJZpiPel1o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778057187; c=relaxed/simple; bh=bUp7CVn30qUQD1WzOH67S84aqhWLyceTvkcN5eDW3+4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uEee3b4HG4OZP9+emUblzhOHDAVoJxive++Yg4V6xRxWsyVjClWjHTlVGQ9uvhYoGBUoKre2n/PuL7HQHD6g8P3MJFn2p1aw/uBk0kj98OWd/1R4KC52LcLL/Typ3Gsmj0OyxI9eZ+wiUecQIyM3iaiBriUK7q29Ax/mxa/y+bE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TD0iegDL; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TD0iegDL" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c8025500cc7so2522694a12.1 for ; Wed, 06 May 2026 01:46:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778057183; x=1778661983; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jUSdR9R631N14alNwqa0GqPMI72JdY9A7cqHTS5tg5U=; b=TD0iegDL7Mga0ASjr2/6pXaglrfpEvT7aVK4Jfi/33FzjpuMqVTubRrIpw8rIAkOlq Kxj0umSUzdrGNiZ5BlaFDAf0Sw87UHNmfLRLXPewdEPAVBBdbnoLGdw0sAew3yKhF9/1 tXHzbAIET7xq4YnFr1ePGrL0w9MojjfF3fOkjnYM8z9CVxd4zg6yMvBSa1o2GSdwkndZ yF0Lcocq6SMS1IzrrkIY1jFkTWUUHkxkivN0lt4rccaoEQGo06LavhJ/BiXNBpT+d9lw GoZ5sSqCfy/9THCtzMBjnvrSj3mv4L6ncGCrZ4ziusx1MJxrfkPc9A8o7L96Vip7Ooyu dc1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778057183; x=1778661983; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jUSdR9R631N14alNwqa0GqPMI72JdY9A7cqHTS5tg5U=; b=U1fqkf4TcWZnZMCUfQ4U/AyLIEvSmM9IyZ1xz4nkP1dlMTXxmED9S3nET4DVH3hms/ DnWo1DdMpQOIqpWYTTkTTJFvpM/0kjZ9StvH72idm9zvEoLf3agXDvvWhdaPG8/Yw8Z7 jMUfSgve6iph/HoB/22mFSakPIvRpQ4Kppd4xiafTd3no30tHrFqk79d8bkGlKMEn4Ld bX/b81pFxJbKesbr7XQfUatLHhdbuLJ8EAV5v0/ymPy7BVpU05dsQtRLwCPM/7Zwq6z6 yShBeumBjfijk8v1aTWgcypn4baXwxDzBzsXdTr31OcVGkZfE8fzOzPTycbD9M7SJe0l 32jA== X-Forwarded-Encrypted: i=1; AFNElJ+l3y/7xQIkIN6TLOkh8uGxvbjcm+YE2SPdN3QKVCPG5VWHyEaVQCpqDxq4u8JpprPAMaFY5M9XC6Piw8k=@vger.kernel.org X-Gm-Message-State: AOJu0YwXl+L8J/B9lt4Abe2hlO3f5kdc2b0j+TuPt2U1URH8ehA7q2u/ C2ElIHijBueAAT5QTNBhti+Pc3453669X3K3TsDGQmpZNAj1gi/dMwnq X-Gm-Gg: AeBDieuqZ01dzUn0+1VO9eOyk5GHbw18ai8SaW1t4cXHRiydmM/szz9H+surV47RNLQ VFW1LEixLjYSFhI5fVk+paKG8rt+xZhjyenxC2fnepBEm3fD8xRb09l+9lhkprR5vpQJnUZNubK 8CsLFnkAl7sRbyKoc4E95WjBW6wucf+JNpee5/tnGzYJTdzTMocYYFP81/E2nBF1EL/H23xzqAl z4X7PT757Wd0pfmjTNXTBousDVpxmfQipddEATql86Eyg+a/aVz994Ot544BcjjK3un8y+Ii8Z+ 55zY2NXun+IeMbYE0ObPkpkhM7tB9Z87pUv785P4O9kf/1ACuQZVnGKnDUqWGzE7uXwEDwibkRd 4uLFOX02RPbeh5Upd2NQFApjBLSC2JC6DdWNiMibFT/IJJc06wrcKXnBNSrjPOE+tNqv2k22GuZ zEqPdMt7gMOvHb/ssCeZbY9oqcfDT2ncLco17yOVxhcA932wfvNHOme6F9a8WRrq2GZeib2NUUZ RhdwOUCyhw1VjUFrWuGi64= X-Received: by 2002:a17:902:f650:b0:2b9:87e0:1f80 with SMTP id d9443c01a7336-2ba79c2301dmr26131495ad.24.1778057183288; Wed, 06 May 2026 01:46:23 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7bf2d72dsm18985145ad.25.2026.05.06.01.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 01:46:22 -0700 (PDT) From: Joey Lu To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com Cc: alexandre.torgue@foss.st.com, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH net 1/1] net: stmmac: dwmac-nuvoton: fix NULL pointer dereference in nvt_set_phy_intf_sel() Date: Wed, 6 May 2026 16:46:13 +0800 Message-ID: <20260506084614.192894-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260506084614.192894-1-a0987203069@gmail.com> References: <20260506084614.192894-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit priv->dev was never initialized after devm_kzalloc() allocates the private data structure. When nvt_set_phy_intf_sel() is later invoked via the phylink interface_select callback, it calls nvt_gmac_get_delay(priv->dev, ...) which dereferences the NULL pointer. Fix this by assigning priv->dev = dev immediately after allocation. Fixes: 4d7c557f58ef ("net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family") Signed-off-by: Joey Lu --- drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c index e2240b68ad98..2ab6ecac6422 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c @@ -100,6 +100,8 @@ static int nvt_gmac_probe(struct platform_device *pdev) if (!priv) return dev_err_probe(dev, -ENOMEM, "Failed to allocate private data\n"); + priv->dev = dev; + priv->regmap = syscon_regmap_lookup_by_phandle_args(dev->of_node, "nuvoton,sys", 1, &priv->macid); if (IS_ERR(priv->regmap)) -- 2.43.0