From: Thorsten Blum <thorsten.blum@linux.dev>
To: Jesper Nilsson <jesper.nilsson@axis.com>,
Lars Persson <lars.persson@axis.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
linux-arm-kernel@axis.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] crypto: artpec6 - refactor crypto_setup_out_descr for readability
Date: Wed, 6 May 2026 11:16:28 +0200 [thread overview]
Message-ID: <20260506091627.177426-3-thorsten.blum@linux.dev> (raw)
Replace if-else with an early return to reduce code nesting, and move
the variable declarations to the top of the function.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/crypto/axis/artpec6_crypto.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/axis/artpec6_crypto.c b/drivers/crypto/axis/artpec6_crypto.c
index b04d6379244a..75e1eac15138 100644
--- a/drivers/crypto/axis/artpec6_crypto.c
+++ b/drivers/crypto/axis/artpec6_crypto.c
@@ -706,22 +706,19 @@ artpec6_crypto_setup_out_descr(struct artpec6_crypto_req_common *common,
void *dst, unsigned int len, bool eop,
bool use_short)
{
- if (use_short && len < 7) {
+ dma_addr_t dma_addr;
+ int ret;
+
+ if (use_short && len < 7)
return artpec6_crypto_setup_out_descr_short(common, dst, len,
eop);
- } else {
- int ret;
- dma_addr_t dma_addr;
- ret = artpec6_crypto_dma_map_single(common, dst, len,
- DMA_TO_DEVICE,
- &dma_addr);
- if (ret)
- return ret;
+ ret = artpec6_crypto_dma_map_single(common, dst, len, DMA_TO_DEVICE,
+ &dma_addr);
+ if (ret)
+ return ret;
- return artpec6_crypto_setup_out_descr_phys(common, dma_addr,
- len, eop);
- }
+ return artpec6_crypto_setup_out_descr_phys(common, dma_addr, len, eop);
}
/** artpec6_crypto_setup_in_descr_phys - Setup an in channel with a
reply other threads:[~2026-05-06 9:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506091627.177426-3-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jesper.nilsson@axis.com \
--cc=lars.persson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox