From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6839335294E; Wed, 6 May 2026 10:33:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778063602; cv=none; b=AGHqlbtHd7SG9WwJa+qRxN4ZK/osfGGYjI94zCkGONaKM9oHKQg3ZWFxF3ruIMEz6TGBfzXRYSsFBmf5ls7xMTjzVSerzeRUgCug1VvfM04gygLf75mRxwFsXnoF7uRnkNJ8qAY61rdQV571FiplmfnrLyhAIh5uztxVhuO3q+M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778063602; c=relaxed/simple; bh=M5o+/YaupNYZyxmeKf2QjXgCKV0qcMjr7DPzv7F8Sv0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HtRb59Sv8iCsc1N7bIHBwPt/jjYCsWSIYzEd2ZnFE/Kmla/SBEMSgJWYGsgy4Y3uR/RrCbE3a8ryueRSTceC7lnkzGoZaz2ShugdLbha+lSlutoF5XQ8Q3y6jbu2ineRqEym5A3Jr69ax3TJCCmF4JaZyYMWsMkh62oL6TmL+RU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=dHhX2DDE; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="dHhX2DDE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1778063599; bh=M5o+/YaupNYZyxmeKf2QjXgCKV0qcMjr7DPzv7F8Sv0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dHhX2DDEb+wKn+xBlaCHlq6jRa1HZj+2R0vY7hAlUA+C+Zoap/YG7alIUX6QF2JuH iGWo984ywb6LITJ7cafk4pbvn2DS/7wUBPMhH0nXlMzQqSjx/ELpj6PTtYAsCFnprr gHgGF7r77Z50yxDgoF7V15ATETV17WYz10R+IypMMoEHxmYpyVhUW9244GtR4aZMrr px8CHnxYwp40tbLvffOrKczuvdf6qie1oISR6ZEtvS5p0MbMQKQPIaTW3bZYPYkoSG N1SjfcJWB9w5YQr31HrOSqFKu4oT6y4u7ppxfzDwvm3pdxYZGHcoyntDpuvIYjP6BP Jn9toahZwrSNw== Received: from fedora (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 64F3617E1227; Wed, 6 May 2026 12:33:18 +0200 (CEST) Date: Wed, 6 May 2026 12:33:14 +0200 From: Boris Brezillon To: Ketil Johnsen Cc: David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Jonathan Corbet , Shuah Khan , Sumit Semwal , Benjamin Gaignard , Brian Starkey , John Stultz , "T.J. Mercier" , Christian =?UTF-8?B?S8O2bmln?= , Steven Price , Liviu Dudau , Daniel Almeida , Alice Ryhl , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Florent Tomasin Subject: Re: [PATCH 5/8] drm/panthor: Minor scheduler refactoring Message-ID: <20260506123314.0f1c01cb@fedora> In-Reply-To: <20260505140516.1372388-6-ketil.johnsen@arm.com> References: <20260505140516.1372388-1-ketil.johnsen@arm.com> <20260505140516.1372388-6-ketil.johnsen@arm.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 5 May 2026 16:05:11 +0200 Ketil Johnsen wrote: > From: Florent Tomasin > > Refactor parts of the group scheduling logic into new helper functions. > This will simplify addition of the protected mode feature. > > Remove redundant assignments of csg_slot. > > Signed-off-by: Florent Tomasin > Co-developed-by: Ketil Johnsen > Signed-off-by: Ketil Johnsen > --- > drivers/gpu/drm/panthor/panthor_sched.c | 135 +++++++++++++++--------- > 1 file changed, 86 insertions(+), 49 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index 5ee386338005c..987072bd867c4 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -1934,6 +1934,12 @@ static void csgs_upd_ctx_init(struct panthor_csg_slots_upd_ctx *ctx) > memset(ctx, 0, sizeof(*ctx)); > } > > +static void csgs_upd_ctx_ring_doorbell(struct panthor_csg_slots_upd_ctx *ctx, > + u32 csg_id) > +{ > + ctx->update_mask |= BIT(csg_id); > +} > + > static void csgs_upd_ctx_queue_reqs(struct panthor_device *ptdev, > struct panthor_csg_slots_upd_ctx *ctx, > u32 csg_id, u32 value, u32 mask) > @@ -1944,7 +1950,8 @@ static void csgs_upd_ctx_queue_reqs(struct panthor_device *ptdev, > > ctx->requests[csg_id].value = (ctx->requests[csg_id].value & ~mask) | (value & mask); > ctx->requests[csg_id].mask |= mask; > - ctx->update_mask |= BIT(csg_id); > + > + csgs_upd_ctx_ring_doorbell(ctx, csg_id); > } > > static int csgs_upd_ctx_apply_locked(struct panthor_device *ptdev, > @@ -1961,8 +1968,12 @@ static int csgs_upd_ctx_apply_locked(struct panthor_device *ptdev, > while (update_slots) { > struct panthor_fw_csg_iface *csg_iface; > u32 csg_id = ffs(update_slots) - 1; > + u32 req_mask = ctx->requests[csg_id].mask; > > update_slots &= ~BIT(csg_id); > + if (!req_mask) > + continue; Looks like something that should be in patch 7, where you update the doorbell_req register, and then call csgs_upd_ctx_ring_doorbell(), meaning req_mask can be zero. The other option would be to teach panthor_csg_slots_upd_ctx about CS doorbells, and let csgs_upd_ctx_apply_locked() toggle the doorbell_req. > + > csg_iface = panthor_fw_get_csg_iface(ptdev, csg_id); > panthor_fw_update_reqs(csg_iface, req, > ctx->requests[csg_id].value, > @@ -1979,6 +1990,9 @@ static int csgs_upd_ctx_apply_locked(struct panthor_device *ptdev, > int ret; > > update_slots &= ~BIT(csg_id); > + if (!req_mask) > + continue; > + > csg_iface = panthor_fw_get_csg_iface(ptdev, csg_id); > > ret = panthor_fw_csg_wait_acks(ptdev, csg_id, req_mask, &acked, 100);