From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAE703F1647 for ; Wed, 6 May 2026 13:12:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073161; cv=none; b=TaPKnxxsQTtUFm90csnqKczjESK46nl1sv2HfDucTDLOGgt6idL5ZZBNJ3u8uYnXEieuzhtgisIA+u2yzp4E15TKqqId8daTiCp9g+WHxuGX8L+/SnPZiw+NCO07FYiZUm/Flv6MWsRSIW9tT5xYQab2ahgR4h65B9w9tcieP2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778073161; c=relaxed/simple; bh=X83K5mM1jYGkqZrBfO1Wt6FMuY7O2dGmxCA5gUpRXP4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=e9kUTslHcVOlHrg+AhYefnmfV9M0A6UWIaZZRAF+/MwzD7ayBqbO6MEhqLGpB5DyyUavWjOAOKEL9cRTUGX+zyS22RhcyhTj50iAMfRsYA/aYNXv/f7C94vCEkNDi6rau7FEfjnZpkj293Z8VRTfRmKn0r1d7AXDnTST3psFvzE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s/U2DIKE; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s/U2DIKE" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-404254ffe8aso881139fac.0 for ; Wed, 06 May 2026 06:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778073159; x=1778677959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kTEQSdm9N3Asj45KWJ/X8grv642fa/qSFTK0vp9knYo=; b=s/U2DIKEBP1H5O4CDwuuuR2Pr8w7yhZHpVdnzpOb77xI9lG/W2ksUET5RLClm3M7zX sz02BEefqYvil1c4ZRCPTeF2aM9jwWnAfBKemI2fPynvbbwanvOZzvUgZ6RAg1WVTaKW ONqGz3qeQf1eIWejbgECv4AEqLRvm4/NXFTE1WT6rP35ERTEq9Z6Xc/3OZhdGdqVAWml bAZwgPzONyhwGwvLn2gfExFz1qRF+j63Rvd+Tns+7+0QraHPM8/HMvOQNV+Boqh83o2K XK3AX3MoIA8PRYyyVVqWzpJh5TTywmfEaIDHfNHPMd1ShVbBsTt3eAGZ9GZ093A3bXcp BoRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778073159; x=1778677959; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kTEQSdm9N3Asj45KWJ/X8grv642fa/qSFTK0vp9knYo=; b=bWnt/frGg7ye3EULqbfpIrVhi6uK5QhWie8+IDbdzr0nWZ3atyip9ZO48fdMBtn0md VabvfhE7UzeEgmJP05J68TyD9diBGNUs/Z/taPX2iIQZu78IeF8HNogAqo2mKAoWgtOz eLJJSCg9dH44i6IG/wWinctFEM2x0md+PgOfppQS7a1IM6jTXNLRBdHLKv/l8xMqZQfF iwP0azMCSkgFMg8/TBbTv5fAUgBe+MeMp7hV/Ba37RRd4z5pvCxqcwBNuzgvOlT5u+a6 6vYhQ3mdwxCpo5mCGmAVkmbgCV/TE0Vvrzzmsj2hsgXF84JJu3VXGNlmnfrbvyQsuRu4 v4uQ== X-Forwarded-Encrypted: i=1; AFNElJ/5cADkxclOEIwmNqmg3zAv9o+bhgKbLRfhdMQ6LLeRJOa4I2ZkWGAwwPBYwegjk44VMj+9aYAUvLmfIdo=@vger.kernel.org X-Gm-Message-State: AOJu0YyfdR/pK4zNnQKEdR+helE0wK6/Sdvg8KoFc2u555jRSYXvQK1L LGmd8sCF5PmXVFFdYvsi1vtnnz4IfniNpty6b+E5KL21QLed8FBCeJE0 X-Gm-Gg: AeBDieuVf88RCwjsuhw1eBk+l/RXjRueqTmOcjwM9MkJPS4SJWRvw+pIwjRaAvX6GBp x8fi3Q57zlpRrTAuBHaHUKxAq+F/D9mzBe1KZ64Z8Nah5RQU408owhO/ugJgWFpC0t3phMoXlbc RuC3BO/h0N2odRJcR0rDRTa0sVOn7M0lbi2mvIQSBmsEuOm1DDfuTlPo1piO9yYiU6EeDl+meUr dNjpYE5T2u2i3Z2XsMs0Q5vKjM4Gs5ADVfDqCFcOUIP3lvlqzkf2TbNt2WTkJWFSRuQuxbAt4P4 AbDncnkCSvF/akGZsKC5293AoFPWPhvGXiTkGV/4owbFDPv885nouMT7TMMWm8iuzTPlTRwFSL/ LTp+Fd8OFhg9ibFL7yJdc85/34/npo3rQ81w3R/nkpqar1nF9PxedCK3Aaw6Q68C3Tp75jMccEb eZ+sm+0RpmDTiztyDL9b4vM3BYwQ== X-Received: by 2002:a05:6870:c04:b0:42c:b9d:8987 with SMTP id 586e51a60fabf-434f993e8c8mr1573181fac.10.1778073158763; Wed, 06 May 2026 06:12:38 -0700 (PDT) Received: from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-434548d9decsm17327859fac.3.2026.05.06.06.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 06:12:38 -0700 (PDT) From: Minxi Hou To: netdev@vger.kernel.org Cc: aconole@redhat.com, echaudro@redhat.com, i.maximets@ovn.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, shuah@kernel.org, dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Minxi Hou Subject: [PATCH net-next v6 0/2] selftests: openvswitch: add pop_vlan test Date: Wed, 6 May 2026 21:12:16 +0800 Message-ID: <20260506131218.1880852-1-houminxi@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action correctly strips 802.1Q VLAN tags from frames. Patch 1 extends ovs-dpctl.py with vlan(vid=X,pcp=Y,cfi=Z) formatting and parsing, plus an encap_ovskey subclass for safe ENCAP NLA decoding. It changes OVS_KEY_ATTR_VLAN type from uint16 to be16 to match the kernel __be16 wire format. It also adds push_vlan action support (parse/format with range validation) and removes the unnecessary MAX_ENCAP_DEPTH limit. Patch 2 adds the selftest using purely ping-based verification with a push_vlan return flow for symmetric bidirectional testing. Tested with vng on x86_64, all OVS selftests pass (including new test_pop_vlan). v6: - fix non-ASCII characters (em dashes) in comments and commit messages v5: https://lore.kernel.org/netdev/20260505124957.1239812-1-houminxi@gmail.com/ - add push_vlan action class, dpstr format and parse with range validation (vid 0-4095, pcp 0-7, tpid 0-0xFFFF, CFI forced to 1) - remove MAX_ENCAP_DEPTH constant and depth tracking (bracket-depth counter in encap parser already handles nesting) - remove start_capture/stop_capture helpers and tcpdump/pcap verification -- use ping success/failure instead - remove modprobe/netns pre-flight checks (other tests don't do this) - remove ethtool VLAN offload disable (unnecessary for veth) - add push_vlan return flow for symmetric bidirectional ping - use ovs_sbx wrapper for ping commands (consistent with siblings) v4: https://lore.kernel.org/netdev/20260504123713.555461-1-houminxi@gmail.com/ - fix all checkpatch line-length warnings in new code - fix pylint W0707: use explicit exception chaining (from exc) v3: https://lore.kernel.org/netdev/20260503120946.51869-1-houminxi@gmail.com/ - encap_ovskey: MPLS type "ovs_key_mpls" -> "array(ovs_key_mpls)" - encap_ovskey: PRIORITY/IN_PORT set to "none" (metadata, not in ENCAP) - _vlan_dpstr: cfi=0 falls back to tci=0x%04x for round-trip safety - encap parse(): check return value for unrecognized trailing content - vlan parser: boundary check + raise-from for exception chaining - start_capture: || return $? to propagate ksft_skip correctly - on_exit: moved after resource creation, not before - ping success: changed from NOTE to FAIL + return 1 - VLAN interface creation: added || return 1 error propagation - netns probe: distinguish EEXIST from missing CONFIG_NET_NS - sbx_add: || return $ksft_skip -> || return $? (match sibling tests) v2: https://lore.kernel.org/netdev/20260501133924.3100680-1-houminxi@gmail.com/ Minxi Hou (2): selftests: openvswitch: add vlan() and encap() flow string parsing selftests: openvswitch: add pop_vlan test .../selftests/net/openvswitch/openvswitch.sh | 77 +++++ .../selftests/net/openvswitch/ovs-dpctl.py | 322 +++++++++++++++++- 2 files changed, 389 insertions(+), 10 deletions(-) -- 2.53.0