From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2E11480DE4 for ; Wed, 6 May 2026 14:21:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778077272; cv=none; b=c8U5Tb5ucOAVBblWBQ16D+oHrxa3iRK168B9bAGny2Unq0AL2gpOAIjf0o981wMsHCZow7o6GnrK50BDCtxMjj+XD2xJqW6gJ40XMiIgZSyXg3whp+LFb4bqB4CJnRZaNe3La3603OizargW+6IjNTD1jEbb9h8rHHBUTROpUZg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778077272; c=relaxed/simple; bh=MmD1U3nnRQj3LfZUKEG0EDGj2LmxhX+n10m4292+5ck=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=tKiWOz19nw0TyvQkyBTixTTKJL4qp2rX1987Jqt0s91FS21vX7tpl9EGlnnFYT3jK++6lghnKtnbwDTtJdnSQ6IGZVEl0/K9Li4uj88VdWL8/xfnkhxEr7BGX6Xv7AjLcQwFikn32PsQpqIIxeOG+XotTXCPzRuzyiwHNpkxNPA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=qFdZ1gZI; arc=none smtp.client-ip=209.85.210.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="qFdZ1gZI" Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-83836443305so1360813b3a.1 for ; Wed, 06 May 2026 07:21:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778077270; x=1778682070; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=tYyTakcney2PvrBFUj5yhULPO2dy/QkUSR4wXxabzzE=; b=qFdZ1gZIEa5PubTzjc0LrRDCDZTEluH6ZMRWm0lkrrMWkouUicmqpGMCju5eH02j26 1WoOLHvSfMFwVbD7osePGD4Jf9awwSqCo8ruHwqo2IschHfFh5R/77lPXIzTMPi71jFf C3QXpYpYK4m8VTjUEF+Xkf9nIrPBDiJ3t08XZd04nDzE8Ti0ZjFXBmZJbb6AkLKipHCL w785IhZWi5vRgdpwnL3o6DQN7oNiFuER4Ib1AGJpnmGw3Uy8t2br/cyZfiTsOZtF4R+W 1BYOLIGoWhq6K3ijLb8pBY294zZuB4yu2JVtkh31haIuAfC0NzydBaz3SNOQ/RgrIyK+ yloQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778077270; x=1778682070; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tYyTakcney2PvrBFUj5yhULPO2dy/QkUSR4wXxabzzE=; b=IpBiDohWy+2puf7uTRA8pCMa8uRymJETFzWcDrMmluOXZ4acM6wxgGZe/rjAJL+ejq SUzwLTMJE0cLCfttGPoIfRQMQdb7TBVE/LXzLGWsNxU+v97v4ROVz3gsMUXwlyyFqv8F aPqsl7l7t3WFeUHCY8dERoewAYGam8klODzo4e6YR+Z+YC1IGSFOA5cFZOEq50LS+3y5 6+t6HnGx3CbobzLmMc/mnxttDlK2Xl7c42t6XH/3TVDmJixb5R1+e32uNQB9tdFneO3D 0eplFl4uzybr/fWlasLrNnfIusxw06z27+WmwDH+JCcde13kg44B/ubRSNy9VCqQJTFm xasQ== X-Forwarded-Encrypted: i=1; AFNElJ9NNrmjRKIbDuGfStpmwmLbAkbrIOqpZ+nqhxxNEARgBMWr77Zt8WhMbBSz1ydORHprEvixsTgakkZVe1c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1CyK+/YIHGM6G4jzrQl9q45fIlm84Ay4OfuGGkoh8k7063Ggp J/BuuazXE9pAzoL/gUEJsfdbZKrEH5RM1iqEuCJZNrYN7Wnjq2tuqXew3PuEt4ijDqrTjrfqkuh XX/salpowStmyc/mk0MHvqpdPNw== X-Received: from pfbio7.prod.google.com ([2002:a05:6a00:8e07:b0:82f:7220:86e7]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:b483:b0:837:6bb9:acd5 with SMTP id d2e1a72fcca58-83a5825898bmr3530611b3a.0.1778077269986; Wed, 06 May 2026 07:21:09 -0700 (PDT) Date: Wed, 6 May 2026 14:20:59 +0000 In-Reply-To: <20260506142100.1289509-1-joonwonkang@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260506142100.1289509-1-joonwonkang@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260506142100.1289509-4-joonwonkang@google.com> Subject: [PATCH v4 4/4] percpu: Fix hint invariant breakage From: Joonwon Kang To: dennis@kernel.org, tj@kernel.org, cl@gentwo.org Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dodam@google.com, joonwonkang@google.com Content-Type: text/plain; charset="UTF-8" The invariant "scan_hint_start > contig_hint_start if and only if scan_hint == contig_hint" should be kept for hint management. However, it could be broken in some cases: - if (new contig == contig_hint == scan_hint) && (contig_hint_start < scan_hint_start < new contig start) && the new contig is to become a new contig_hint due to its better alignment, then scan_hint should be invalidated instead of keeping the old value. - if (new contig == contig_hint > scan_hint) && (new contig start < contig_hint_start) && the new contig is not to become a new contig_hint, then scan_hint should be not updated to the new contig. This commit mainly fixes this invariant breakage and includes more: - Handle the cases where the new contig overlaps with contig_hint or with scan_hint. Merge the new contig with the hints in that case and treat it as a whole free region. - Fix the invariant breakage and also optimizes scan_hint further. Some of the optimization cases when no overlap occurs are: - if (new contig > contig_hint > scan_hint) && (scan_hint_start < new contig start < contig_hint_start), then keep scan_hint instead of invalidating it. - if (new contig > contig_hint == scan_hint) && (contig_hint_start < new contig start < scan_hint_start), then update scan_hint to the old contig_hint instead of invalidating it. - if (new contig == contig_hint > scan_hint) && (new contig start < contig_hint_start) && the new contig is to become a new contig_hint due to its better alignment, then update scan_hint to the old contig_hint instead of invalidating or keeping it. Signed-off-by: Joonwon Kang --- v4: Refactor code by removing the scan_hint candidates and handle the overlapping cases where the new contig meets with the hints on the border. v3: Merge the new contig with other hints when it overlaps with them and treat it as a whole free region instead of a separate small region. v2: Consider the cases where the new contig overlaps with the existing contig_hint or scan_hint. Introduce the scan_hint candidates to calculate new scan_hint. v1: Initial version. mm/percpu.c | 119 +++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 94 insertions(+), 25 deletions(-) diff --git a/mm/percpu.c b/mm/percpu.c index 0f5648669cac..549448754afe 100644 --- a/mm/percpu.c +++ b/mm/percpu.c @@ -616,6 +616,20 @@ static inline bool pcpu_region_overlap(struct pcpu_region a, return (a.start < b.start + b.size) && (b.start < a.start + a.size); } +/* + * pcpu_region_concat - determines if two regions meet on the border + * @a: first region + * @b: second region + * + * This is used to determine if the hint region [a.start, a.start + a.size) + * meets with the allocated region [b.start, b.start + b.size) on the border. + */ +static inline bool pcpu_region_concat(struct pcpu_region a, + struct pcpu_region b) +{ + return (a.start == b.start + b.size) || (b.start == a.start + a.size); +} + /** * pcpu_block_update - updates a block given a free area * @block: block of interest @@ -629,6 +643,40 @@ static inline bool pcpu_region_overlap(struct pcpu_region a, static void pcpu_block_update(struct pcpu_block_md *block, int start, int end) { struct pcpu_region free = { .start = start, .size = end - start }; + bool overlap_with_contig_hint = + block->contig_hint.size && + (pcpu_region_overlap(block->contig_hint, free) || + pcpu_region_concat(block->contig_hint, free)); + + if (block->scan_hint.size && + (pcpu_region_overlap(block->scan_hint, free) || + pcpu_region_concat(block->scan_hint, free))) { + start = min(start, block->scan_hint.start); + end = max(end, block->scan_hint.start + block->scan_hint.size); + free = (struct pcpu_region){ + .start = start, + .size = end - start, + }; + + block->scan_hint.size = 0; + } + + if (overlap_with_contig_hint) { + start = min(start, block->contig_hint.start); + end = max(end, + block->contig_hint.start + block->contig_hint.size); + free = (struct pcpu_region){ + .start = start, + .size = end - start, + }; + + if (block->scan_hint.size && + free.size > block->scan_hint.size && + block->scan_hint.start > free.start) + block->scan_hint.size = 0; + + block->contig_hint = free; + } block->first_free = min(block->first_free, free.start); if (free.start == 0) @@ -637,23 +685,24 @@ static void pcpu_block_update(struct pcpu_block_md *block, int start, int end) if (free.start + free.size == block->nr_bits) block->right_free = free.size; + if (overlap_with_contig_hint) + return; + + /* + * At this point, it is guaranteed that the new contig does neither + * overlap with contig_hint nor with scan_hint. + */ + if (free.size > block->contig_hint.size) { /* promote the old contig_hint to be the new scan_hint */ if (block->contig_hint.size && free.start > block->contig_hint.start) { - if (block->contig_hint.size > block->scan_hint.size) { + if (block->contig_hint.size > block->scan_hint.size || + free.start < block->scan_hint.start) block->scan_hint = block->contig_hint; - } else if (block->scan_hint.size && - free.start < block->scan_hint.start) { - /* - * The old contig_hint.size == scan_hint.size. - * But, the new contig is larger so hold the - * invariant scan_hint.start < - * contig_hint.start. - */ - block->scan_hint.size = 0; - } - } else { + } else if (!block->contig_hint.size || + (block->scan_hint.size && + free.start < block->scan_hint.start)) { block->scan_hint.size = 0; } block->contig_hint = free; @@ -661,21 +710,41 @@ static void pcpu_block_update(struct pcpu_block_md *block, int start, int end) if (block->contig_hint.start && (!free.start || __ffs(free.start) > __ffs(block->contig_hint.start))) { + if (block->contig_hint.size > block->scan_hint.size) { + if (free.start < block->contig_hint.start) + block->scan_hint = block->contig_hint; + } else if (free.start > block->scan_hint.start) { + /* + * old contig_hint.size == old scan_hint.size + * == new contig size. But, the new contig is + * farther than the old scan_hint so hold the + * invariant scan_hint.start > contig_hint.start + * iff scan_hint.size == contig_hint.size. + */ + block->scan_hint.size = 0; + } + /* new start has a better alignment so use it */ block->contig_hint.start = free.start; - if (block->scan_hint.size && - free.start < block->scan_hint.start && - block->contig_hint.size > block->scan_hint.size) - block->scan_hint.size = 0; - } else if ((block->scan_hint.size && - free.start > block->scan_hint.start) || - block->contig_hint.size > block->scan_hint.size) { - /* - * Knowing new contig size == contig_hint.size, update - * the scan_hint if it is farther than or larger than - * the current scan_hint. - */ - block->scan_hint = free; + } else { + if (block->contig_hint.size > block->scan_hint.size) { + if (free.start < block->contig_hint.start) { + /* + * old scan_hint.size < new contig size + * == old contig_hint.size. But, the new + * contig is before the old contig_hint + * so hold the invariant + * scan_hint.start > contig_hint.start + * iff scan_hint.size == + * contig_hint.size. + */ + block->scan_hint.size = 0; + } else { + block->scan_hint = free; + } + } else if (free.start > block->scan_hint.start) { + block->scan_hint = free; + } } } else { /* -- 2.54.0.545.g6539524ca2-goog