From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BE7E3F0A97 for ; Wed, 6 May 2026 15:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778082085; cv=none; b=H2FcEnz8/HNhvMfbhz+Wd+TmJyErUmG36wHrbROUjRMzDESYRGmC8FUK0KUbooy4pNoo9J5zQJJiw0rP7eIBUkXxlhS1QK034AdeExHW5reUi16ifGvIZ9qTV8YdSofdD5gSGzUHSkUXHoH418IXo7bmQOQ/el9SYYjrotuK4g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778082085; c=relaxed/simple; bh=/V0rZcf9B/8vRzS0t58p9L+TqtLZAmhJt+vmLMMV0Rc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nnWmsyMW1jdSu5JkiMnuQrJXqhuEBwuNa5C80+v1PY4bjlzl5J2NfvvmkCF1z64Ko6EGNnqA+GElC/zGd5vJLR2sVCXNaoQ8ll8TpNyfKy8ZTBTtKwA+2tTW6AJsfP/JZb+EBl5/QCY0Ps/P3uEFwIdtKJIJSPUW5gpICpujT+Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HYRxhnKS; arc=none smtp.client-ip=209.85.208.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HYRxhnKS" Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-3937014be0cso45516001fa.0 for ; Wed, 06 May 2026 08:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778082078; x=1778686878; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wlAad2pyl4+gxQL1nIcAxfpfgfSowpzHoOIZQe3GlmM=; b=HYRxhnKSRkjQVtHQwtLlpGES2zUcGIQiYGWTj/IhyLptKT86AMDoYLkkOXKCSdw1dm ZsTVJF9ovHp1gyWl8tMuN4dC0qeDNa+T8n6RC8v+L7wUrb1EEVYaAWI0ulFmB2x1k7G9 tWBAldEpzpFs8C585eVZV7OUe7F4LI1/UNnTcWxlbAkwZWV+gSDiDn40RBz1HDcNWds4 QYPU0aR05TZF/EHDeXXJ/KnZbSC0dOGjsdJy49CzQ1vrzxKdjy/sGUAEuVfhfcooAzGv k74jb2k0NSE2Ljm1eAJU/eh5EOAkigJ4iD+s/XTnpqCKakFJd9flrCfnXzIs1sSnWvil 6bTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778082078; x=1778686878; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wlAad2pyl4+gxQL1nIcAxfpfgfSowpzHoOIZQe3GlmM=; b=rI5lc3AGdZ2b2zWxEfnil0MN5E+DgWwosAE9agngKslm8TdGaEcbY6EoNnnMAZBfc2 YMoIZy7koG5EZiU8voEfVgeosxuKj7YEZGwCEhxzF0gRUO9u1XgZ7QEBh7HtbR8ZpsG6 hChNyXyfgIugVznMLKTox2qkSa8k4VdkbsSdbbRGjObvdsJhq5igphaJ2V0ve3OmyxJw da0w3CHDNmlBxH8jPV8MZowhn14Jg1GmKKpm1TzYhMy1J0BWBEx1Fsl6YnyijE3/q4LY 2QLjyAhWaxJV6vK/UQdNuEwA/8EBSJq3UB+mnOAlKE7XeBGSrpig+heDu8OJezFehBU2 1uCw== X-Forwarded-Encrypted: i=1; AFNElJ9rRfO0vwcTeq2WqHkTudk0XrssICwZbluyVuJSIQ37CmkvhZj0WbXKdTG0SvE/rLhPfHbVSRdQxSLmG3s=@vger.kernel.org X-Gm-Message-State: AOJu0YwQ0QE8T7o9XEzSO/7LqQy9l0Wg6D1byZNkuNHeagl064oYatHd gLME7g5suX8nNcbxvkRhWRsk/ipnY9qolS/D6bN+PdXUBLB6+ajSWQBMIlSmHKsP X-Gm-Gg: AeBDiettpUSVM6X94WjKccrOPqaTkLo/AztD65KJyXZmue/eeD4ED++QcVDt9d8UO5c AAO3wafVCVwqS7zz65tdvh2a1GIu9lhyZbaFOdO7Yq8dViLmV7kQeZvQN3CtzdDGF4+O4a3ro9h jwY7TedMPGM+liHJ79/x7hH2BsyCBueiuHIL+379NpLIbykg2jumbNdnmwD4nzUltksHrwWe3VT AQmTNAaJY97gWRz80KCUymy8PsqMxUUQBjLNvVNUMM4X3vrHOfV89wfDddSbbvKjN7kJBj6YQ07 9YJHeIh+GxpONUub4PYTn2lkik7bm1gBj5geZrKnsup3dB42vasHuRsvPP6MwgUJMm8A4wulgPd InVGJg/3T7dChXae6VUbEu8QjfGqdZGXWkxQk+ZnKWDqNZCWIfJaGPsRGZuGmJJOq2bqGJotQwQ 2ZKAFHGE3wb2i9Amp5wB8pGAhAqGsMRKC9ELpqw0AntNKJjT8JWYH5pWMSVcbS0QoeffSoOde1c R8= X-Received: by 2002:a05:6512:3f06:b0:5a3:ffc6:6600 with SMTP id 2adb3069b0e04-5a887ce5f9cmr1433469e87.31.1778082077493; Wed, 06 May 2026 08:41:17 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230cfdsm4950379e87.21.2026.05.06.08.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 08:41:17 -0700 (PDT) From: Md Shofiqul Islam To: nm@ti.com, ssantosh@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam Subject: [PATCH v2] soc: ti: knav_qmss_queue: Implement resource cleanup in remove() Date: Wed, 6 May 2026 18:41:14 +0300 Message-ID: <20260506154114.2288-1-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement the TODO in knav_queue_remove() by stopping PDSPs and freeing queue regions and queue ranges before disabling runtime PM, mirroring the cleanup performed in the probe error path. Set device_ready to false before cleanup to prevent any further use of the device during teardown. This ensures resources are released on driver unbind and avoids leaking queue/region state. Suggested-by: Nishanth Menon Signed-off-by: Md Shofiqul Islam --- drivers/soc/ti/knav_qmss_queue.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c index 86d7a9c9ae..a064457878 100644 --- a/drivers/soc/ti/knav_qmss_queue.c +++ b/drivers/soc/ti/knav_qmss_queue.c @@ -1873,7 +1873,12 @@ static int knav_queue_probe(struct platform_device *pdev) static void knav_queue_remove(struct platform_device *pdev) { - /* TODO: Free resources */ + struct knav_device *kdev = platform_get_drvdata(pdev); + + device_ready = false; + knav_queue_stop_pdsps(kdev); + knav_queue_free_regions(kdev); + knav_free_queue_ranges(kdev); pm_runtime_put_sync(&pdev->dev); pm_runtime_disable(&pdev->dev); } -- 2.54.0.windows.1