From: Jakub Kicinski <kuba@kernel.org>
To: "Álvaro Costa" <alvaroc.dev@gmail.com>
Cc: jiri@resnulli.us, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
netdev@vger.kernel.org (open list:DEVLINK),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH] devlink/param: replace deprecated strcpy() with strscpy()
Date: Wed, 6 May 2026 15:42:52 -0700 [thread overview]
Message-ID: <20260506154252.65d673c2@kernel.org> (raw)
In-Reply-To: <20260506211415.16343-1-alvaroc.dev@gmail.com>
On Wed, 6 May 2026 18:14:11 -0300 Álvaro Costa wrote:
> Replace strcpy() call used to extract a string parameter from param_data
> with strscpy(). Since strscpy() already performs bounds checking and
> ensures the destination string is NUL-terminated, remove the string
> length check as well.
The current code validates the netlink attr is nul-terminated.
I'm not sure if your patch retains current behavior.
I am sure, however, that checking whether the change is correct
is a poor use of everyone's time.
Please don't send these sort of patches for networking.
--
pw-bot: reject
next prev parent reply other threads:[~2026-05-06 22:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 21:14 [PATCH] devlink/param: replace deprecated strcpy() with strscpy() Álvaro Costa
2026-05-06 22:42 ` Jakub Kicinski [this message]
2026-05-06 23:52 ` Álvaro Costa
2026-05-07 8:04 ` David Laight
2026-05-07 14:52 ` Jakub Kicinski
2026-05-07 21:10 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506154252.65d673c2@kernel.org \
--to=kuba@kernel.org \
--cc=alvaroc.dev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox