From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7274B8DE4 for ; Wed, 6 May 2026 17:12:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778087541; cv=none; b=Bfeu9KfYI5AQWPXhqf/UrT5kDVqWAo9zIUjd+F1S9ttug/ORuP5F5iXL2fFQiyykcj7gmOj4oAPAPj9r0Ln456T9uqY2Pa/8o83CeTha1dVZjdxY0PJadSHPTE6EHPIRE5V68OJ92kVeu+rn05/WO19Gpia6aG3Jvf2fImdQt/k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778087541; c=relaxed/simple; bh=CjOeIMd7KHhgBlYgalqgDMr3CrElSHV/LHeYqaaaD9g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NA5ZzME6g0zFRFOzdrUFVwjTqTQUa5hwSmniKLjcz1dVEI1XOlRsaLs1w4Ge3zDrdLJMdTfp98s6VsT2cY8gr8vrzgJObSrtzrnE/O5gUnqff7dUNkVxsmkcDHU3C/ICajhB3xRXehoaAWI3tAoeVjc0g99hwFdqNzCakMOnQOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XLE1UR0U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ed0o2ap7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XLE1UR0U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ed0o2ap7" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646EB3VS1436257 for ; Wed, 6 May 2026 17:12:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=zVhhihIWGcW DVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=XLE1UR0U1ox71RUTqMrXdR/MhJg MZKzPeWb2r+lC0pPE4ZqOq88oZnQLzqp6s9N3H/2P3tT20cyBeMNmpx/Zo3BoZi4 1pDscUvTDAvXyvH1oGdFT6q4HgTVjYjJyqyU+RDWRcy3RFrB5yb5R/k3O2trb9mB 4KKzMbOQonKFRZa2RF/rETtnG/hgFhjWfVsAOQ7nGOvTn2Z4zcZJGYD+TEKPUh9b I5UfYvfyJBA2lGYt86QDxdLa7bXpmE50w+bpEsikcWKG2cWmr633WrM7P3w5Y0mE Mj3PrxTqwii/pip22vyUOvl1HrJnym8QWgbc4r46vTi4Xp1XTwlzA4Jymdg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dyuqduetq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 17:12:10 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b2e8bba2e6so78671425ad.1 for ; Wed, 06 May 2026 10:12:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778087530; x=1778692330; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zVhhihIWGcWDVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=Ed0o2ap71oT6FrX8ohOvyJ/aBvAaRvFcJR7qNvZFpX+9QVW5dwYaaL3ZKJhXhzxRkC WncEtx/9y51uHcYTIw0duOr2rrTank3SL+J6W6pENEPBc1wSp3JKuZ29jmB6mV+mS4oN bmP271De0kP51axfgnHJM/E4JVt6wC8JbW7hTqFUeWkiiT38YXMnC8z7h5zYvfnwX/z7 d+PT7uHKQSy/OUgwSkSpscxPyvHgzW5Ue3yERqvDyG8S8Uq+NgBamHP622XWGhD5ks/i e0Iquk8bW0VJuE7kfQ/wc79COe44vjocfZcL9WMw6IFvH/GUGJKh8CapqMP8W1E8rx5e QBrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778087530; x=1778692330; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zVhhihIWGcWDVKhVXioxlxo4w1o6vj94DNJvO2XJTbI=; b=akN4QhR9WXEnhc8x9MrEzSrIOhHsRZRx/a5CrkWGDEFpZkQ7aiNVSEIhoR1WyShp+I scRnu3IkO/G/phAFMWGDNvN28SBWZGrcNj8pGgWrTzeg2SljyeBI2mYvvMqWQqDBE3fz eAtG7+O8azSOY8vYodkk0nTNlXhLTVjlPtDmwepVHsrDbzRcGgydu+G5VfwR+sk2h9sR rM1bldS/3qfFpuujs3gmIpAElo1xF3ZxCElIq6CLNHMVmAlzzw8/w3a+5kkXJixZ+WXf 79vcPMNTsu1GCWiO9z4DzgKf9YHjTu/niZRs685CwXcf4hrPWcSeuekJlU6WQD0Ia1uR B7aQ== X-Forwarded-Encrypted: i=1; AFNElJ/P5h+/Tfys/EB+QilXdlDJuNnimXhlGhv0/zgvQ1sJVdI5UvSrP3V0KoKJBFMqqHm1YTdXEVnNd+sHfuo=@vger.kernel.org X-Gm-Message-State: AOJu0YwHWtUawNh4sEMt5/ZphF24khQywvRaUS1SyFQe49PPSASjiKu7 P3bo9W4QGuXn4KS/xXuoOAATXEuIoPigeEIPbTRRqMSTI34JId8uQYHa/Azwl4IRoSJ8YkVLdu/ hpO233/2oUMz88wFA6biKj/+0tXVFoMAW/mE1zZR24C1i4UxcuUWyRcWQa6QeDMjSOz8= X-Gm-Gg: AeBDiesPFx8yvGzDCnkYPmw73E1X5P7Mda+YgPca51hG+4OIOIp5FdMdtePRBLnwWPM OwjgIMhJF3I06MfijzuFI7huqOT/CJ+NJCnNDKZgCyz+5c8H+EaaaWBkCaKZdyrihuMKqEJpzrb J64x4DHkTgX5HRYQdkPPiPd/VrsQjOnNz0KsY6HyrGUiRJuS9f25Xkpc4jybVrqfTAKJqUUVo9q gJD5u37tDs3dXLFAuN5Yt/rSTrUhwcOV0ljjJnZKsXOX0+RAybXroTP7J4UyNqgUf1YYL59mQiB wW5VrVJ1EBPRMS/DVubPyjbjZ/Pcppw63S1YBezxm+TC6qfebGjn6Pbi5k0cfWXXubmHTe2zkZx m0HG1yUEmIs/srRjqE3Dzi7nK8FjLIIglfGv5B8//3JQ= X-Received: by 2002:a17:903:4304:b0:2b2:6b58:9317 with SMTP id d9443c01a7336-2ba799d6c69mr27041905ad.39.1778087529540; Wed, 06 May 2026 10:12:09 -0700 (PDT) X-Received: by 2002:a17:903:4304:b0:2b2:6b58:9317 with SMTP id d9443c01a7336-2ba799d6c69mr27041615ad.39.1778087528813; Wed, 06 May 2026 10:12:08 -0700 (PDT) Received: from localhost ([2601:1c0:5000:d5c:4ec8:83f5:8254:6891]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7ca105desm32185495ad.55.2026.05.06.10.12.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 10:12:08 -0700 (PDT) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v4 12/16] drm/msm/a8xx: Add perfcntr flush sequence Date: Wed, 6 May 2026 10:10:36 -0700 Message-ID: <20260506171127.133572-13-robin.clark@oss.qualcomm.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506171127.133572-1-robin.clark@oss.qualcomm.com> References: <20260506171127.133572-1-robin.clark@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=W4sIkxWk c=1 sm=1 tr=0 ts=69fb766a cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=W-43u8CF5Pkpiqpb4b0A:9 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDE2OCBTYWx0ZWRfX7r4T2NCimaAU ahen+aFVYaAjJqJ+Xiliadgf+mHBsxjJp7DOw2ZbSGwWlxoCitgnx2USCWNdAsxQd++1QySHNHP +aHr2sS4wMiVFixFMrRS4949N1/MZcKnPVza7WUdA3MgdHPs81ByuMRdUJ0nLdDil036dAVfypU RmRjGwShBGI3RSH9XFL/a1SBubIa4jOCbWhIK5UK+YxVX9fHH+xIbEYFC4ZGWAPDk08dwYZo4r3 aGRW2Zi04WHuXdwXEfbInTqVqXaP4JpaYTEg8L0KPfOWQf0/cjCv8tsbhdabmMLObr0iVEWc/30 6Anhk1Y5Y0nOI9nVHF719s+9wwNY4k95NPuhXLWrEeiMFX68oM0e8T1ErGiHsoIdJIdQQPoX7R5 NAoDNbbkZi9pnwf5WdemvujS+MvFyBbB3sIDrESESAulnn3Vdi0ZfaGjTjQ4GgYbRtj3wkjlwOZ i+wVFLSG7ByFoWQ+skw== X-Proofpoint-ORIG-GUID: KqhQPskKKfshhtDVU0bpgtf38bz9nUp- X-Proofpoint-GUID: KqhQPskKKfshhtDVU0bpgtf38bz9nUp- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 phishscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060168 With the slice architecture, we need to flush the slice and unslice counters to perf RAM before reading counters. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 1 + drivers/gpu/drm/msm/adreno/a6xx_gpu.h | 1 + drivers/gpu/drm/msm/adreno/a8xx_gpu.c | 20 ++++++++++++++++++++ 3 files changed, 22 insertions(+) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index 30df9bfa9ef8..a329d20033d7 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -2921,6 +2921,7 @@ const struct adreno_gpu_funcs a8xx_gpu_funcs = { .progress = a8xx_progress, .sysprof_setup = a6xx_gmu_sysprof_setup, .perfcntr_configure = a6xx_perfcntr_configure, + .perfcntr_flush = a8xx_perfcntr_flush, }, .init = a6xx_gpu_init, .get_timestamp = a8xx_gmu_get_timestamp, diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h index 99c3e55f5ca8..3491a24a9320 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.h +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.h @@ -334,5 +334,6 @@ void a8xx_preempt_hw_init(struct msm_gpu *gpu); void a8xx_preempt_trigger(struct msm_gpu *gpu); void a8xx_preempt_irq(struct msm_gpu *gpu); bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring); +void a8xx_perfcntr_flush(struct msm_gpu *gpu); void a8xx_recover(struct msm_gpu *gpu); #endif /* __A6XX_GPU_H__ */ diff --git a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c index 124d315b2469..6c040f718176 100644 --- a/drivers/gpu/drm/msm/adreno/a8xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a8xx_gpu.c @@ -1345,3 +1345,23 @@ bool a8xx_progress(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { return true; } + +void a8xx_perfcntr_flush(struct msm_gpu *gpu) +{ + u32 val; + + /* + * Flush delta counters (both perf counters and pipe stats) present in + * RBBM_S and RBBM_US to perf RAM logic to get the latest data. + */ + gpu_write(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + gpu_write(gpu, REG_A8XX_RBBM_SLICE_PERFCTR_FLUSH_HOST_CMD, BIT(0)); + + /* Ensure all writes are posted before polling status register */ + wmb(); + + if (gpu_poll_timeout(gpu, REG_A8XX_RBBM_PERFCTR_FLUSH_HOST_STATUS, val, + val & BIT(0), 100, 100 * 1000)) { + dev_err(&gpu->pdev->dev, "Perfcounter flush timed out: status=0x%08x\n", val); + } +} -- 2.54.0