From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B2744BC018 for ; Wed, 6 May 2026 17:27:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778088441; cv=none; b=ooTa4isVSgzLn3VhEnceUikwzj+Kt3ugFBG2ETYYqx8qd0XzlZ2azEJiK3bwpmqKlLHqfL6fE33ha0vtaxXaF3UdCinAbDF4/yxMJ40o6SAi9fGkiYwbbUPI0NkcH9gpVKmUEPGCDbX26SfJ6rOgp29WKM5TudH6AXe3JdF0A1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778088441; c=relaxed/simple; bh=cNsCaAiyMSC71nT8JGaQxRwOoTTxzgq9htUBVnX4oq0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=oPVwrwow4VlbQHisPSOUNLvbECYTBR0OkEcPjcynX/bNJfvsLW0XGOS1Dv4Y4U0I6JNl4k8zoi2oHujb2nHgvfiWgrNvY9kwJmTCD8Zwlj6WBxtypwJQf9G2WU7Wz7+RUZrLOdP1BE+sVbc5QI0sU3tx0d9p0GGlJLJQ+Xq+MPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PQL+NV/e; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PQL+NV/e" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3650453fb28so3262880a91.2 for ; Wed, 06 May 2026 10:27:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778088437; x=1778693237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4PEVltZsn31WcLHjZc3d910sZos9grkTj6lR1cPeZe4=; b=PQL+NV/eIyxwpj975M4bpcI63zxgeLH9gibjTfnBF/PvQhsicHGcvyfju8rTdAxAsZ gtUAX6NzBDCuLjeXRThM3KZVubae3s4H76aoxjxxCOZs5jQD2y+55WrHFeFcwGg7voL1 WTl8qWEWyqMtF1ALWHO1P5rm4XFoXrlu+yVMWeCZuy0QHeb8ZAAJEHh+f3JraS+fkRsf 5q+f2j8uMNlbmuKzPHmD7tOn3nW7IqMQGtBtUmql68xwtGHyrkrujuPiWcaPqY35e9Im eIZDLTrpAJAWqDA0nlR8zE/PseuVGZ6JRSUDooSqSM7B7qJHukDZy2Eew0Q1s287Wy0f p4Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778088437; x=1778693237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4PEVltZsn31WcLHjZc3d910sZos9grkTj6lR1cPeZe4=; b=guGZlC9RgPSOe08E9QsJBJePkJksR8CLVvj+rqi/FVi7UhObFG+b5a3byNycxam08E oJSXcJfPhjRHf7Rq8us1SWzXkfavYfO/4LMlgxwsjH4+ExmcDVFYfs2kgehs3mNUiGfH v+TaOm6gvA8J/ji2EKLPiPmIIKbjN+87qfphkgpy0Kquz+LbMAZOYUJxdaMPxnE2sfm/ kwXz5eiNqNf67+DeWJezRSzBLyXffb96X6bg9KMiuVJbj6FS5t+i1pO7qi2pt4p0Sa3w tY48JUtN69wo2cL0xZVapdvY9meTltinahCj60z46TjC/K1KXTfoAMrCQKp6S2QpbgL3 es9Q== X-Forwarded-Encrypted: i=1; AFNElJ94bqVG+e+HmdjVpb1ISIvwMFplmn8MRdTrnK/WGNFuv2lr8586DQGa3H5tpTerw+GuQMBYa3rkfAwy31Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwyU7btEoOv3UDfGjRHfuRHjxMNfSKUw2P/2qCicz+q1vgUhKmA CiyxTgi87v9rna/TUxKGJx0QpvfODNtvCrXNBoxnEjGU7xGrA1ZVrs2E X-Gm-Gg: AeBDievcZDR+3zUV0UaMcHZqoMfb12FdjgaQ/xhiMdbviN5fvBvhWuJmaEupvZrnEkw fnSfXtsemBmHspim2WMYKJJhDG0owhRAP7u2fbxDBjZD5vgft1vOXYCTz+eo8tl/QMJhlHIanw+ kkcNEcUdZDTCQHh8VpIbKbo2iMj7dAaw7cwYT2VDnLVMhbdCX2foDljCYdOqty8JqLBzsVdFoPA lnrlqTVE2uKN8cZY4OqFbszaA780K93CMtdisYAamtUVm9AyHKMTZeloGZ1I/VDGHN77uaqACus lVqwnABtzsQeKdZcS+xKztRV+IRDJ2YGY8oTw4+gvYA6rMMj8PFTgpiiV+AiE5HgONRgKJu6YKj NZy/UVEZxlfBpbY5GyExfufGm+FsK1kwxlxxfFeXuZm6sS8CnqZNUtIS+tvcsQKhAsKTuHeZybB 5oWpj58bh2zj2kN6pWi+r3t1f3I2/03Eg4izO9Xw+Pwt8XBasNEEtTq60GjKYRUIXCXhlz3ZEU4 caBJCtMADX+Q3Q= X-Received: by 2002:a17:903:13ce:b0:2b9:fc68:d8bc with SMTP id d9443c01a7336-2ba7881ba37mr47008655ad.0.1778088436995; Wed, 06 May 2026 10:27:16 -0700 (PDT) Received: from arch.lan ([2409:40e1:300a:7d12:5c:b984:20b1:5a8e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7ca244dasm28828955ad.72.2026.05.06.10.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 10:27:16 -0700 (PDT) From: Aadarsh Chandra To: razor@blackwall.org, idosch@nvidia.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, bridge@lists.linux.dev, linux-kernel@vger.kernel.org, Aadarsh Chandra Subject: [PATCH net-next v3] net: bridge: replace simple_strtoul with kstrtoul Date: Wed, 6 May 2026 22:54:47 +0530 Message-ID: <20260506172447.9770-1-aadarsh.official.xz@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The simple_strtoul() function is deprecated. It does not handle errors or overflows correctly. Replace it with kstrtoul() in brport_store() to ensure that invalid user input is caught and returned as an error. Acked-by: Nikolay Aleksandrov Signed-off-by: Aadarsh Chandra --- v3: move change log below the line and add Acked-by. v2: target net-next and simplify by reusing the ret variable as suggested by Nikolay Aleksandrov. net/bridge/br_sysfs_if.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c index 1f57c36a7fc0..cdecc7d1260c 100644 --- a/net/bridge/br_sysfs_if.c +++ b/net/bridge/br_sysfs_if.c @@ -318,7 +318,6 @@ static ssize_t brport_store(struct kobject *kobj, struct net_bridge_port *p = kobj_to_brport(kobj); ssize_t ret = -EINVAL; unsigned long val; - char *endp; if (!ns_capable(dev_net(p->dev)->user_ns, CAP_NET_ADMIN)) return -EPERM; @@ -339,8 +338,8 @@ static ssize_t brport_store(struct kobject *kobj, spin_unlock_bh(&p->br->lock); kfree(buf_copy); } else if (brport_attr->store) { - val = simple_strtoul(buf, &endp, 0); - if (endp == buf) + ret = kstrtoul(buf, 0, &val); + if (ret) goto out_unlock; spin_lock_bh(&p->br->lock); ret = brport_attr->store(p, val); -- 2.54.0