From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Alencar <455.rodrigo.alencar@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
rodrigo.alencar@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@suse.de>,
Michael Auchter <michael.auchter@ni.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH v6 00/12] Fixes and cleanups for the AD5686 IIO driver
Date: Wed, 6 May 2026 18:29:12 +0100 [thread overview]
Message-ID: <20260506182912.12eafac4@jic23-huawei> (raw)
In-Reply-To: <egslrxgxzuj2rqsrjwo6xyjygnuwqqaqz7twkyetxtrhve2gfd@unmzoontm6kr>
On Tue, 5 May 2026 15:29:55 +0100
Rodrigo Alencar <455.rodrigo.alencar@gmail.com> wrote:
> On 26/05/05 03:59PM, Andy Shevchenko wrote:
> > On Tue, May 05, 2026 at 01:35:01PM +0100, Rodrigo Alencar via B4 Relay wrote:
> > > This is the first series of three on updating the AD5686 driver.
> > >
> > > A bigger patch series was sent before ("Extend device support for AD5686 driver"):
> > >
> > > https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com
> > >
> > > This one adds a number of cleanups and fixes, like:
> > > - Refactor include headers (IWYU);
> > > - Remove redundant register definition;
> > > - Drop enum chip id in favor of per-device chip_info structs;
> > > - Fix internal voltage reference control for single-channel devices;
> > > - Acquire lock when doing power down control;
> > > - Fix powerdown control for dual-channel devices;
> >
> > > ---
> > > Changes in v6:
> > > - Protect powerdown masks on read access too.
> > > - Minor changes to power down handling and constants.
> >
> > You were too fast, Jonathan applied some patches already.
>
> I understood He had applied the some of the fixes and was to wait on the fix
> for the lockless read access issue to proceed. Also, most of the series have
> been reviewed already. Indeed, I suppose I've been hurrying up things... will
> slow down!
>
If you do a new version (I didn't have any other comments to add
on the remaining patches) then please just drop the fixes I've applied
off the start and note that the series is dependent on the tag in the
fixes-togreg branch. No idea if sashiko will cope with that but humans will ;)
prev parent reply other threads:[~2026-05-06 17:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 12:35 [PATCH v6 00/12] Fixes and cleanups for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 01/12] iio: dac: ad5686: fix ref bit initialization for single-channel parts Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 02/12] iio: dac: ad5686: fix input raw value check Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 03/12] iio: dac: ad5686: acquire lock when doing powerdown control Rodrigo Alencar via B4 Relay
2026-05-05 12:58 ` Andy Shevchenko
2026-05-05 14:06 ` Rodrigo Alencar
2026-05-05 15:21 ` Andy Shevchenko
2026-05-06 17:20 ` Jonathan Cameron
2026-05-05 12:35 ` [PATCH v6 04/12] iio: dac: ad5686: fix powerdown control on dual-channel devices Rodrigo Alencar via B4 Relay
2026-05-06 17:22 ` Jonathan Cameron
2026-05-05 12:35 ` [PATCH v6 05/12] iio: dac: ad5686: refactor include headers Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 06/12] iio: dac: ad5686: remove redundant register definition Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 07/12] iio: dac: ad5686: drop enum id Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 08/12] iio: dac: ad5686: add of_match table to the spi driver Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 09/12] iio: dac: ad5686: add helpers to handle powerdown masks Rodrigo Alencar via B4 Relay
2026-05-05 13:17 ` Andy Shevchenko
2026-05-05 14:13 ` Rodrigo Alencar
2026-05-05 15:27 ` Andy Shevchenko
2026-05-05 15:50 ` Rodrigo Alencar
2026-05-05 16:31 ` Rodrigo Alencar
2026-05-05 12:35 ` [PATCH v6 10/12] iio: dac: ad5686: add control_sync() for single-channel devices Rodrigo Alencar via B4 Relay
2026-05-06 14:22 ` Rodrigo Alencar
2026-05-05 12:35 ` [PATCH v6 11/12] iio: dac: ad5686: cleanup doc header of local structs Rodrigo Alencar via B4 Relay
2026-05-05 12:35 ` [PATCH v6 12/12] iio: dac: ad5686: create bus ops struct Rodrigo Alencar via B4 Relay
2026-05-05 12:59 ` [PATCH v6 00/12] Fixes and cleanups for the AD5686 IIO driver Andy Shevchenko
2026-05-05 14:29 ` Rodrigo Alencar
2026-05-06 17:29 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506182912.12eafac4@jic23-huawei \
--to=jic23@kernel.org \
--cc=455.rodrigo.alencar@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=rodrigo.alencar@analog.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox