From: Bjorn Helgaas <helgaas@kernel.org>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>,
Matthew W Carlis <mattc@purestorage.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"ALOK TIWARI" <alok.a.tiwari@oracle.com>,
ashishk@purestorage.com, msaggi@purestorage.com,
sconnor@purestorage.com, "Lukas Wunner" <lukas@wunner.de>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
Jiwei <jiwei.sun.bj@qq.com>,
guojinhui.liam@bytedance.com, ahuang12@lenovo.com,
sunjw10@lenovo.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] PCI: Always lift 2.5GT/s restriction in PCIe failed link retraining
Date: Wed, 6 May 2026 17:30:27 -0500 [thread overview]
Message-ID: <20260506223027.GA890441@bhelgaas> (raw)
In-Reply-To: <alpine.DEB.2.21.2512072345220.49654@angie.orcam.me.uk>
[cc->to: Matthew]
On Mon, Dec 08, 2025 at 07:24:23PM +0000, Maciej W. Rozycki wrote:
> Hi,
>
> I've figured out that backporting will be less intrusive if an update to
> use `->supported_speeds' is posted as a separate follow-up change. So it
> is now 2/3 in this series, after 1/3 comprising the original patch, only
> trivially updated. Then 3/3 moves the maximum link speed determination
> earlier on for an early exit in the PCIE_SPEED_2_5GT case; maybe unlikely,
> but essentially free now, now that we retrieve the speed anyway, and makes
> code a little simpler yet.
>
> Please let me know if you'd prefer me to fold 2/3 into 1/3 after all.
>
> Previous iterations:
>
> - v1 at: <https://lore.kernel.org/r/alpine.DEB.2.21.2511290245460.36486@angie.orcam.me.uk/>.
Applied to pci/enumeration for v7.2, thanks!
Matthew, I know you saw issues with some NVMe devices [1], but I'm not
clear on whether you've tested any of those devices with this series.
If you have a chance to test the series, it would be great to know
whether it helps.
[1] https://lore.kernel.org/all/20250702052430.13716-2-mattc@purestorage.com/
parent reply other threads:[~2026-05-06 22:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.DEB.2.21.2512072345220.49654@angie.orcam.me.uk>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506223027.GA890441@bhelgaas \
--to=helgaas@kernel.org \
--cc=ahuang12@lenovo.com \
--cc=alok.a.tiwari@oracle.com \
--cc=ashishk@purestorage.com \
--cc=bhelgaas@google.com \
--cc=guojinhui.liam@bytedance.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jiwei.sun.bj@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=macro@orcam.me.uk \
--cc=mattc@purestorage.com \
--cc=msaggi@purestorage.com \
--cc=sconnor@purestorage.com \
--cc=sunjw10@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox