From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2F73D4100 for ; Wed, 6 May 2026 23:38:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110735; cv=none; b=PuFprFCgpYKsFINaesWFI/SYp9RKGDPFZ5XWi1HKuFY0HNVdwdormfiLMt3k4dNwunn7tK3AEkp5EybBmNp0BolI3HZV0HJMbgLmIsUZg4mwTrKqI4ZliPg87UiUN66uUt/F9c6Vz+McmegB8PO51ilAq6IqsT2ppGrHU1dlj2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110735; c=relaxed/simple; bh=JXP8l6SZOlYJ3RZ86oWzg8ag9M+Lc2vnpFBpDW52rRs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FF5W6IXHLdfqJz/0VjPmTpwAlBHxfjCfm6ZH/w/tsbXHubJNzYYX4h4G9ofaFoJg4WVvw4m+mj1eFo5AH4JzWvt6Xx2KfOMq+xJ7VKwf0OhPDVXFHtgaCefvTg7ZrvayfZI+6fW4hU75JiyyWhHiYhrqze1/0r4X+5FE6WT6UkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GAlYNfXx; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GAlYNfXx" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2b4583f0a1aso1256665ad.3 for ; Wed, 06 May 2026 16:38:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778110734; x=1778715534; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o3IG9Yp6Pjl+c9PKNtEae4TwSgGvYdWevGerwBQ6zPI=; b=GAlYNfXxTc9ptgfxgIe24oLzxnmYXnuS98ptuX6JSalg3PKzHrcLRe1srpSZ9erwbW n1QUQmwwqPaazKar0/z8r/kJsXiQefJFZfteRC1jEz+oD4uRw8GI7es7PeWFP3EzEs8E V+FYEEd168rRrmN6NLTNx93tbUK9DOfO3fMVVEkPeateB0IGSvgaosWXjORsjCzLWncJ 9nFfejVz7JXNljQr0DooB7+MAwSywK1k+pqVIfAAXta/5kKAwDsdgkUI0ESM8CfrU6jH u+9IMZ9nmpLgE78ihsVPYe0ntkWuxD44JcrV+OTu4TGTVem90JUH990UlyAsn0uA5e0m uDxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778110734; x=1778715534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=o3IG9Yp6Pjl+c9PKNtEae4TwSgGvYdWevGerwBQ6zPI=; b=KR7oTN4yirATliI00ejL68BhPBHyrBjJ/H9HD5bxTuA+OqKqTS3WRjno1WNAstw2Y8 nl7ipkjMv9fvs+GgvWBgux7D9YjUt8s+aB5cQ/tS4/diae0ShxwHg3Tos0mfs8hXtiEx iPIsW3XGGbqAmvMx0VLH31yxXHSZ90pVcXBPeYg63yg10eIA6JVQ0F5kkPkBHB+hfFlG 713T0jjae77dVhhs9zVZEXENaQwtC82NjfBeT3fMColMT1/mgul3ToawNQSn4djCtcds s46tiu76MluJi1h2IXYMdobvWd4bYnffpFOfUk78UBw2eXpN3GROoYpPfrWe2bv9sfbl wj4A== X-Forwarded-Encrypted: i=1; AFNElJ9dEVFz4KJL0/tYOKCQDYJ1S/33U7zVqE4Fu7bCkBPwWKeHc18mjs+N2QVTZqOptFd21G+K8EXhk77A22A=@vger.kernel.org X-Gm-Message-State: AOJu0YxyoCG5Rlien7lF7/Y62332/eUE42/qh81eeUJ+tLMMgv+R4XGt oSzPDFVVDg+kMS332rizMEh6RJY2El/0Zp7vDoQ0/RKAeER0j8QHqC28 X-Gm-Gg: AeBDietWPQUGJB5/5yhcmH2xD1ox0NjF7Ajrqw9sLAZ7RLOHDfWCIuXxBKhyoi8MBHC Q3Pt0FENJVcXp44dRFNXu8bykCChmexTZ5jRYwYmMweKshgYomFIdexEHc1Ubk4e0dcF3xSE6sN USQ8e2PN44jJ/jeEls061Y3ufcMsdkGfbFZR5jJauyUd4JRwdulyxZhtbPeRpt8k5emq2dzXFsz Mx6RcVHgSQ5G01wh9xCZ9L2n8k3o4Dgx0fc0JRBg+mdWr9OZPaHEKBqoTsXDSBB85u/hADbfHMC xD+eOItBxcvanX00eY9EsfM8GnLpxtHp3jJTnz0nrU7dqVu9ZCUey4lrccc63t3RC3FIcU38O5L LOJVtDELwxRKkPzoafORvLpO/sMwKdZj0O9pOy6TXuLYJVHuZpitIZ1+rA2kU6RFBVDFMm2C5Xw WQEablUWKPn7djZ6qjabYwez+Nfw2vZLmJGJZavqqMnZZRFiokjHhA4vd9QhrdHa+WzfYehMNCk yvb/jaq2UEBIcEbu55XaPBClzR8clzcRz5mCMMW5hVi49dVRfdpGX0X X-Received: by 2002:a17:902:f650:b0:2b2:5258:a23d with SMTP id d9443c01a7336-2ba78f54b3dmr54071995ad.14.1778110734082; Wed, 06 May 2026 16:38:54 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babaaef08bsm3471805ad.28.2026.05.06.16.38.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 16:38:53 -0700 (PDT) From: Rosen Penev To: linux-clk@vger.kernel.org Cc: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Brian Masney , Kees Cook , "Gustavo A. R. Silva" , linux-samsung-soc@vger.kernel.org (open list:SAMSUNG SOC CLOCK DRIVERS), linux-kernel@vger.kernel.org (open list), linux-hardening@vger.kernel.org (open list:KERNEL HARDENING (not covered by other areas):Keyword:\b__counted_by(_le|_be)?\b) Subject: [PATCHv2 2/3] clk: samsung: cpu: use kzalloc_flex Date: Wed, 6 May 2026 16:38:32 -0700 Message-ID: <20260506233833.178357-3-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260506233833.178357-1-rosenp@gmail.com> References: <20260506233833.178357-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use a flexible array member to combine allocations. As kmemdup_array is really kcalloc + memcpy and kzalloc_flex kzalloc + kcalloc, kzalloc and kcalloc combine leaving the memcpy. Add __counted_by for extra runtime analysis. Remove fake const num_cfgs. It needs to be assigned for __counted_by to work. Signed-off-by: Rosen Penev --- drivers/clk/samsung/clk-cpu.c | 34 ++++++++++++++-------------------- 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/drivers/clk/samsung/clk-cpu.c b/drivers/clk/samsung/clk-cpu.c index ffc33e5decf5..37cf47533dc6 100644 --- a/drivers/clk/samsung/clk-cpu.c +++ b/drivers/clk/samsung/clk-cpu.c @@ -101,11 +101,11 @@ struct exynos_cpuclk { const struct clk_hw *alt_parent; void __iomem *base; spinlock_t *lock; - const struct exynos_cpuclk_cfg_data *cfg; - const unsigned long num_cfgs; + unsigned long num_cfgs; struct notifier_block clk_nb; unsigned long flags; const struct exynos_cpuclk_chip *chip; + struct exynos_cpuclk_cfg_data cfg[] __counted_by(num_cfgs); }; /* ---- Common code --------------------------------------------------------- */ @@ -660,10 +660,6 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx, return -EINVAL; } - cpuclk = kzalloc_obj(*cpuclk); - if (!cpuclk) - return -ENOMEM; - parent_name = clk_hw_get_name(parent); init.name = clk_data->name; @@ -672,6 +668,17 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx, init.num_parents = 1; init.ops = &exynos_cpuclk_clk_ops; + /* Find count of configuration rates in cfg */ + for (num_cfgs = 0; clk_data->cfg[num_cfgs].prate != 0; ) + num_cfgs++; + + cpuclk = kzalloc_flex(*cpuclk, cfg, num_cfgs); + if (!cpuclk) + return -ENOMEM; + + cpuclk->num_cfgs = num_cfgs; + + memcpy(cpuclk->cfg, clk_data->cfg, num_cfgs * sizeof(*cpuclk->cfg)); cpuclk->alt_parent = alt_parent; cpuclk->hw.init = &init; cpuclk->base = ctx->reg_base + clk_data->offset; @@ -687,29 +694,16 @@ static int __init exynos_register_cpu_clock(struct samsung_clk_provider *ctx, goto free_cpuclk; } - /* Find count of configuration rates in cfg */ - for (num_cfgs = 0; clk_data->cfg[num_cfgs].prate != 0; ) - num_cfgs++; - - cpuclk->cfg = kmemdup_array(clk_data->cfg, num_cfgs, sizeof(*cpuclk->cfg), - GFP_KERNEL); - if (!cpuclk->cfg) { - ret = -ENOMEM; - goto unregister_clk_nb; - } - ret = clk_hw_register(NULL, &cpuclk->hw); if (ret) { pr_err("%s: could not register cpuclk %s\n", __func__, clk_data->name); - goto free_cpuclk_data; + goto unregister_clk_nb; } samsung_clk_add_lookup(ctx, &cpuclk->hw, clk_data->id); return 0; -free_cpuclk_data: - kfree(cpuclk->cfg); unregister_clk_nb: clk_notifier_unregister(parent->clk, &cpuclk->clk_nb); free_cpuclk: -- 2.54.0