public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: gregkh <gregkh@linuxfoundation.org>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: linux-staging <linux-staging@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true
Date: Wed, 6 May 2026 09:14:13 +0200	[thread overview]
Message-ID: <2026050625-counting-paprika-7198@gregkh> (raw)
In-Reply-To: <19dfbf2f695.283866a26574.4001086986822756666@zohomail.in>

On Wed, May 06, 2026 at 11:51:37AM +0530, Ashwin Gundarapu wrote:
> On Wed, May 06, 2026 at 10:33:02AM +0530, Ashwin Gundarapu wrote:
> > Remove explicit comparison to true in check_fwstate() call and
> > add spacing around the bitwise OR operator to improve code style.
> >
> > Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> > ---
> > v3: Fixed double --- line and corrected whitespace formatting as
> > requested by Greg KH.
> 
> Changes from v1:
> - v2: Resent with corrected whitespace via Thunderbird plain text mode
> - v3: Fixed double --- line and corrected whitespace formatting
> 
> The original v1 was sent from Gmail web client which corrupted tabs
> to spaces. v2 attempted Thunderbird plain text. v3 fixes the double
> --- separator and uses Zoho webmail plain text which preserved tabs.

This all needs to go below the --- line.

Please add it to v4 when you resend that in a day or so.

Also realize you did not run your patch through checkpatch to verify
that you did not add any issues with your change :(

thanks,

greg k-h

      reply	other threads:[~2026-05-06  7:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  5:03 [PATCH v3] staging: rtl8723bs: remove unnecessary comparison to true Ashwin Gundarapu
2026-05-06  5:10 ` gregkh
     [not found]   ` <85d6c003-500f-41a6-a9e1-ad83a586d694@zohomail.in>
     [not found]     ` <2026050626-blinked-armadillo-c405@gregkh>
2026-05-06  6:21       ` Ashwin Gundarapu
2026-05-06  7:14         ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026050625-counting-paprika-7198@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linuxuser509@zohomail.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox