From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: David Cardenas <ldcc@proton.me>
Cc: "linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: fix open parenthesis at end of line
Date: Wed, 6 May 2026 07:01:04 +0200 [thread overview]
Message-ID: <2026050635-gravitate-sprinkled-575f@gregkh> (raw)
In-Reply-To: <OorLKjBEmwLMB-OuQC_MerB0GkYg2fsHmJcvxPmc8EFrk7VuBlisVIa90K86InsIr2MjgjoSceOv_PUY0OfsepmQ42JdZIoSvK0pMggDfYI=@proton.me>
On Wed, May 06, 2026 at 02:26:02AM +0000, David Cardenas wrote:
> Function declarations and conditional statements should not end
> with an opening parenthesis. Reformat affected functions and
> if statements to place the opening condition or first parameter
> on the same line as the function name or keyword
>
> Signed-off-by: David <ldcc@proton.me>
> ---
> .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 179 +++++++-----------
> 1 file changed, 64 insertions(+), 115 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> index 6ab65e9e8..59b8f7e99 100644
> --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c
> @@ -30,6 +30,7 @@ static u8 DeltaSwingTableIdx_2GA_N_8188E[] = {
> 0, 0, 0, 2, 2, 3, 3, 4, 4, 4, 4, 5, 5, 6, 6,
> 7, 7, 7, 7, 8, 8, 9, 9, 10, 10, 10, 11, 11, 11, 11
> };
> +
This change is not described in your changelog :(
Also, the From: line does not match your Signed-off-by: line.
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-06 5:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 2:26 [PATCH] staging: rtl8723bs: fix open parenthesis at end of line David Cardenas
2026-05-06 5:01 ` gregkh [this message]
[not found] ` <1XxaPkNOP-p-F8PW1lsqdkdN9K2o6TS3kphmVpxm6gXIMn9Ygk7UPsiOosb9eybCDX_1lCU4PwdUKlPmFdTuAhAAg_aS65tADEe2YeAisek=@proton.me>
2026-05-08 2:48 ` [PATCH v2] " David Cardenas
2026-05-08 5:25 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026050635-gravitate-sprinkled-575f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ldcc@proton.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox