Re: [PATCH v3] mshv: Simplify GPA map/unmap hypercall helpers

[Anirudh Rayabharam <anirudh@anirudhrb.com>]

On Tue, May 05, 2026 at 08:00:42AM -0700, Stanislav Kinsburskii wrote:
> On Tue, May 05, 2026 at 06:13:01AM +0000, Anirudh Rayabharam wrote:
> > On Thu, Apr 30, 2026 at 02:52:17PM +0000, Stanislav Kinsburskii wrote:
> > > Clean up hv_do_map_gpa_hcall() and hv_call_unmap_gpa_pages() after the
> > > preceding bug-fix patches:
> > > 
> > > Move "done += completed" before the status checks so that pages mapped
> > > by a partially-successful batch are included in the error cleanup unmap.
> > > Previously these mappings were leaked on failure.
> > > 
> > > While here, improve type safety and readability:
> > >  - Change "int done" to "u64 done" to match the u64 page_count it is
> > >    compared against, avoiding signed/unsigned comparison hazards.
> > >  - Use u64 for loop iteration and batch size variables consistently.
> > >  - Add proper braces to the for-loop body in hv_do_map_gpa_hcall().
> > >  - Remove unnecessary "ret" variable from hv_call_unmap_gpa_pages().
> > >  - Simplify the error-path unmap to use "done << large_shift" directly
> > >    instead of mutating done in place.
> > > 
> > > v3: aligned changes by 80 colons
> > > v2: replaced min with min_t
> > 
> > This part describing the changes in various version should be placed
> > after the "---" line below. This way it won't appear in the final commit
> > log.
> > 
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#commentary
> 
> Thanks for the geidance, will do next time.
> 
> Thanks,
> Stanislav

Wei might fix this while committing or maybe ask you send another
version. But either way:

Reviewed-by: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>