From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C1E52571B8 for ; Thu, 7 May 2026 01:10:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778116257; cv=none; b=X7DpsdGuCbLkH0PnmPEKOot6shSjikaCnp/gJHQMbqpCpaEsbn0uPHoe7e8sZbVuvCtHKeeqeu4zjxqHDzvpc4ckyMl0yz8+178H3NMR7CrI+qv+Jlx6TzfJTw5Oad9R+7xd6qT1ZlTf3dk55uF7z79n7wAuE5boQCjjsTlDUgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778116257; c=relaxed/simple; bh=vCjp6Otef/xE5vbuvwNoduQVTq2eHsexFqb6kzgabfE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=BT6KH41mFhgNkuf57ucZSa3WTGZJ/M7SuoFwWpFhDKfqxXcQPKu0ewlorkt8jmybc+sZK9XNc7WzBi0aVgy4rmcgW1aoidVb3w+fZk429KMprCPo4NelpPD1V4irr5H9YFFT5no/hDDFZiU3eGkf1VENGn8WvtqupQIo+7hTM0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=A9f0awT8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XjR+smxF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="A9f0awT8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XjR+smxF" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646KHWAE1514824 for ; Thu, 7 May 2026 01:10:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JXzLPzKJmMMfBleWuh+IFIAqE4Ffe4ls9p1aUztqIUU=; b=A9f0awT8VJX4k5QM m3yUA5bje7Z9ipB2kjAFeiwwxBKosM+JNHQRl25xxZChnjoxbj+NjHo82IcbaSXE i/o+osF4pBMLrXeisAlb+8RM9QpR4bKC8LROYSSOSB3FMlqyHzSogVjIt+7T6ySv NndNk1aI2WXjbtsUtdqQi0W8QY6Jr4d/v6qB+4B68SpkqMNU/erGi6YFICpjKHZR ImWFX9uBaLOnMZaD2M93siZ8xE9iON5fraBkBJIVYNDrMNhLnjY84+JyssJ48M5o UneUqTOfWfghuonXRJwa8MNgdfQ3WKU9XBkg9M0HBGJ3hJdgfBtjyPtmUNIQ6OXr m9/52Q== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e00v1uugj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 07 May 2026 01:10:54 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8d6061bd722so69042085a.3 for ; Wed, 06 May 2026 18:10:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778116253; x=1778721053; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JXzLPzKJmMMfBleWuh+IFIAqE4Ffe4ls9p1aUztqIUU=; b=XjR+smxFOxiEg0VM4Eeb8zzs7runA5oMdDrgSvstoH0T3ZT9DUAtkzQPEyr39oKslm q+PgHdQ64nhk02kwsLTaZFMe14/ukRclQACeaOQ1j0LT78fGLTQBhsRsQras+siJj9mU BEGJYbWJXDsIEyA51cmvHJqUQSB8AeqwwnXPxXiru4yLMQBZBN32ysHl7toZ3fQMRt+K PxBtyrZVrDMKJqugms16tGqkGYm/yClmcAe7tc2Rp3PdbjTT2iTsKshrxeE25KwAQSE9 oN14pQPztzAzulAnyh4qiHRvrL3S1cBgDnJB9je//8ZgdOw2Pbd013aLpkqlkkGhxOZN 211w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778116253; x=1778721053; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=JXzLPzKJmMMfBleWuh+IFIAqE4Ffe4ls9p1aUztqIUU=; b=XEKWQO6aRA2Wd5qsJjKBSplKXCbuMXturZXUYON5yaZR6ZRr2RTvt2Cnt4HhTlbfWs pumrjFXQZZ06+X/Jzv1yYTmni6vGnzKE0roR0qYZZzrpuLNf1vJbhE5quablMYo81JJ0 VBM0PVooy1GCRW9JybIjpE+MyjiqcxnbIAkSzlt6AgZJRcV6WcrCaWkj1C9ehtWLKFq4 U5bVSni9FA5MIuCfmF5PB3MpJvq5BDBfXSEXZ8bwtLkngI+CEk68kMNv793pgnw+HTf4 D3xepLPqUA06SIWXct/g1zTSY9Ms0HNexAs6xpoaBfAEKFOF4w6GdCmhT0vRJb39toe6 ehNQ== X-Forwarded-Encrypted: i=1; AFNElJ8HwBG9TpqTrrarRY/C10gtbrKH2zM0WrzLxPPm+VMgeyfHICqJUVL9n8n+UomYDZ9L8RfGukzsBeT6l8c=@vger.kernel.org X-Gm-Message-State: AOJu0Yx800FpjfXHL+e4D51rlYYTsam4ZK77R1bZ1GpmqYIR+NIB4njS 2rhXHp7qRJZRL9NQ5izoqyF68HzlyQmq/MSs8CYziYWVe2C96fJho39cyi6lFnaIo4fjEFy+V1/ RNgPIZh5rmxTFIWmI1hpH0MNfFCFfb1fUtjTX6Io72Eu5W9Ud3Hezo3ywb0su0pfCTfM= X-Gm-Gg: AeBDietWfW3D8ja/st8cS+mWKBpfcnGBB2iYZZnV7buDOP7GD4BjD+tQrc7z4lqjTsz wi7cfzI5pll+jk5aCjHst3N5gir+reQPiOHkZP/Rd8VtQI6LBaRbkrpKcY/72iufNXMc1xyyBba M1tDWjSCEsbRzbkmdbq8lY21U7wlOnecQf8Ih1ctkH39e38RtuCcCLTbNRcEtzcuwq+owi16Y9z CA75TMJItxVQvY48dLKlOBuxYYtpl9Z9PXJnOPMoJWluEODryNDCQbONHlqYSAluRlbv01Axe3j jFkexVXowaadw3IMf9ao9MEj9HmCFbGsGyTyLaeYs6Gqlq9u8WqIjoeVADc+0zyCiMxlysYHow3 WQ0PBBmIirUnm7uIqozhfLItuOpdrQXEPnUWIllhE4hGhxGoNrZgg+q+kWkkrtOLXyqEG1JAQM/ onVlvSJUs3i0dubTJ+wXbMUq0yi6/HAm2GeOZDFTag09aVFw== X-Received: by 2002:a05:620a:4455:b0:8cd:c0b6:87f7 with SMTP id af79cd13be357-904d68db2bdmr902366785a.46.1778116253356; Wed, 06 May 2026 18:10:53 -0700 (PDT) X-Received: by 2002:a05:620a:4455:b0:8cd:c0b6:87f7 with SMTP id af79cd13be357-904d68db2bdmr902362885a.46.1778116252824; Wed, 06 May 2026 18:10:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c230e00sm5221967e87.29.2026.05.06.18.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 18:10:51 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 07 May 2026 04:10:41 +0300 Subject: [PATCH v5 2/7] media: iris: don't specify min_acc_length in the source code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260507-iris-ubwc-v5-2-e9a3aee53c49@oss.qualcomm.com> References: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> In-Reply-To: <20260507-iris-ubwc-v5-0-e9a3aee53c49@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue , Wangao Wang X-Mailer: b4 0.15.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=3117; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=vCjp6Otef/xE5vbuvwNoduQVTq2eHsexFqb6kzgabfE=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBp++aUwStBP0KISULKId+sYvvMoEbkTcp0zpSJy 8v4NGsGDxCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCafvmlAAKCRCLPIo+Aiko 1Z/dB/46Ju/VYuPxTbeC2ZusqZ6QR4CkkUQN6vmmN9PRqyP7wbEiYIg0LHqvd5X1nnnLioUcxFE VcdyLvSlozvh9PxrG2EcozCgAlQS/asjo7ICWmmhOuJn0lfuwCHMZZTHvkaEf0eSPchuQVvnpv3 lubrzIMV9yLsXTM3TQ4HOCv2R327Yx4TdgRKQs3TS47s3krjFLIorw/VcLHN10qPW+kb8jLoEQd xFf6oPs+J40B/Lhsv13fwq0gTSOjh9KB4IztHJdIf0VGh0YIIdaPe3dmYlvq1IIniBKypwCX3Hl g+99CYfaA1EKr8fHJnPwoE3KdWJGnjW4TxK4Uu7+9Cb/Eq0f X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: HYR-mwSUYeIvVSIhI22zr3SngW7cRm4t X-Proofpoint-GUID: HYR-mwSUYeIvVSIhI22zr3SngW7cRm4t X-Authority-Analysis: v=2.4 cv=cKXQdFeN c=1 sm=1 tr=0 ts=69fbe69e cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=qS6nuPEoivtXufaKKhMA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA3MDAwOSBTYWx0ZWRfX3e1LRU7dTbUp SwuYQPyicv7ZAZ7nz8ROiQgIbm2c9gObL7CfbUue3Nrc2Y2lEr+Wb1r6BDseJl/Wcfe7aQ4geeS 6Bom4Ce1QKt+VYp4/uV9oiwNg0v/ZG8ZGcmvd/6RiM4fq7sPT1c7DW2oJyEwhXGzNOiYrGw5pnW J2xpplKw4fW83ejff7wNPs/CK1wL/VQcllU+eIWz2XrDkjh51MAWV1xjy38tQ5/sv2u6EbLqc6n 0ZAwtI95PGzy8IGGIIuN1yAVXcn/f+9LXWhebFhVVH2DLm2cc270KMcsyvMW+PMLnM/pP5yYx1S mIv6p99CSWrMpuo58TVN1gAHU4b8lDZ1jjEtXYIOYLFx4lgL9toEntOlGGzX3U/T8Yz4xHYiDWN xATcqh6GJUD+CmJkwf0Ue1XmyFmYsgI83cPlDBk5YHaVk63xJdcJ/4LWT6nfrl3jeaL+WP5YpnD 2++n5N9eFZ0ruR2xOXg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_02,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605070009 The min_acc length can be calculated from the platform UBWC configuration. Use the freshly introduced helper and calculate min_acc length based on the platform UBWC configuration instead of specifying it directly in the source. Reviewed-by: Bryan O'Donoghue Reviewed-by: Konrad Dybcio Reviewed-by: Dikshita Agarwal Tested-by: Wangao Wang Signed-off-by: Dmitry Baryshkov --- drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c | 6 +++++- drivers/media/platform/qcom/iris/iris_platform_common.h | 1 - drivers/media/platform/qcom/iris/iris_platform_gen2.c | 1 - 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c index d77fa29f44fc..aa4520b27739 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_gen2_packet.c @@ -3,6 +3,9 @@ * Copyright (c) 2022-2024 Qualcomm Innovation Center, Inc. All rights reserved. */ +#include +#include + #include "iris_hfi_common.h" #include "iris_hfi_gen2.h" #include "iris_hfi_gen2_packet.h" @@ -120,6 +123,7 @@ static void iris_hfi_gen2_create_packet(struct iris_hfi_header *hdr, u32 pkt_typ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_header *hdr) { + const struct qcom_ubwc_cfg_data *ubwc = core->ubwc_cfg; u32 payload = 0; iris_hfi_gen2_create_header(hdr, 0, core->header_id++); @@ -146,7 +150,7 @@ void iris_hfi_gen2_packet_sys_init(struct iris_core *core, struct iris_hfi_heade &payload, sizeof(u32)); - payload = core->iris_platform_data->ubwc_config->mal_length; + payload = qcom_ubwc_min_acc_length_64b(ubwc) ? 64 : 32; iris_hfi_gen2_create_packet(hdr, HFI_PROP_UBWC_MAL_LENGTH, HFI_HOST_FLAGS_NONE, diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h index 5a489917580e..08a9529e599b 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_common.h +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h @@ -77,7 +77,6 @@ struct tz_cp_config { struct ubwc_config_data { u32 max_channels; - u32 mal_length; u32 highest_bank_bit; u32 bank_swzl_level; u32 bank_swz2_level; diff --git a/drivers/media/platform/qcom/iris/iris_platform_gen2.c b/drivers/media/platform/qcom/iris/iris_platform_gen2.c index 5da90d47f9c6..01c6ffa7e084 100644 --- a/drivers/media/platform/qcom/iris/iris_platform_gen2.c +++ b/drivers/media/platform/qcom/iris/iris_platform_gen2.c @@ -792,7 +792,6 @@ static const char * const sm8550_opp_clk_table[] = { static struct ubwc_config_data ubwc_config_sm8550 = { .max_channels = 8, - .mal_length = 32, .highest_bank_bit = 16, .bank_swzl_level = 0, .bank_swz2_level = 1, -- 2.47.3