From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986BB23370F for ; Thu, 7 May 2026 02:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778121735; cv=none; b=Ju9jjIlNkPDppgpyoiWYh6xFrsULTU/XoTCjNScR10nCYVu6Mh41F0QDo7+9BcClmUpWZR6BRu0RpxH8nZWNwgG6U7NQVMBiuGEYTEj8bbZDf45MMAoAtyPmMuM+X1lGDhecapkNDt6VOTobyTWHSPxtI/b7cD0KY2DhtCKLxpE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778121735; c=relaxed/simple; bh=eMMu+K0cQgPzRF05g3iQbc6Kq7csEBTXQOfS5rGWFtw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VxeH80mCpKL5WxwX+qTILB6qGk9A0SeCveuDZiVuNlDVQu2UkGluQtYtRqGXQTdaJz4K7O6WVn7rfIYfgG9kevm53+TpdHdTWlD0+rWnJunkV5GdNUgXzRsP0jQsUOo1vw1eYjaL0x7LNNqYLKELemWCZ+rYc6ydesM2gXuP974= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H8npXdpO; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H8npXdpO" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-bb91b426e40so48876766b.0 for ; Wed, 06 May 2026 19:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778121732; x=1778726532; darn=vger.kernel.org; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zXUcAlrmHgNDVyXI8VvqahFaHz43xO1FL0GrZXHX79E=; b=H8npXdpO0WVHUWe9USmYjF2rFs+PVeA5Ka+/KSNrsGH8o2iXo5Kyfiisgsnu3BnjC0 r8NGXjcB/Kg4OYWcliRyYlEWJnFgNms56x/fCTQFeQYRZo+WiWqnxm6TGYlA1l5QiAWR tCmfZY8CvtdM0pIVEPXvUEAy4a0ahZuUtE+DJ0K9hcMBwg7NwEgDgeBmAjQJgM4T4XVs s+S65n/EZ6GrjhfjzPIBS+i0ALQTmeLNNPQ0ZtcCjTVPw4bwaVB8hed3AovXD9BEAK3v LfckjdVE6pXzyp+Nw9oY43Dtk4K1PP6tRXHTdpSxVOoNmuDiFZ9H2h5vVyUTDGp8eFLq fM2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778121732; x=1778726532; h=user-agent:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zXUcAlrmHgNDVyXI8VvqahFaHz43xO1FL0GrZXHX79E=; b=YaeYU5lFSFUIwTWgAhONEl3obpc22fUbudyq28K3xXddRhCRuk8ItAr59UuYBo1eFZ ACmDc5nPUNSTXq6is/ix8y7ZD6fu5Ju2qCzJ8ji42izCbDQ2c0q6X96oYVdtupDIukGM k+06VPongv81laqsruN9t+jO+jaV2/l5fOYy/3ZIuKYOhr4xq6llyVGfUHcFmY9qZSE/ +/Cxtyc++Q9hR2UOdwOoURpGjZZ9w455M/ntSk8StXdsWou7wlTzemrYUdlVe5srxV64 Iyn6pnUzEXtdOTvhSMdZEOk0iIAZAScnnF77TfL/5BdJCx/myS35MF4gwDND746WPgUz ovxg== X-Forwarded-Encrypted: i=1; AFNElJ8KjQCUbshaDwrcxSvOT+pJEoQ1b60EZQY/l/Bc1dgp+I25hM6pSIDokD+5deu5/M1Cf0Y+sHqfE9Nu6l4=@vger.kernel.org X-Gm-Message-State: AOJu0YygqtBXqby+hMAoXjGsXydrooUc4ELdScH+tLFRggy9KE4AXIAx 8h9+/xuhmyess6Zy8OUytWcMI/qNFtFs0iHRLcqjKBKrQMlzOuBRQvjzwYJBZQ== X-Gm-Gg: AeBDieskjBrzuDrUDjmW3Z+dXJm0Uqak4dXng3um5aeBpvBRZQW93Lr1QhU379ZhbSJ fgN48UYrF1HLGdayorhwNhmU8F3PmzupOSDeaBDoNTqKs/ac35DyH33Wi9fa77ceny7i63oklKL XoASXldDNyBbR7SDFrZNRJOQTEKooGwwTFR3Vqj0xeRKWjDlI/Mddfjr/7FmV0ZBWdHPh83nJ3H B9wXwZMjCQYr7OuQ+MlmJTVpKNLAb8ia1ZLzEwQkc0kva/TQ5Ha+3Wd4caYRmU7AaNWPc0qzjKd ZQTY3Z+xjtoyy+YVV8uGciPraKbvHUP9xmiEW4gwP6rssMVaBTe4FGugczp/LIn3rmmdgy/0wB9 FgF4w818VRWPxkWBly0xLwvVDdzvnS8P2NvStLMpWNCUy0xXAMguooS+2yzRfb1YrlWx5+Avav7 f9ecPOy40xnLiRDOJHd62aBXUScn4cjJz6 X-Received: by 2002:a17:906:ee8b:b0:b98:40e:f335 with SMTP id a640c23a62f3a-bc56cd3192bmr366528666b.34.1778121731613; Wed, 06 May 2026 19:42:11 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bc833742a49sm30083266b.34.2026.05.06.19.42.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 06 May 2026 19:42:11 -0700 (PDT) Date: Thu, 7 May 2026 02:42:09 +0000 From: Wei Yang To: Lucas Poupeau Cc: m32285159@gmail.com, richard.weiyang@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tools: include: add proper strscpy() declaration Message-ID: <20260507024209.c43ad4pazkh6fzz7@master> Reply-To: Wei Yang References: <20260506163452.53067-1-lucasp.linux@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260506163452.53067-1-lucasp.linux@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) On Wed, May 06, 2026 at 06:34:52PM +0200, Lucas Poupeau wrote: >Remove the macro hack and add a proper implementation in tools/lib/string.c. >This avoids unsafe strcpy usage when strscpy is expected and fixes >potential compilation warnings regarding str_error_r. > >Fixes: 9e3d665 ("memblock test: fix implicit declaration of function 'strscpy'") The Fixes tag seems not necessary. >Suggested-by: Maxwell Doose >Reviewed-by: Wei Yang Hmm... I didn't see your change before, so I can't reviewed yet. It is not proper to add RB by yourself. >Signed-off-by: Lucas Poupeau >--- > tools/include/linux/string.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/include/linux/string.h b/tools/include/linux/string.h >index 51ad3cf4fa82..d6e53109e786 100644 >--- a/tools/include/linux/string.h >+++ b/tools/include/linux/string.h >@@ -12,7 +12,7 @@ void argv_free(char **argv); > > int strtobool(const char *s, bool *res); > >-#define strscpy strcpy >+ssize_t strscpy(char *dest, const char *src, size_t count); > You mean add proper implementation, but this is just a declaration. Where is the definition in tools/lib/string.c? Something is missed? After applying your patch, I got this when build tools/testing/memblock. memblock.c: In function ‘reserved_mem_add’: memblock.c:2464:9: error: too few arguments to function ‘strscpy’ 2464 | strscpy(map->name, name); | ^~~~~~~ In file included from ./linux/kernel.h:11, from memblock.c:9: ../../include/linux/string.h:16:9: note: declared here 16 | ssize_t strscpy(char *dest, const char *src, size_t count); | ^~~~~~~ make: *** [: memblock.o] Error 1 > /* > * glibc based builds needs the extern while uClibc doesn't. >-- >2.54.0 -- Wei Yang Help you, Help me