From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82463271456 for ; Thu, 7 May 2026 03:23:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778124195; cv=none; b=cVlI36RruekSU0Icds5o0nMEfQpct9EG1lvANCrrlvYQrlcE1Ewgj36ma4OkFeYi0TfFM4Ea4pLqjIpHBwbdeFsKKbziMoKwWFKdkRTL7ho2GJ8E91+zH2/A0fThGo1aMkpWv8atQ/YyI/EFEZuOaBxbYtUus3rwxkuAF+u3nIw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778124195; c=relaxed/simple; bh=YOHaTrTO2bgG1szBYvgb25QwzcZQi/N3orRsHo4pxgk=; h=From:To:Cc:Subject:Date:Message-Id; b=gY/3mshKqFklerjNgF1Q3cSnR0x9Z7iiu8a0oajN4UmSYGGfduuZYrmAU0b1JDrBJFFMTzeW1aaii68SPFF3eY57+rqPomtkKV+IDtPQj8pEpIuLORBiTTpfQIAXmVVfXpEfwCSaFH9UYLDQUvJQI12CXbZM2UrSvUMmbR74RsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cg/npZGv; arc=none smtp.client-ip=209.85.214.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cg/npZGv" Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2addb31945aso2875055ad.1 for ; Wed, 06 May 2026 20:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778124194; x=1778728994; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wdDg8/HMfxwGVYCeCx4VqYijHS+xPr41cT4+HzVmNBw=; b=Cg/npZGvm8qUsAre6d3dUjBwxW3repDUltQM2+ZlTj6PsHEa/xjGlsSq8AesV7OEgH YxWFa3tv6wil7mjhX7WzU+yYzChn45ik9V1ifyl2KMcC8AlA/rrHBPv0w1/ocJ90lmR8 z3GpHMCD39XsFLtNIwNlWjGZOpUoo+gGi5qithOw+xGggBpbdUAwSubgdf0tnFumnWEC wD79iv+mgZMzVRXDQQbBLLO8Vb93ux6WI43c8kcq/r+t8qT4V2X1z9fiKLjFdfr+Xa1B iBdhLwlLP37k2VPfy0w11qMvsK4bkgEnQ79xL0viQgXY6/1F7OavkCIjmdUvc4FEHPDO hx2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778124194; x=1778728994; h=message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wdDg8/HMfxwGVYCeCx4VqYijHS+xPr41cT4+HzVmNBw=; b=Dq9t5jW0gHuilT/F7SqVqCANGg1gyRFuB9ALCfmD0DXsEWorP1OifeWaVME+V8l+th YHkHVCIzet9ZGF/QZn7sUI1l9ZGwfrSEpzEJmXcvWcVgBzfLBE+iF2jltaaer9W99kht 2UqF7slW6/DFdNw7MPkAxQ6K5bKKusi0CnGip2wNIpUD//QSdYOsQ3fQhKBU3ShA/mKd LTWi//xq7wer/W9HnPkSSfxDgCwunmt5L/VLeoCnE2klj6ovkruKRdXgr5X3+kLfaWwI WQJ+PWEsJALtSkgFfPx94TwhZDgfzxVhwC7hIzuXenbMiDyfI7+Rj/ut3QEv3TgEw+h2 z52w== X-Forwarded-Encrypted: i=1; AFNElJ8w8M+FCAo0brD/shWzid9Odbr3lI0t3engsaU6BpDIoDSSELnWcgLZhepjmXGmCSVdL+052byAjnEc/C4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxbpcpc0Jb59XlzWEVWqgGwJhORd/iaTcmBuZpLwXwW/OEsu7EK IG29GcMus44djZ+fA1bNw3YWxpWnal/aEISpum3/OkQv4X4vDC+nDwe/ X-Gm-Gg: AeBDievboQ8P+/SznyAqvO/SMxEwgD2tpE8r1LTdROgn3zIW3wCO4DdLR0TE0y22siY VhmFWgTNR7Qle2SK0m1oDipUWqnjBbfcWFTbD58M+DzMYzwsPBEviEcnEoah95NXRM8Ozg0hQ8B /aZ9OWpEPug2bvlCjzpGqzSBcVpCvNKAFfa4YX8WeZf5FUdZl0FnjU++vyybL681BTtHQ9stHqL 4bp33g/BwYEZ4PZ3rFD76MYtVvBi0gyEPm98hWnCDsydMFJibAagi5M1dyLvLEcaG0HattNPMVy aw1L9dzbQ9eY0o/FjdgHjZuIuVj8WsbwaH+TNAyQAhj1760TZpf8MXkAV0GZj1cwER+wzWZAPMq kuoPW5GZJ7kIMHqkDVKP4mQqhCmpkS/rIY1KUlfTjfhDYXf5sipVFT659y9XTW4jIKj1rXp3vD7 xsHTysPlwkUwT2VSo7TzlvJX2q+vSYuT3KDaOhmxfF104KzQVTTVLu9VGlWrHKP2mbO2xgd7z3 X-Received: by 2002:a17:902:cec8:b0:2b4:5aff:de60 with SMTP id d9443c01a7336-2ba794b80d1mr66074765ad.22.1778124193787; Wed, 06 May 2026 20:23:13 -0700 (PDT) Received: from localhost.localdomain ([123.139.40.148]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2babadd2427sm7435005ad.38.2026.05.06.20.23.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 20:23:13 -0700 (PDT) From: "haoyu.lu" To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: Zhihao Cheng , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Haoyu Lu Subject: [PATCH 1/2] ubi: build: replace simple_strtoul with kstrtouint in open_mtd_device() Date: Thu, 7 May 2026 03:23:07 +0000 Message-Id: <20260507032308.16485-1-hechushiguitu666@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: From: Haoyu Lu Replace the deprecated simple_strtoul() with kstrtouint() for parsing the MTD device number string. kstrtouint() provides stricter validation and better error handling. In open_mtd_device(), a string that can be parsed as a pure number is treated as an MTD device index; otherwise it is treated as a device name. kstrtouint() returns 0 on success and -EINVAL if the string contains non-numeric characters, which aligns with this logic and eliminates the need for manual endp checks. For compatibility with kstrtouint(), mtd_num is changed from int to unsigned int, consistent with the existing simple_strtoul -> kstrtouint conversions in mtdoops.c and mtdsuper.c. The multi-line comment is simplified to a concise single-line comment since the logic is self-explanatory with kstrtouint(). Signed-off-by: Haoyu Lu --- drivers/mtd/ubi/build.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index 674ad87809df..03ef195dc25c 100644 --- a/drivers/mtd/ubi/build.c +++ b/drivers/mtd/ubi/build.c @@ -1210,21 +1210,16 @@ static struct mtd_info * __init open_mtd_by_chdev(const char *mtd_dev) static struct mtd_info * __init open_mtd_device(const char *mtd_dev) { struct mtd_info *mtd; - int mtd_num; - char *endp; + unsigned int mtd_num; - mtd_num = simple_strtoul(mtd_dev, &endp, 0); - if (*endp != '\0' || mtd_dev == endp) { - /* - * This does not look like an ASCII integer, probably this is - * MTD device name. - */ + if (kstrtouint(mtd_dev, 0, &mtd_num) != 0) { + /* Not a plain number, treat as MTD device name */ mtd = get_mtd_device_nm(mtd_dev); if (PTR_ERR(mtd) == -ENODEV) - /* Probably this is an MTD character device node path */ mtd = open_mtd_by_chdev(mtd_dev); - } else + } else { mtd = get_mtd_device(NULL, mtd_num); + } return mtd; } -- 2.17.1