From: Lance Yang <lance.yang@linux.dev>
To: ziy@nvidia.com
Cc: akpm@linux-foundation.org, david@kernel.org, willy@infradead.org,
songliubraving@fb.com, clm@fb.com, dsterba@suse.com,
viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz,
ljs@kernel.org, baolin.wang@linux.alibaba.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
vbabka@kernel.org, rppt@kernel.org, surenb@google.com,
mhocko@suse.com, shuah@kernel.org, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v5 03/14] mm/huge_memory: remove READ_ONLY_THP_FOR_FS from file_thp_enabled()
Date: Thu, 7 May 2026 12:29:58 +0800 [thread overview]
Message-ID: <20260507042958.95301-1-lance.yang@linux.dev> (raw)
In-Reply-To: <20260429152924.727124-4-ziy@nvidia.com>
On Wed, Apr 29, 2026 at 11:29:13AM -0400, Zi Yan wrote:
>Replace it with a check on the max folio order of the file's address space
>mapping, making sure PMD folio is supported. Keep the inode open-for-write
>check, since even if collapse_file() now makes sure all to-be-collapsed
>folios are clean and the created PMD file THP can be handled by FSes
>properly, the filemap_flush() could perform undesirable write back.
>
>Signed-off-by: Zi Yan <ziy@nvidia.com>
>---
LGTM.
Reviewed-by: Lance Yang <lance.yang@linux.dev>
next prev parent reply other threads:[~2026-05-07 4:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260429152924.727124-1-ziy@nvidia.com>
[not found] ` <20260429153538.727855-1-ziy@nvidia.com>
2026-05-07 12:48 ` [PATCH v5 05/14] mm: remove READ_ONLY_THP_FOR_FS Kconfig option Lance Yang
2026-05-08 2:52 ` Wei Yang
2026-05-08 3:22 ` Lance Yang
[not found] ` <20260429153538.727855-5-ziy@nvidia.com>
2026-05-08 7:01 ` [PATCH v5 09/14] mm/truncate: use folio_split() in truncate_inode_partial_folio() Lance Yang
2026-05-08 19:46 ` David Hildenbrand (Arm)
[not found] ` <20260429153538.727855-9-ziy@nvidia.com>
2026-05-08 7:46 ` [PATCH v5 13/14] mm/khugepaged: enable clean pagecache folio collapse for writable files Lance Yang
[not found] ` <CFECCB44-EEEA-4D3F-A505-3BA2C564C107@nvidia.com>
2026-05-08 20:09 ` David Hildenbrand (Arm)
2026-05-08 20:13 ` David Hildenbrand (Arm)
[not found] ` <20260429152924.727124-2-ziy@nvidia.com>
2026-05-07 6:08 ` [PATCH v5 01/14] mm/khugepaged: remove READ_ONLY_THP_FOR_FS check Zi Yan
2026-05-07 6:57 ` Zi Yan
2026-05-08 19:39 ` David Hildenbrand (Arm)
[not found] ` <20260429152924.727124-4-ziy@nvidia.com>
2026-05-07 4:29 ` Lance Yang [this message]
2026-05-08 19:43 ` [PATCH v5 03/14] mm/huge_memory: remove READ_ONLY_THP_FOR_FS from file_thp_enabled() David Hildenbrand (Arm)
[not found] ` <20260429153538.727855-7-ziy@nvidia.com>
[not found] ` <52285e2c-af42-4c0d-9926-017f80b6614c@redhat.com>
2026-05-06 13:11 ` [PATCH v5 11/14] selftests/mm: remove READ_ONLY_THP_FOR_FS in khugepaged Zi Yan
2026-05-08 19:51 ` David Hildenbrand (Arm)
[not found] ` <7e42faea-9f55-4722-a426-94be7fc3a49b@redhat.com>
2026-05-06 13:15 ` Zi Yan
2026-05-07 6:35 ` Nico Pache
2026-05-07 7:21 ` Zi Yan
2026-05-07 7:24 ` Zi Yan
[not found] ` <B1D68BA2-11D2-4053-B715-F7704ED784DA@nvidia.com>
[not found] ` <3BFC4C26-1C97-40AA-B4B7-7472B9768565@nvidia.com>
2026-05-08 19:48 ` David Hildenbrand (Arm)
2026-05-08 20:06 ` David Hildenbrand (Arm)
[not found] ` <20260429091305.fd5a1c8c986c111527c2b024@linux-foundation.org>
2026-05-09 22:10 ` [PATCH v5 00/14] Remove CONFIG_READ_ONLY_THP_FOR_FS and enable file THP for writable files Zi Yan
2026-05-11 7:19 ` David Hildenbrand (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507042958.95301-1-lance.yang@linux.dev \
--to=lance.yang@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=brauner@kernel.org \
--cc=clm@fb.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=dsterba@suse.com \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=npache@redhat.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox