From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78C512E9EC7 for ; Thu, 7 May 2026 04:56:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778129815; cv=none; b=FlqEAR6hBy+kNpej8NKlQfoJdEWmEigkMcZ4NSCbM+2Ob6558j0J7pfOFGAHICzCNdjECllIXJbLytggLa4jDCzlmuflFCpidaP4yQT6Daofdz98Z6CjL0HhrBqCqn38J+bTmwCYn0lHkcLsp9SwWcg+kdNPaGRZS/LRXFZZk9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778129815; c=relaxed/simple; bh=3eE5haRfGcjDTqRR6Xt3Y7qwbYtLOCiNxAyT3odM/Lo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LnvBS4LWerHT4OMbN5VDyo2wt03dk8et+BLWEr1Y2HDfdRti8UQrCRvqG7GYOb37kMKCbj9BzhMzXNN/fzvbWifAJoihrXtKB7TtHYKtp/f8sduMrdrLDH40HBVuumke5S0VNajyRFLyvT7XB4Fyx+iAZd8wCG6ALHauwaP+IS0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YuXEC4n2; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YuXEC4n2" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2ba838c5ff1so10913135ad.3 for ; Wed, 06 May 2026 21:56:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778129814; x=1778734614; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7ywGKeEnvYSXg9nFtEwvQO+tPBvZeysG1x+jeuWr74M=; b=YuXEC4n2j/YC/FDWb1MnCm5jw5m8SWEph75T98+uJ78doNVh/NvUMfkFam3iASR7ln nAStUfAE8g3crn+GEh729SXoR205s9m0+736w/clEbcwyi9YtYH+Zz2Nz2ke5aUZOq8i 2agp3iad1RSngpOuFc9VIWiWq7VERLj/AjxK1cRkLtehUXKHfElvp869UFzXRGSFr6tp F5DqtxMDcyDx6poe6ApzePMc1tBHkNvX7QoVPzWeWQY51oPeyZcYRPpCuOvIX6mdTmus RNGteCE7C8Wfh87/3QrWLmcDpYwOe52/UFGUO8vTjyhrQnrQTz0NJ2YXsL0ksB8PclKH 4hVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778129814; x=1778734614; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7ywGKeEnvYSXg9nFtEwvQO+tPBvZeysG1x+jeuWr74M=; b=brs1o+6IXt05QmxZvDRpwjQFTmu6IIEND1qiy1EP4B5S3Nek7ldr5RhJmZMb7Siso8 OV0DDuRae8zwOjdG0ykWU9LEWXEnFhTLee1WvtYTKSVuN12E54kSz0ssbiX91g/Q/zu7 UldTgEluH2C7LwcGTinCIzoqEvYDqtPAlJ+W1awMUvzSxcT7KNAqjExr8ww9Fzrx0L7o SPkfFLW5kz+vHWfcdeaadP3dPO6DtxRXyqZqWGmZqt+cs4orez+4uIFGKpntDeGt0fK4 Q0X9q1gc1oRyyZp6L9hZe88lJxhRa8HPQ7K98gWj2X4183asmFWn+zuQQYY/BKacRYwY 85/w== X-Forwarded-Encrypted: i=1; AFNElJ92RAyDcpNNdCSwJ33HTTl72DvO7BnDx0cMbn5JxxNxxV4h0CApfiqSFbZQBM0kUbEwAuICyX8jR02dwnw=@vger.kernel.org X-Gm-Message-State: AOJu0Yxkb3vikfYpY8Huo+aZFmyr1KxXr3E4UUGPcScEJHz56cXhJFCn 5GD8ohhpo8Yt7K5lHbLl3uMbFp4T0SoahF4abzcyL3Lcbb0jm8BMBETXKKBsoK9+Ti068WDAkot Sk9Ip7UXc36SYp2st8aX1AnDgLg== X-Received: from plot2.prod.google.com ([2002:a17:902:8c82:b0:2b2:50b1:327c]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:1ad0:b0:2b0:a980:3687 with SMTP id d9443c01a7336-2ba79291460mr70680015ad.3.1778129813774; Wed, 06 May 2026 21:56:53 -0700 (PDT) Date: Thu, 7 May 2026 04:56:52 +0000 In-Reply-To: <20260421104652.211276-2-joonwonkang@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260421104652.211276-2-joonwonkang@google.com> X-Mailer: git-send-email 2.54.0.545.g6539524ca2-goog Message-ID: <20260507045652.2296187-1-joonwonkang@google.com> Subject: Re: [PATCH v4] mailbox: Make mbox_send_message() return error code when tx fails From: Joonwon Kang To: jassisinghbrar@gmail.com, sudeep.holla@kernel.org Cc: dianders@chromium.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, joonwonkang@google.com Content-Type: text/plain; charset="UTF-8" > When the mailbox controller failed transmitting message, the error code > was only passed to the client's tx done handler and not to > mbox_send_message() in blocking mode. For this reason, the function could > return a false success. This commit resolves the issue by introducing the > tx status and checking it before mbox_send_message() returns. > > Cc: stable@vger.kernel.org > Signed-off-by: Joonwon Kang Hi reviewers, Could you help to review this patch? Since this attempt has been open since June-2025, it will be appreciated if you provide any other reviewers who can help review if you are not available. Thanks, Joonwon Kang