From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9DD1834CFAB for ; Thu, 7 May 2026 07:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778139005; cv=none; b=aREjHAmt6srEzBmsC++/t6cRTXa9hLD9uCUvvWPdEyNqu4q2YULilpEOMmmL+Rqu850XWottEqnTfM/CgCS5DnLCGmF90HlbsmdEoBQKKKv2fR7ziz2gHBAh624RIRjvr7yXRhOA8T2oCgaF2/dDfjHbj/98kTVUKtNodAslohc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778139005; c=relaxed/simple; bh=G8Jxbu0JQJx5TOlxCIXjopQDJ+2wLU3eoFK47RMhcLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rsM6y1SAGpneC8iVSlURVpbbECWv+P88S9xElG6hsO0NmjR/8qINEyN2Ad+Yet3G9/aV+qFGiDN03CH2iS1rxk7KQRzlh4fLILW4bnaRy6p4/+TfnD/mt64dtpzz4zoq8EBZy20OjoLHPLX7I+BzdO+eRrOTZk0H8q2IPBdM9a4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=CVeNwtOI; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=B7U+sdFW; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="CVeNwtOI"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="B7U+sdFW" Date: Thu, 7 May 2026 09:30:01 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1778139002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pzvc/1jV0xOJOLPO1paoHhjSVtCIMWsT3xRzrIWQOro=; b=CVeNwtOIpko+3OhkyGrP3lXZJDrvN8kWFlst7eeK2iKf7k0TX/JdOc6pmSVWYLt7KZGfLk bR2rmPeCYhfuQ/J6C0yED0DYcshGa2VePqYVdKTCKmd/DmJdLfX8H+11dbRsnrwnK+O9aB eOHTk/XeWtqOfGpfBaJM4HkjlGT/k/km5+itZIJko9rj4hVxyPjclySKD6qMOFmLxEgxCo zyq5wSRuYOOXR9aXT0ljOqTNMK+nRhU8r297d070ZwtQcMHyGAgSSZlng8aP5m4Ta4y1nT MjxxvT7IpOTlq7M/DdKvJp7BI7h7Q6caYMvJRno+DdJyJ2QaZsNmWVONoqOf/g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1778139002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pzvc/1jV0xOJOLPO1paoHhjSVtCIMWsT3xRzrIWQOro=; b=B7U+sdFWGqaUHjnhFdc2AttfW5JvhYMOQE5kw2k8DXCGR90/vct4hRBgz18eyKqz+x1ttS 0nnYtBdmFQ0u43BQ== From: Sebastian Andrzej Siewior To: Bart Van Assche Cc: Peter Zijlstra , Marco Elver , linux-kernel@vger.kernel.org, Ingo Molnar , Will Deacon , Boqun Feng , Clark Williams , Steven Rostedt , Joel Granados , Alexei Starovoitov , Vlastimil Babka Subject: Re: [PATCH v2] locking/rtmutex: Annotate API and implementation Message-ID: <20260507073001.uivRw2RK@linutronix.de> References: <20260505022649.870788-1-bvanassche@acm.org> <20260505161256.0NhG6_Hm@linutronix.de> <41878012-e4db-4199-a3d5-ed2dc5badc0b@acm.org> <20260506073541.d8Ywsyl6@linutronix.de> <6b472fc2-2e52-40f2-9c37-81bfd70b9d96@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6b472fc2-2e52-40f2-9c37-81bfd70b9d96@acm.org> On 2026-05-06 11:53:05 [+0200], Bart Van Assche wrote: > On 5/6/26 9:35 AM, Sebastian Andrzej Siewior wrote: > > Hmm. This mostly reassembles __mutex_lock() from mutex.c which does the > > same thing. Couldn't we get away doing the same thing meaning a > > __cond_acquires() on those with a return value and a __acquire() in the > > void case? I think it would make sense to keep those two close in terms > > of annotations. > > Please take a look at the rt_mutex_lock() changes in the diff below. So that warning keeps all trouble away and shouldn't trigger anyway. Okay. > Thanks, > > Bart. Sebastian