From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B03BB31E841 for ; Thu, 7 May 2026 08:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141090; cv=none; b=stvYVcDI+C7RPItPqCSExMqDTcmaRrc+XNx/z8N/qcxZX2p/8WKyb7YGUzgMTzkWM0x19UVvlsZHl79bfZ/zacNxHTUUtcFuyC85MQS29Jq5V2jcn8PIrgeaXHoTAF2qS5wfgw4KKax9uopbEx1UFPHqamqAwAj817TjhBa6jxE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778141090; c=relaxed/simple; bh=0TdBK8w34M/TlCdppsTgo0f00DpgIJVuhmLY0JYvBrE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KD7MWzWuyO2akv6F0EjQ7EwvHOzEEUAPK/ZnaI+L4Kfsu18PCBD2LDiJYc9TDt/7FTdTrx9EX1eYs31fqje82vcDt5my+4JYRMII4euqPqrSWSSuzu6PqhDiN2fQlxDNWbPzr/01f7AM7ffd7OBPVdYjuFjZxL6dBrCcSaJ9n0M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CaWDqwn/; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CaWDqwn/" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so10738255e9.0 for ; Thu, 07 May 2026 01:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778141087; x=1778745887; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=z7YckadijkDGQ6TtrrNwULTfEdvjDLhXzpW91JVQJ8w=; b=CaWDqwn/gxfYNAvw7BRXJUW44MDzNkl1dXZR1kP6Mn4tAwcK+cPHtXB+yIlZGyZYor 0OV6mFs2EykCUoPUzueLBe61g/2q3o3PVysIdRCARRBkiV7XKVFaZ+KpB7BJpohlhutU MKOAjyIHiYPPybznoiKE10SqhiG8nZmgkmdEfvdLD66K/a2fTd5svDrkPM2G+JJebDsZ 6Mzb/Guu3POkolc6TdMGLFpHWokDSeUIyab98IRM0YBA8PgoxPOox4etqvt7/JWbvaB2 i5u39rkRanmkUSAAhuES+g2QjkcpggSuotX/nC6MJYHN/WeQSdZraehcyLZh2Xo7yVFq WqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778141087; x=1778745887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z7YckadijkDGQ6TtrrNwULTfEdvjDLhXzpW91JVQJ8w=; b=ZRXkM6GD0uxxePZiQhIIuR0hWic9EA1ZYxlcmnf/+JU9whBYCve3irH737NYfhGzxw dPpDt+SNpcOYv/JC+BVu520VtSHPszNx9+BesOA8N/s9A0i8XNCY2M8xDS36kwk7uMKZ w1CeV0oisiCYjPwbLK0LfeIRLGAZ85zbktTlea6aSUnMHFPCk0a64Wve19/dnuitBHQY RB0LOG7owSoEeta7jN0X19YyLU8HGtnmWq95jeakIe7qymdeBSeSv4LMDe4eSp9xPhXD ejdl/tWc2hQIXZFpZDjGYQy4qVDzfktdbvlPinrpq6Te2jUatOr8cJbPGEfD+NJgRVSs OWNw== X-Forwarded-Encrypted: i=1; AFNElJ9tW+6a4lihDARHmpDAmCjDAUHR1BaBaeuiTCUBfYhMoEDjs8uoTdEiSmeJCF4f+uxfu6z+n/IHk+ZHaPo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2e/rNpPbu4UBUFJ9rVduH0Q2Xctng6Xjp7d6ATl0nTopSMsJj yBV0W7SkXnYT1E61hL0vD2woQ/vuiZwDZVlZtKbaOCNjijn6OhgGqO4f X-Gm-Gg: AeBDievK4DQN2XKcpSapA95wJSPQdT+CP7pZAp5uhdN2VrVnhxuBnkYfHcM4WneQ66s xGPXYV5tsq5CEI/gLzr11oMo6N096EM+XnsUwczOL0LjSPCnSuxYKsGShv/zCX7j1P1v6Z/n+iw QOMSueyybiIPT3NwKsreDe0Ek4bnIFDcP6404SFAlGlezefvmaLm4QmFS6fyUc4Jo598PAwLdgj f1hSyYC233sjzRdPbXD0EdiRcUkzdV5iiYnoxZD26Z0vtx0qFGsp/SRImvrQtnQkLpoIrTuJabL yuSU3Vwy878Gbh71IIG2h23PLlzs9426+gHo/dWUuX3jSv2i/HMRE7hHVpZcOkzRWKBAVJSZF8E yvJ/ZL1aiCOWdVrGPeiIQ/O4kmNqb9A9JIMrOgFGIQgQATo6apFDHWHTeZTA2ZKW2RW9d0VBLjo OI4nnetfB+/K9704XItuu7B4BlUyu4QBLS8ouinxwe6zeRuSjYll/GJ/Qv/Slu/nSYp/SHrh9jD iWJodrLdw== X-Received: by 2002:a05:600c:4e56:b0:489:1abb:5559 with SMTP id 5b1f17b1804b1-48e5dfd6508mr27365125e9.5.1778141086701; Thu, 07 May 2026 01:04:46 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45052a4878fsm17608283f8f.9.2026.05.07.01.04.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 01:04:46 -0700 (PDT) Date: Thu, 7 May 2026 09:04:45 +0100 From: David Laight To: =?UTF-8?B?w4FsdmFybw==?= Costa Cc: jiri@resnulli.us, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org (open list:DEVLINK), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] devlink/param: replace deprecated strcpy() with strscpy() Message-ID: <20260507090445.3448d536@pumpkin> In-Reply-To: <20260506211415.16343-1-alvaroc.dev@gmail.com> References: <20260506211415.16343-1-alvaroc.dev@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Wed, 6 May 2026 18:14:11 -0300 =C3=81lvaro Costa wrote: > Replace strcpy() call used to extract a string parameter from param_data > with strscpy(). Since strscpy() already performs bounds checking and > ensures the destination string is NUL-terminated, remove the string > length check as well. >=20 > Signed-off-by: =C3=81lvaro Costa > --- > net/devlink/param.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/net/devlink/param.c b/net/devlink/param.c > index cf95268da5b0..26695b7e2861 100644 > --- a/net/devlink/param.c > +++ b/net/devlink/param.c > @@ -536,11 +536,9 @@ devlink_param_value_get_from_info(const struct devli= nk_param *param, > value->vu64 =3D nla_get_u64(param_data); > break; > case DEVLINK_PARAM_TYPE_STRING: > - len =3D strnlen(nla_data(param_data), nla_len(param_data)); > - if (len =3D=3D nla_len(param_data) || > - len >=3D __DEVLINK_PARAM_MAX_STRING_VALUE) > + len =3D strscpy(value->vstr, nla_data(param_data)); > + if (len < 0) > return -EINVAL; > - strcpy(value->vstr, nla_data(param_data)); The only sensible thing here is to replace the strcpy() with: memcpy(value->vstr, nla_data(param_data), len + 1); -- David > break; > case DEVLINK_PARAM_TYPE_BOOL: > if (param_data && nla_len(param_data))