From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A67123C6A43 for ; Thu, 7 May 2026 09:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146407; cv=none; b=YGIAqsM7SeigjLZOUZ6xf9oiKdqwztin1/1YHKYfzcqHAj+zBRAiOp/nXzk9oTKbC6WRBH2tPxofU+ZnZXKHwpAvTElpf7Frs/BBAprsWpxwjsaVvMT83bGJANn16fY9K4OlaPdQ1k4T7ZtD0Smr+vReVlF+7HJqQYUbaWQh29s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778146407; c=relaxed/simple; bh=XhZrXauAACb4WHe93YLAMRtIyhKDF5L0YIyHXg6C7x8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oevMgHKy3dxKx8Z26jwN6w6LNDyuCTeXTUigVDrSoGIz3rHkA9jFkpvwOuwWNpx5MZiGnQ5vg8jiaO/96HThzKw6Y5wStcUHO/cq6AEJ3aE8jVXKU2f2mWnphJzz+R/x+ciq6pKwiFQ0o+6hDGgf5HJXGD/P5t3S5xKHJmTnlMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Y9J7OcNd; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Y9J7OcNd" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-39380e79936so7431581fa.2 for ; Thu, 07 May 2026 02:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778146402; x=1778751202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+AGdFUHDF2nHQALLrNQHKOEqd/fvRy2bQu566xPn6As=; b=Y9J7OcNd8GbH0Rp4yGyFtMZgxMut0pOGsc0BPkyGg40LALT/cGiUPxNdpkTs0bVHrE 8l27GOuHDfOundSaZ5HcWst1gJj4PwMcMbOuR1AhPGMjYRMcgJ4EupI1Uo68oSnu2j62 yXp6fHaznxP06C+X3TUPU4sLNPMoaa9Az+HyqMekzNqx37PBh0RNABsQheEj2DI3KVn5 pQyXliiVj4OTXbwMVSaJyun8Ka3jrdiVJ21kKUcOImvh4cBcmAQ1QIlQ6bQ8Qc8wzL94 zg5x0v9d5bOhXBskwEZ62+Tmk++s4DFTVwmQXmjv48qcYZlCcIpcLl2s5xEMlGoZ4vtg s9uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778146402; x=1778751202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+AGdFUHDF2nHQALLrNQHKOEqd/fvRy2bQu566xPn6As=; b=etuG6dTbc5iTTDR9EFtEkQe7MqxJO8YtLqNPC8vYI7vBkPgr+M2872d3xK3Ve9dj3N 5FGMaF0zYiTkEMENAGC2GmSAh/CBO4Igx9RYu3JLwwZVHEC2waPZub4/1JZDEmv3bZtd o/MejgJCseypOiU0y1hAvVDXpXCxJFmT/VIyOlKh0S3HxgIqIXlccZQ6EMsnsZJYO3Cx zrfuw89T2WuF9oSSnvwxeMZw3XRzkwRWN4j38xhVqxm5vPaxaq3L5mbzh/5f/GucTt2b 5KlU4gs+W8j/mJj58MffiQVK0Yb/+cXvt4Epznob51U1AtypydCUFSyJJUyDbrIhT2KM s2gQ== X-Forwarded-Encrypted: i=1; AFNElJ+XMnzZ7uGXuREu92DSc5Db0954MddWafl2dRhuguLEFdaBiGgP63CW8W4aiKB3GLgDXIiaq2V+sVd4X08=@vger.kernel.org X-Gm-Message-State: AOJu0YyloNRdNDvrrt4W+N/0iAX2AOYqFX0YtIZhWge0yrK7Fq1Qwv2u AaZ/UkQrqKKGpaiSDLJIC6fdhmZfGuG4W36Zp6/dlleqASAr4RVOo2Nl X-Gm-Gg: AeBDieuS8mgJnujDcU1TJG3T9zjwtUdnfbzfM+NtvWyXRlcOCwOp+gYr1Z1M6FSmvgv AecuNqLoIlfLJq5+4eOAEUlNTcnV9/UEHlPZtI1s8AB78y9EonspqBdQrbKiReyP3VAx+9tVcBc 8ADvNR7583llR2QZxSp4yRRewWUOgkfgw8y9sWIJ84mblZ0maMKaQXVVeWzF77fBGn/d9PlOoOv 5XKqwUio6X5121U+dxIwzgnSvbnMRZgDsSfKYTJZPVF75dKgaI2X7Zu7ON5u/xNDlgRnS/3jMQG HrnaS4CDTGDN/Lavq6+J7/+3zdowYsd7xO2VEfm9FwU9eFpdXRu6NvIJNA+Suz+5PDpPfiNZZmo H2XMc47qDT16AjEKRCfwCT3DQ2v1btWmLMAfTEJB7jfqfJq89q4LJjbQJz3cqHcXJLaHiIh5CPI SRjOmQ0CVRurTKltPl5Ti725wYpDaimun6s8AH X-Received: by 2002:a05:6512:318e:b0:5a8:9dc2:8a81 with SMTP id 2adb3069b0e04-5a89dc28d0bmr493127e87.17.1778146401564; Thu, 07 May 2026 02:33:21 -0700 (PDT) Received: from builder ([2001:9e8:f13c:9216:be24:11ff:fe30:5d85]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a864c6f16esm4752445e87.15.2026.05.07.02.33.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 02:33:21 -0700 (PDT) From: Jonas Jelonek To: Russell King , Andrew Lunn , Heiner Kallweit , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Chevallier Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Bj=C3=B8rn=20Mork?= , Jonas Jelonek Subject: [PATCH net-next v7 1/2] net: sfp: apply I2C adapter quirks to limit block size Date: Thu, 7 May 2026 09:33:00 +0000 Message-ID: <20260507093301.1144740-2-jelonek.jonas@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260507093301.1144740-1-jelonek.jonas@gmail.com> References: <20260507093301.1144740-1-jelonek.jonas@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The SFP driver assumes all I2C adapters support reading and writing the pre-defined block size SFP_EEPROM_BLOCK_SIZE of 16 bytes. This constant was probably chosen based on good guesses and known limitations of a range of I2C adapters and SFP modules. However, I2C adapters may even support less and usually need to specify this via I2C quirks. Theoretically, such an adapter may provide full functionality but only support a read and write length of e.g. 8 bytes. Currently, the SFP driver doesn't account for that. Add handling for I2C quirks in SFP I2C configuration taking the fields max_read_len and max_write_len in struct i2c_adapter_quirks into account to further limit the maximum block size if needed. Signed-off-by: Jonas Jelonek Reviewed-by: Maxime Chevallier --- drivers/net/phy/sfp.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c index bd970f753beb..e58e29a1e8d2 100644 --- a/drivers/net/phy/sfp.c +++ b/drivers/net/phy/sfp.c @@ -807,21 +807,29 @@ static int sfp_smbus_byte_write(struct sfp *sfp, bool a2, u8 dev_addr, static int sfp_i2c_configure(struct sfp *sfp, struct i2c_adapter *i2c) { + size_t max_block_size; + sfp->i2c = i2c; if (i2c_check_functionality(i2c, I2C_FUNC_I2C)) { sfp->read = sfp_i2c_read; sfp->write = sfp_i2c_write; - sfp->i2c_max_block_size = SFP_EEPROM_BLOCK_SIZE; + max_block_size = SFP_EEPROM_BLOCK_SIZE; } else if (i2c_check_functionality(i2c, I2C_FUNC_SMBUS_BYTE_DATA)) { sfp->read = sfp_smbus_byte_read; sfp->write = sfp_smbus_byte_write; - sfp->i2c_max_block_size = 1; + max_block_size = 1; } else { sfp->i2c = NULL; return -EINVAL; } + if (i2c->quirks && i2c->quirks->max_read_len) + max_block_size = min(max_block_size, i2c->quirks->max_read_len); + if (i2c->quirks && i2c->quirks->max_write_len) + max_block_size = min(max_block_size, i2c->quirks->max_write_len); + + sfp->i2c_max_block_size = max_block_size; return 0; } -- 2.51.0