From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E2DB39023D for ; Thu, 7 May 2026 08:51:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778143890; cv=none; b=Zx/LCx1i0lqxMmCjRXogRbqR3mnwUmEdY1vMLHF/uqThnAWfZTT2Ly1P6828/Uu+Ys6zjVrnb8O0W075514oGd3RMDSKuWpV8UGrI7kHto/3XGrTGh57w1Cc8tgWrbzENikuJnv09A4lJEwVY1tvfO+/NeoF7F7ndIIjFton9uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778143890; c=relaxed/simple; bh=VX3jn8byCgO0ZAJp6dhWZejX5JlmyqMoj5sZHahesx8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DuX8nyipWx1R5BUWlDRNGJGVVG8YDEfFnFnMqeVWYSirC25jZCqBAYLo47kMohlv3iVWL2i/y925X+NvLC+DfaTR7aojYVGGUGG5FTSokk0D+TKAUdXpabX+fmJFYoRbNQ3gZYO3ks8Nik9oITYombLb6bGuoA5gqHH/mYiBO9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EL/OySse; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EL/OySse" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4890d945eb4so11070075e9.0 for ; Thu, 07 May 2026 01:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778143882; x=1778748682; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/9FEgjgSXbJMk9lcA99TUtEICHtp0LNQxToJb92NNSs=; b=EL/OySseyWN85BxkOMhB+UD/sNBitGtHvpqoqP5x6PAQtVACudDjOCjBNSWCl6/H24 C8TFl2ysMrpi9FgHV26JFVKnoeQe+ufKvbNOh+3JH/e6hNNbQw7R1CzPpmFiQV54nBby /tgHuf0CJ4r5Fpaw3kDXWqCJGyxuxkwbucrEuYSVk/GbkUtMhMKRlE74od2Srvljh3YG xacQls46cmhZqblO9I5pikkI0oQU5O0m/U5+1b7DgARkNHKIqlqlxZvm6MSvq/8SWuyW Bl99upnUX+zPU4Vm20yT+RzP9qSxzOCt2FkOTVTANyMgODzYHYPuSbp7VHvjFXE8Rr3Y 1eoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778143882; x=1778748682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/9FEgjgSXbJMk9lcA99TUtEICHtp0LNQxToJb92NNSs=; b=F05gSMIs3R/inGNyeglvvO2KtZdP9qoVWTxnEbHI+IFoJ9oBelZGhcb28S53R42ptw jFiR1sEt/eNSOmR19UQLN3Izw/w9rJVSJ+qTY7IZ/QuML242RJq9yG9t2+VqIbrPacbv kg099Dh73x+CIXaZtPZSoLEjz8fXLNCeHIVXm5Y1St4Y3iVMBlskbBSji1+XF+59TFz9 X9BqgppsEQrU1GHYGR5AgM1C911EhlDukRfhUdfDXpmSTxtAPBhvREdpWjbvYKBCwRct N8Htap7TBJgfhm/jNaYs2W4wEXxXya3dGIzJzJeIt8ampM6IQqvT8pLvwntC4vSnz32W a0vg== X-Forwarded-Encrypted: i=1; AFNElJ8dJLO4iHx8rjCTGayyRllB/k8tqXvQc4d8UAVcjJlli5FjyYdm4wBtXstELt3mUyHlP6xHwScSMAZUT7U=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6QYbbSvYeUqOSjSS/6sNIP2fGSUBc3cXQKNUCnHdY+1k0Yqp7 VZkyPZ7AhKu5sOhNx3nru0YtaXCz2aG3dG/AQvLGkCgSPiAVQk1Qo2Wo X-Gm-Gg: AeBDiesMvRp/imY1fRwevTQL37KD2IHBLMmqEB4j9+tldv0fiaJI0JF5rwmHh4e2OzD Bh3TEUSCyJY4X/HoYlIPG8t5fw5taROeSBmURMeWtRs3DD7fGCnqVg9ivvG2CkvJAB+arK4vuIY dl4/YBCruFkB5B/gBIVLszJF8SlJCgx1apJ8xcl0py2S9kBFgkCeHcchuHtGa8Nzx6mS0Z4s0vA wI+i1jpukH5y89L/h1JeBARzT5tqr2C3MeugQU3kPkIyLCvVh0AoCGkubFNsFyC3T1F92qBL7pK 4uzaWcfed3CKB7KTISueaQGEBw2/SO7rWSAbXxOe8liU5ipHtZE2/l9wIr5tvmbJK/5WRzptYBd njqPQbjojgch7uXYC/ZXyn9Khg/CR7IRwm2vC754x/CNSE9uCdgzPyFogJ1fog7Bcp3AUTvHbBe mugwRNYKGs1eMxwZaKbyKWQ3WAO8Wj96w= X-Received: by 2002:a05:600c:3e86:b0:48a:5339:a46 with SMTP id 5b1f17b1804b1-48e5dffabcamr31079945e9.9.1778143881872; Thu, 07 May 2026 01:51:21 -0700 (PDT) Received: from foxbook (bgt227.neoplus.adsl.tpnet.pl. [83.28.83.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e5312dbf8sm33675725e9.23.2026.05.07.01.51.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 07 May 2026 01:51:20 -0700 (PDT) Date: Thu, 7 May 2026 10:51:16 +0200 From: Michal Pecio To: Jihong Min Cc: Jihong Min , Mario Limonciello , Greg Kroah-Hartman , Mathias Nyman , Guenter Roeck , Jonathan Corbet , Shuah Khan , Basavaraj Natikar , linux-usb@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] hwmon: add initial support for AMD PROM21 xHCI temperature sensor Message-ID: <20260507105116.2c1607d7.michal.pecio@gmail.com> In-Reply-To: References: <20260506032939.92351-1-hurryman2212@gmail.com> <2e2ea249b30168a2eab62fc110c226a511f21bf2.1778099627.git.hurryman2212@gmail.com> <20260506233332.664f220c.michal.pecio@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 May 2026 07:41:28 +0900, Jihong Min wrote: > > I think this commit message and certainly the Kconfig help text > > should include full name of the chip and perhaps its official > > marketing names too, so that people better understand what hardware > > is supported. > > > > So: "AMD Promontory 21 chipset" and "AM5 6xx/8xx series chipsets", > > or whatever they are called by AMD and motherboard vendors. > > Addressed locally for v3. I changed the commit message, Kconfig > prompt/help text, and hwmon documentation to use the full name, "AMD > Promontory 21 (PROM21)". > > I avoided putting chipset marketing names directly into the Kconfig > text and commit subject because some AMD 6xx/8xx series chipsets can > be built from more than one PROM21 IP in a daisy-chained > configuration, including more than one PROM21 xHCI controller. Not sure how is this a problem? The driver is still applicable to those daisy-chained chipsets. Configuring the kernel is tedious enough already, the help text should ideally tell me whether I need this driver or not without searching for obscure code names. I would even go as far as to mention that it's for AM5 chipsets, because AMD recycles chipset numbers every few generations. > > Is there any documentation of the index/data registers themselves? > > I am not aware of public AMD documentation for the PROM21 vendor > index/data registers or the temperature selector. > > For my initial validation on an X870E system with two decade or > so.PROM21 xHCI controllers, I passed one PROM21 xHCI controller > through to a Windows VM, left USB traffic idle, and let a Windows > monitoring utility poll the controller temperature. From the Linux > host I monitored that controller's PCI MMIO BAR with read-only > accesses. > > The vendor index register repeatedly held the same selector value, > and the adjacent data register exposed a stable low 8-bit value. > [...] > > After identifying the register pair, I used the same validation setup > to derive the conversion formula by comparing the observed raw MMIO > register value against HWiNFO64's reported PROM21 xHCI temperature on > Windows. Looks good, unless there are gotchas like the actual formula being dependent on other factors you haven't noticed HWiNFO reading. It would be good idea to record this methodology in the commit message or docs so that others can repeat your experiment in case of issues. Regards, Michal