From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20EC33EBF36 for ; Thu, 7 May 2026 10:51:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151107; cv=none; b=BgxMD14RIitsXTaZ13l8lrDr19Z+OAOTj+CGVNmoPPvNiaCB31QYHSRNwymEd4MOUEs3pAfq9IA1BBjeLXNCGLDcPnw14ZS7TjAUfTO+7d+Xyc5/yviv8kviQt3gASOFGk+HAiplrJtQvyvz23VUw1HDwF2vX8b63GyALNMXrgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778151107; c=relaxed/simple; bh=8be50cgUO97dUmyXY8QEaFaIeWcvbyn4FZHCMFnyX9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=sQITeJWht056eF2WtJjpQ8sThCXSimwuumFKivmzw1GMs2vky2Elulj46KcenCIRZTLUyuZ0HxMoVO5JaFuxEnQUvf8Dkko1bYs02cRyxzgCveQE4zKNhNvlARpKnwfjGtpvQKiR2bBdjXMD98YeuXQUDyHJ7fcLIs0y9lXucu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OLbQ/Kg2; arc=none smtp.client-ip=209.85.167.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OLbQ/Kg2" Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-5a8891f0c51so594549e87.1 for ; Thu, 07 May 2026 03:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778151094; x=1778755894; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=OLbQ/Kg2Ab1Nw7b0o9rhRmuhauZ2HaSuOpQfUpIj4uySDNFnH6CgGvD7Mc/sW4UXSV zV+0wktTQFDPHQN1GQkVRrrTvM5hC3a7VmaOe1DJBDAw5Gb7CFTut8FUJIK0ExxD6n2p zFzZ71TP3gMFPyHsjm6daHIVozdr5kTpJOlc87+4L+EiNmh6ozkF4XkmKtSbT5azqjrI SH+qQbQwCrQStYtmUCTuy2XjHd0c70+eBd2pl8a59pAMV3Ex/5CbPrnGGQoscp56HIDQ rm+UusqD98fRu1+xv7hkbw9THovkrquCas5W8T1Ilbu7KwNpvPtPhuwFaOJKFhiXgiLe BlGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778151094; x=1778755894; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=qopn/oUaKOBQzB8FDCkvvQLUneO2FQXDo4wgXrMs8ma8ZbxVOcgu9XflVknEavuCQr AeVzJ2J7+80QuBZazCRFBQsoQ0EXsvjGjCJcst/EmmXy6BdJB7kaE8n/MO6FmyddX3Cu LqLcosEJ/nZ+1vrv3vn/TVoCT/mF4+uZ908tP6GQfI5Zhkm8nHHJqw6s9lQ19kFnIjnZ iae4uhKClcuzc3q/xWsdGSMBCvn9Zq9K86gJUrc/zqkcpdtrYj9O0WP83gqauz+ZEq/B qFBS1JQfMXNUTKyGQvjlTCVZREsdYj8T5uWAGadG/mbSNWwVLMlDzDrYtwEUz0MTXXlw FWag== X-Forwarded-Encrypted: i=1; AFNElJ/D74P/a5Q4h+D4sZ6cNYt0YKKcYrSZopeq9RaQJ6U1ph5z/g3E0gIuombyKoZw9Ot1/wwJ3qt5+q2/Xvk=@vger.kernel.org X-Gm-Message-State: AOJu0YzGsyWZpiNH+dZbDg3yBHPMosFcu1WrAw71CU8E5pyCho1Kpc/9 YFJxITUpU9eunb/4ksTN+70jfbwk+TYNiMqSB1HfDUvttna0H6c88YyD X-Gm-Gg: AeBDieuJSIg/gDABG1mssRc8gQ6BNdU+xyLlLI3kADu8/UXMyPe40D9hvj18oCzeYsC ZFKq/8QvTIy8A/TA2wu3ppn1pW/PX4heKLq5dOZzK5o45tnFEGeQk/WXVNmOG0XvwbobxvFCpje KU7ur3t6I0Eb13vCBrlTcitXhjci8mhgZr88f9mkRLdNfmBSai7kxUx2o8TrivoN5NWLytyu7qT hpGoZe8rZAexmi5ySuZrY4Hn9jxGrYhnkJ/VRcmMy0KwyFv2QlOMmMDvzbzYENFgbjcVktuJpay S7Kaw+aJ9eNtDRQZJoYVFDMBZr9NO2l189LMTDHXoZWExlG1w0AmWLllyR0cbTrmpopEGuOqA2r oGkMCJsn+W2k7vcAi7yNgL5tXcHY3oLKUclmheZbGSQkgs/EGbY8KByDxa0Lg6+XNWjYxVa/AC1 f6005Vii60nVh8Uj202OFjX8ohZ8sUsC6MC1eoXnNAIwE9St4YK/U8pQn+uxjToBJQfmy4V7ZZ2 No= X-Received: by 2002:a05:6512:682:b0:5a8:7d6c:8b82 with SMTP id 2adb3069b0e04-5a887add82fmr2719997e87.7.1778151093418; Thu, 07 May 2026 03:51:33 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a85c341848sm5530224e87.65.2026.05.07.03.51.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 03:51:33 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Md Shofiqul Islam , jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, mike.looijmans@topic.nl Subject: [PATCH v2 3/3] iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init Date: Thu, 7 May 2026 13:51:28 +0300 Message-ID: <20260507105129.25639-4-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260507105129.25639-1-shofiqtest@gmail.com> References: <20260507105129.25639-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was enabling the internal test signal (INT_TEST), double amplitude (TEST_AMP), and fast frequency (TEST_FREQ_FAST) bits in CONFIG2 during initialization. These bits activate an internal square wave generator intended for device testing and calibration, not normal ECG operation. CONFIG2 defaults to having only the RESERVED bit set after reset, which is the correct value for normal operation. Remove the write entirely since it would just be writing the reset default value. Suggested-by: Mike Looijmans Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 186bda3087..8957e873e1 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -615,15 +615,6 @@ static int ads1298_init(struct iio_dev *indio_dev) if (!indio_dev->name) return -ENOMEM; - /* Enable internal test signal, double amplitude, double frequency */ - ret = regmap_write(priv->regmap, ADS1298_REG_CONFIG2, - ADS1298_MASK_CONFIG2_RESERVED | - ADS1298_MASK_CONFIG2_INT_TEST | - ADS1298_MASK_CONFIG2_TEST_AMP | - ADS1298_MASK_CONFIG2_TEST_FREQ_FAST); - if (ret) - return ret; - val = ADS1298_MASK_CONFIG3_RESERVED; /* Must write 1 always */ if (!priv->reg_vref) { /* Enable internal reference */ -- 2.54.0.windows.1