From: David Sauerwein <dssauerw@amazon.de>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<nh-open-source@amazon.com>
Subject: Re: [PATCH] arm64: Fix garbled logs caused by race between multiple stack traces
Date: Thu, 7 May 2026 12:38:46 +0000 [thread overview]
Message-ID: <20260507123846.35621-1-dssauerw@amazon.de> (raw)
In-Reply-To: <afse5Ld52p7DmidK@arm.com>
On Wed, May 06, 2026 at 11:58:44AM +0100, Catalin Marinas wrote:
> While the above does solve the line splitting, the trace is still not
> that readable as we get line interleaving.
>
> I wonder whether we could do something like dump_stack_lvl() at the
> show_regs() level to synchronise the printing. If that works, we
> wouldn't need the above change (which isn't incorrect but maybe we can
> do better).
I think the change is still needed in either case. Other threads can log
something unrelated to the stack traces which can still cause the
register lines to be broken. After all, use of pr_cont is discouraged.
checkpatch.pl warns saying "Avoid logging continuation uses where
feasible" when adding new callers of pr_cont.
I agree though that forcing stack traces to be printed sequentially
would help with readability. Maybe this can be added as a separate
change.
Thanks,
David
Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christof Hellmis, Andreas Stieger
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597
prev parent reply other threads:[~2026-05-07 12:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260430084738.73909-1-dssauerw@amazon.de>
2026-05-06 10:58 ` [PATCH] arm64: Fix garbled logs caused by race between multiple stack traces Catalin Marinas
2026-05-07 12:38 ` David Sauerwein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507123846.35621-1-dssauerw@amazon.de \
--to=dssauerw@amazon.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nh-open-source@amazon.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox