From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA1F83B95E7 for ; Thu, 7 May 2026 13:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161709; cv=none; b=ZjLizRAmAFloSBG7zWmFE5Eu+bh6CAbVIU+GWD3uSyVN2kRAP1DzZqU9aWESkvAR1GNsv7cohbmqqtPF1w5mvxcj4oZHuUVNC9FBuYMH9LRXuIvY9GGBFJ+1DG5uIZhJCP3D8ibwGLrQOoi1JwW5SU89GQd+6fH/E9NK0mbbIDg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778161709; c=relaxed/simple; bh=VFRgu2cJwqXZgxOEu/B3E6yAKtvNoFeFdDZSZ+K47YQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=dkn5SyZAqAzD6oHXPoXcOVy4jr/huTu6fxH/XZS8Tvf5hyHUj9v7YAsnTZ/wSISMzlMUTlgdMIWl56E4m0YJ/Bfp8gNdfxnFhvWwbA5Mns3V/GyLZk4ivGHBtGQUs0MT80nrH5MrY5X0JBORcs2iD7tH+dWOqYX7/90wQ7Kjopk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=e9nQMaB4; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="e9nQMaB4" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so13030155e9.2 for ; Thu, 07 May 2026 06:48:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778161706; x=1778766506; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WoAsiMhHn+IE4y5ZbpU36N8ZnmK7jeWLatv0EXI80UA=; b=e9nQMaB44daTLZCWnL82eyU/KYb+q4R1mYmCydnhTyLoGihDmXpS58CVAVlvLsZLIp 38VvcOkFbRgFz9sr9AbQnsiYfBtyAYfsFSe14vuK93jCEffY9AHVxvdNM0Bwi6Cd4UHJ G35ZVmaRbFxZOYWvGErZXRCjca0QLXkM7JG/f3DZF4GzkIUsCLPBdAYFPqsc+9bCEvvJ 0BC7KeWdIMY3bNFdYj5cKMgdB5unjliI82WY+zPH4g10aNoosEn1xeOUMXweEoV8uB+0 1dHYLixWx3I6OlhAWOb0z9UOmv36B8zUUxlKK6zUiI6OKYYiJkB6MifmeZpMOpUUA5Ei PhkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778161706; x=1778766506; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WoAsiMhHn+IE4y5ZbpU36N8ZnmK7jeWLatv0EXI80UA=; b=hIUeMtzIZtzM6IvoevvGW/3Q2R7uR6XOkjwof+PH8Y76jlcazUVCyJzLUqlQLqJUq4 EuNnuDhkOoGJfh7t0q23pnsySSUrjrIx4Gel6RirEjUB/NT4IM3X9WAv8DBSwB5g5z6O Xs+Yu5FDefh31XXuRFuj1C0A5EO82Bi3LGUOTlfZGLD7poUv0p/5ysTYdALMwRqSXLor 23dDsautOuMSEJO1/dprOpD1A7h2b6O8VrIVhQG/wXBcJ2KxX+asw1jH+FDHAgST41a+ u7L0fCSxK0nN4iUbywvEjMoAiEFCTZ21GfgOvvkLJ7UDHUaK5mljYlhtOnhEgX6nI6Eb BcEA== X-Gm-Message-State: AOJu0Yz4KHE/Atizuhaw+3ZN9O2DIA0VGJH+FjfDXb6FyxFRmyfa5JYw rtpBjVQRGI3YUH9X81BiCbH08jZK5ihY6T7sa2Nttn+N50ao8GichllZsC9GLsYdwndgEkFtXdh LdoN6ysg= X-Gm-Gg: AeBDies37NgjLCBorVK7SILyJcKuNKYxQLwLaOV+1L3z5bZYUoYofwjdqwr2K4MFsGr kEFWMhT0vt2IqH4QjxafC13Gpp2coSl4+0EbO2yCcvo2hYjFK8oiId9cmi9w961CO+Wyd+8F/eK 9vKDQ3COOqQE2897oPYVC2RJ0Sqx4KaVbyakA7S948zKXsmnjY2GuldiSMrFgi2TOL2whtESHeQ s/3PkjEUYWLOiz3H89Yb7rLxHycUTDP3FlcmqNNDWRxWXUC6B82/v0SbSt6nCsU8IwyoVN0vl5P hJbfe/dFjmmORB9muNy9RWIySk1GOr+DEsuyBuqc3AGiwlZxlyZCrckLYbRbTiuUKZfTFHwxN70 QrQHReeLWWHdQtKTv2OFnn+qTkY9OnsDqgVr5E66L+AcqN26G8XXC5rq+n36KZlC0ejCOp1e/20 yahUaBA0USpc9qSuASpAJqTg6zo5qxxOCV+fCy0KjXBOKb4u1OgCoO+JRrcA== X-Received: by 2002:a05:600c:c494:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-48e51f32c35mr127316915e9.13.1778161705907; Thu, 07 May 2026 06:48:25 -0700 (PDT) Received: from localhost.localdomain ([2a00:6d43:105:c401:e307:1a37:2e76:ce91]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e52f5c1cfsm82872855e9.0.2026.05.07.06.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 06:48:25 -0700 (PDT) From: Marco Crivellari To: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bridge@lists.linux.dev Cc: Tejun Heo , Lai Jiangshan , Frederic Weisbecker , Sebastian Andrzej Siewior , Marco Crivellari , Michal Hocko , Simon Horman , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ido Schimmel , Nikolay Aleksandrov Subject: [RFC PATCH net-next] net: bridge: Move long delayed work on system_dfl_long_wq Date: Thu, 7 May 2026 15:48:15 +0200 Message-ID: <20260507134815.295588-1-marco.crivellari@suse.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Currently the code enqueue work items using {queue|mod}_delayed_work(), using system_long_wq. This workqueue should be used when long works are expected and it is a per-cpu workqueue. The function(s) end up calling __queue_delayed_work(), which set a global timer that could fire anywhere, enqueuing the work where the timer fired. Unbound works could benefit from scheduler task placement, to optimize performance and power consumption. Long work shouldn't stick to a single CPU. Recently, a new unbound workqueue specific for long running work has been added:     c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works") Since the workqueue work doesn't rely on per-cpu variables, there is no obvious reason that justify the use of a per-cpu workqueue. So change system_long_wq with system_dfl_long_wq so that the work may benefit from scheduler task placement. Signed-off-by: Marco Crivellari --- net/bridge/br_fdb.c | 2 +- net/bridge/br_stp.c | 2 +- net/bridge/br_stp_if.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index ac81e58d5f70..14c7943d59a1 100644 --- a/net/bridge/br_fdb.c +++ b/net/bridge/br_fdb.c @@ -583,7 +583,7 @@ void br_fdb_cleanup(struct work_struct *work) /* Cleanup minimum 10 milliseconds apart */ work_delay = max_t(unsigned long, work_delay, msecs_to_jiffies(10)); - mod_delayed_work(system_long_wq, &br->gc_work, work_delay); + mod_delayed_work(system_dfl_long_wq, &br->gc_work, work_delay); } static void br_fdb_delete_locals_per_vlan_port(struct net_bridge *br, diff --git a/net/bridge/br_stp.c b/net/bridge/br_stp.c index 024210f95468..426e1c76ef6e 100644 --- a/net/bridge/br_stp.c +++ b/net/bridge/br_stp.c @@ -640,7 +640,7 @@ int br_set_ageing_time(struct net_bridge *br, clock_t ageing_time) br->ageing_time = t; spin_unlock_bh(&br->lock); - mod_delayed_work(system_long_wq, &br->gc_work, 0); + mod_delayed_work(system_dfl_long_wq, &br->gc_work, 0); return 0; } diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index 28c1d3f7e22f..7a5f4747e1a1 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -53,7 +53,7 @@ void br_stp_enable_bridge(struct net_bridge *br) spin_lock_bh(&br->lock); if (br->stp_enabled == BR_KERNEL_STP) mod_timer(&br->hello_timer, jiffies + br->hello_time); - mod_delayed_work(system_long_wq, &br->gc_work, HZ / 10); + mod_delayed_work(system_dfl_long_wq, &br->gc_work, HZ / 10); br_config_bpdu_generation(br); -- 2.53.0