From: Jonathan Cameron <jic23@kernel.org>
To: "Sabau, Radu bogdan" <Radu.Sabau@analog.com>
Cc: "Lars-Peter Clausen" <lars@metafoo.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Sa, Nuno" <Nuno.Sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Uwe Kleine König" <u.kleine-koenig@baylibre.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: adc: ad_sigma_delta: fix CS held asserted after single conversion
Date: Thu, 7 May 2026 15:07:22 +0100 [thread overview]
Message-ID: <20260507150722.2121398a@jic23-huawei> (raw)
In-Reply-To: <LV9PR03MB84144C0FF2FC2197AAFED941F73C2@LV9PR03MB8414.namprd03.prod.outlook.com>
On Thu, 7 May 2026 12:17:25 +0000
"Sabau, Radu bogdan" <Radu.Sabau@analog.com> wrote:
> > --- a/drivers/iio/adc/ad_sigma_delta.c
> > +++ b/drivers/iio/adc/ad_sigma_delta.c
> > @@ -442,10 +442,10 @@ int ad_sigma_delta_single_conversion(struct
> > iio_dev *indio_dev,
> > ad_sd_disable_irq(sigma_delta);
> >
> > ad_sigma_delta_set_mode(sigma_delta, AD_SD_MODE_IDLE);
> > - ad_sigma_delta_disable_one(sigma_delta, chan->address);
> >
> > out_unlock:
> > sigma_delta->keep_cs_asserted = false;
> > + ad_sigma_delta_disable_one(sigma_delta, chan->address);
> > sigma_delta->bus_locked = false;
> > spi_bus_unlock(sigma_delta->spi->controller);
> > out_release:
> >
> > ---
> > base-commit: 3b3bea6d4b9c162f9e555905d96b8c1da67ecd5b
> > change-id: 20260428-ad_sigma_delta-fix-bb65d56ccbb0
> >
> > Best regards,
> > --
> > Radu Sabau <radu.sabau@analog.com>
> >
>
> Hi everyone,
>
> Uhmm..., why was this fix marked as Changes Requested? Is it something I am
> missing?
Looks like I missed in patchwork. It has been applied.
>
> Best Regards,
> Radu
prev parent reply other threads:[~2026-05-07 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260428-ad_sigma_delta-fix-v1-1-8e3f925ee8d2@analog.com>
2026-05-07 12:17 ` [PATCH] iio: adc: ad_sigma_delta: fix CS held asserted after single conversion Sabau, Radu bogdan
2026-05-07 13:52 ` Sabau, Radu bogdan
2026-05-07 14:09 ` Jonathan Cameron
2026-05-07 14:07 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507150722.2121398a@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=Nuno.Sa@analog.com \
--cc=Radu.Sabau@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox