From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 45711401A11 for ; Thu, 7 May 2026 14:37:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778164679; cv=none; b=AgG8h4JmrUVdL9s+uhGlYgJkQAVtj/aRo+VdK0MQNnqizj+tpwmQVC+yfhZEXlX7iNKu7oCQeLQpwWay6L/xW0FaYO533Xco3W4RJ8V2vzbXg85RrYdvFTU71/UPz5+mBBnCCGs9tqAKhERFSVleFz2aT4MjaAXiHjBiNsniG/g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778164679; c=relaxed/simple; bh=+6l+nOdGVkavFeHR/ZWA+j/A/CHvSr6qp4DtjVMSKbc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CqvhABVM8YFSDhZ/1i0k9yDPxYrjMmmZJ/lYWq5juTLzRwr0g39P8FJZOYmB49WgW5fKDbKx91eBTichPmW48Peadi5tzSv8XDBT8gZNiqrnlb3ZVVP0lnGTtSeN9wOTUlxBtmABnNF0NU1cV8TgLUdQfpsPkYFNTZYTA7MH2Q0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZkLKNTMy; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZkLKNTMy" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so14026655e9.2 for ; Thu, 07 May 2026 07:37:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778164677; x=1778769477; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kz71/EcJzZj1K6D19jKVwvEn4Qe+HOLKzTAqW7JWDdI=; b=ZkLKNTMyYhYmWCkdcW+89LbFWBT2bExH4/uPcHx83LQzyvkfKrBQYCQxt7epv+1cX3 HfzCHVOq+FDISVnaLglcWycEmhJ/iNhu0bu/qGuhz5l5X+n4UZ3vRKNcLoTOiIgWintW 26HcRGiyVn6HyTQtP8XOP/RzY7Lt9Ieb639D7dwDOn7Z6hjI2A1YkceJhRuzO3egfE9s pVZXOnGHKtJNdgkapBkn8jnI8/n2MNq0+N7FcCbdWGWn+iwTIkHD1y5TNktizrm79War BVovg6Z+Eju9k586iFcbZGXIgj2Qb6AFTqaUzFUoAmFEAEIYNgj51ujZzicN96KO+r0w PPAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778164677; x=1778769477; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kz71/EcJzZj1K6D19jKVwvEn4Qe+HOLKzTAqW7JWDdI=; b=GbnIjOry17/Y++KiO7He+nr5ldNfIRzUrav3HW7q/ctPqhD2SOeEfXly7KOpBERR6p +5ZoU6MFVXEx0njKrTkuZjQe3h0q4JKPEw27TAPWWiPCqTfHfwO0ZbW11GjhFypTPamZ yOhBTuIntFA35mWcDTCJbEjLgVBkJJeAn2dIcum8yPNRJCuwRjWwlbdBgQaSxx/QA5y6 OAUB4eHbHJaWKKUp7GIbx6gm+CQSJqwN0yHl+8n4QOszh92ABWBTxafta6YPdIi04LoZ BnlJxzJ452NDSUhFlKwL0swtzA/p0QI2p3lQr9GS6TJQEg9Z45OQ7o1Qaj3xmKApUv60 PNLA== X-Forwarded-Encrypted: i=1; AFNElJ+ag8AhvsvY9d8yPIPVxtupgsw0IgmAW/ydfRAwVhnECj5ntJ+m8+jNpB6j2H3nDcxEhuB4jhwCyPn4CfY=@vger.kernel.org X-Gm-Message-State: AOJu0YyaAwCKF/SNgCHIah6Jc7hzE0mWQF1H4mz3h/qo64hp1KtmhBVO 5GQIm6UJxn8fVSzhaMvSeyo539W/r5gZ9RYP5VuIIo7sM5srT+1qOJvH X-Gm-Gg: AeBDieuHKsZ7NDtfntctwQXuJJhd2tHSRu8EoU9OK5RR65uYH23wxaTIJEJbtw/zIzg 33p147bUWxAHfS2daTT3z6IFo+AzPEEEsx+2f5DhsQdyENvO2kdb08hUxX/cpMEnpYQzkq+PoD+ jcmI77ev9IWsxLU+7IkYsEXgUQrSkGdHXsHlchCLbGQM1gB+AsX0E25PuLicuY/v0NKYrKaZcLV p3kavXq1GMws0QZITGIvF1wXVhjA0DO2ttR3/gRoFSvLHNVkA5TeZ73wf9gatoANFB2zAwXDSZ/ QJQo3CkliYKJMG9SI4KmUhzCQvaNg8DLroSXwGGm9SJUy+d7R4Ic/5ghXF9KZN0ulpdfAOcYxbp 5KbnFVCDhEC6NhESTx+i9oEFgHm1HtT5DUjOliPCkra/51N1HrbWfWdI1SU7j2g91G/zLfE8Uxv U/V8QIWWqcAXco+uCpx6HhFa+7QEKmNm4jFght4twLukEhJLXBS8HCzNbxoi0n5gvFzgg787KMJ yU= X-Received: by 2002:a05:600c:c494:b0:485:46fd:7887 with SMTP id 5b1f17b1804b1-48e51f32c35mr130076185e9.13.1778164676226; Thu, 07 May 2026 07:37:56 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e538fad5fsm140430065e9.10.2026.05.07.07.37.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 07:37:55 -0700 (PDT) Date: Thu, 7 May 2026 15:37:54 +0100 From: David Laight To: Paolo Abeni Cc: Adrian Moreno , netdev@vger.kernel.org, aconole@redhat.com, Eelco Chaudron , Ilya Maximets , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , "open list:OPENVSWITCH" , open list Subject: Re: [PATCH net-next v3 2/2] net: openvswitch: decouple flow_table from ovs_mutex Message-ID: <20260507153754.346d7274@pumpkin> In-Reply-To: References: <20260505084253.998548-1-amorenoz@redhat.com> <20260505084253.998548-3-amorenoz@redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 May 2026 13:31:24 +0200 Paolo Abeni wrote: > On 5/5/26 10:42 AM, Adrian Moreno wrote: .. > > +/* Must be called with flow_table->lock held. */ > > int ovs_flow_tbl_flush(struct flow_table *flow_table) > > { > > struct table_instance *old_ti, *new_ti; > > struct table_instance *old_ufid_ti, *new_ufid_ti; > > > > + ASSERT_OVS_TBL(flow_table); > > Minor nit: adding the assert and the comment is redundant. I think the > assert alone would be better. There are other similar later occurrences. There is no point adding an ASSERT() for a pointer being NULL. The NULL pointer dereference does the same job and can be easier to debug because all the registers are still live. -- David > > /P > >