From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E9E03BFE2B for ; Thu, 7 May 2026 14:50:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165410; cv=none; b=EwzmB5oWv946ok7pNySCCY0kkfAO74n/LVnNVEp2dKRaHYN8ONQp+fGK14qTfTZr7Ia+vhY7FXt7kdENbCGzAist721irsSPGcnDlleFMA7xyj0yCmbO69OiYN6dw0SLo65YkomVODSAPGxaXnACVZZJj53bL9sviUucHkg2s6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778165410; c=relaxed/simple; bh=wdi4qtiEctfoiQNuVz+U8eHaMc662FosLCEsmsjfrHE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rZb95JQ/uVoG3GUgpW+5BxkE68bG8Anr1h2W2fgXO4Q3O5aTytTJqR/6K8Fv4l23FK81xXbvj6Mb/7AUAfIGe+GadJyW1SYfpiJqetadLAALl9yE1uYrcnNrn3TnP+3pC66Lto/sG9Z5Z92hVj57sqXyE+TG9Uj9JSJDpcgOVEY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qNvqkC8x; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qNvqkC8x" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488ff90d6c7so8871625e9.2 for ; Thu, 07 May 2026 07:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778165407; x=1778770207; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fyk8eDbl85Hd7XiZtHIzqBxAFI/hqUpEHNnD2/TC2s0=; b=qNvqkC8xDFXnGCMT2tPOpIREvMk+O/7oCxsAAocQ3WaZCzbRDbUTwypXkINy9mTtO/ 7LDncDHZpdRFIR9GwgvDKfu7fSS9K1c22wEExbJYovTyIsMBUwfQ3wUJFn2v5RVXGM+I eY4wJ2JX3FrJ2yw1G8TzHZ3TznTxECrMrsFE5IetJnHKrB0N1JPCxzAM792VHLctgrLW 5f6HBucjdBsp+noydhJ2v2iw6Ebwqnx7jiJ/WDk1bKgnv5o9jroea7umpCBI8ldyeC0f rbiofezDJJ0Yc6eEw0UsCXg5MGfcdJZhbMO1LlAShX4eiFEYrF9isqDT23HxzBMsE5fz T7BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778165407; x=1778770207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fyk8eDbl85Hd7XiZtHIzqBxAFI/hqUpEHNnD2/TC2s0=; b=lsWV0gsCaRNaLVzFg1XQDIx1pWSxo0kl8OP32GI3lkUPKuimlK9Xvsb9eG+KSoO4da jSalfOQgAchUBkd1k5L7uu6PRJI4b+ZpfL8mVkUQ6V/hudSZlwRt/IlHMxgZE2SFwStR l4S2kO5NdUeKtVnEl2X2vSacwWdJM4+S1v2v3A/gMNiPSLqBe1BbndsY9sZFXYhbzkch PWp6NSVkdRcurCRWAvSPbihR7KWkRyXcmI/nI0DrZYJmk82bXT4+F4nuFasAw4mv2i/E 6emLYMFgu5rWY6dUOfhM114UYpwyB5DYEqzARShmHQlZDQXegYXSF8uDpE/ByHxdJXGH QvlA== X-Forwarded-Encrypted: i=1; AFNElJ9pd+aTIwGZtFsbIZPYJkPtZxh9rNUdWq21Jtby7ARfuUSa+JaqwMwCoZH3eDiz2YCIYIRvehTn2YN+3Og=@vger.kernel.org X-Gm-Message-State: AOJu0YyXfmEyjikLhQzrTqVmRIaCliT8IzyBKGsZ3PoPUPTtle2zYQow rwwPMBzmaSyHUFADW0qHbfY3B5vye9CKyqNAsXVEq04YcQ+j618ik9QU X-Gm-Gg: AeBDieuabtvdSS0PbUXivNb4KpljAsuIdfUXrG7SHVvga+joOJmMC1M3FaSKIIZLCjL LozHD0MUHrMGDnqDBtKEpjOcQcwQ2rXbHO6XtQP1QI8KAYMhYylxGkryupPYZQWecWcvmgi/dSh T8Pnhk9bcfzWZhZLrdbfbNqMNqawdYQn5FPeWLTp4omgl+Z9Wq45T/ddOjjhQ8irhAhB1CP6Ge9 JTLPLkJCDcFtEiKJd7ulwuJqS/w5jM6eZMLee5L0HLVL7P8mSKcLi/quXwSgA/P1fZ46v5DPdS7 TPw700GyGsHuoB2gX9gGXKTYfXK6IzqqlFnM4qcY8duUBExJm8JyLVgJy7KM/KSvgyv7bguEyqp IM1WklVC/TvFv2B0arlE73Qp7TDP6WyItRID9gbM/EV3nUFwHONm1DMhUYTFWIp7mj8XVph3S0b NaG8HH8l05NXKhe58Hhv4zL2x1vsAQx8vPXjhg7D8uNidfmOdm2Nkzq2xFVIONb5crHJ1t0BeEh OjTAjP5rjT7Mw== X-Received: by 2002:a05:600c:8012:b0:48e:5fb8:f80f with SMTP id 5b1f17b1804b1-48e5fb8fac9mr40003765e9.24.1778165406496; Thu, 07 May 2026 07:50:06 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53895effsm125874225e9.3.2026.05.07.07.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 07:50:06 -0700 (PDT) Date: Thu, 7 May 2026 15:50:04 +0100 From: David Laight To: Thorsten Blum Cc: Herbert Xu , "David S. Miller" , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: atmel-ecc - replace min_t with min Message-ID: <20260507155004.4d537703@pumpkin> In-Reply-To: <20260507135525.331107-3-thorsten.blum@linux.dev> References: <20260507135525.331107-3-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 May 2026 15:55:27 +0200 Thorsten Blum wrote: > Use the simpler min() macro since the values are all unsigned and > compatible. > > Signed-off-by: Thorsten Blum I'm all for nuking min_t(), so: Reviewed-by: David Laight > --- > drivers/crypto/atmel-ecc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c > index b6a77c8d439c..2cf53f0b6742 100644 > --- a/drivers/crypto/atmel-ecc.c > +++ b/drivers/crypto/atmel-ecc.c > @@ -56,7 +56,7 @@ static void atmel_ecdh_done(struct atmel_i2c_work_data *work_data, void *areq, > goto free_work_data; > > /* might want less than we've got */ > - n_sz = min_t(size_t, ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len); > + n_sz = min(ATMEL_ECC_NIST_P256_N_SIZE, req->dst_len); Not entirely related, but (to me) the arguments are in the wrong order. > > /* copy the shared secret */ > copied = sg_copy_from_buffer(req->dst, sg_nents_for_len(req->dst, n_sz), > @@ -150,7 +150,7 @@ static int atmel_ecdh_generate_public_key(struct kpp_request *req) > return -EINVAL; > > /* might want less than we've got */ > - nbytes = min_t(size_t, ATMEL_ECC_PUBKEY_SIZE, req->dst_len); > + nbytes = min(ATMEL_ECC_PUBKEY_SIZE, req->dst_len); > > /* public key was saved at private key generation */ > copied = sg_copy_from_buffer(req->dst, >