From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A5D6544DB73 for ; Thu, 7 May 2026 15:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778169071; cv=none; b=lf+99DLOBgLKewdb5ptJ7+TtwLpmcpsCMH6bsclBJca/k3o85Qo/mxGPDt+t1lMD8YHUz57z4Xuya7k9Jac4QxNeWimSav8lM29db9u+8i7yDs7QxcSkpMyBXpb91yh0uJhvDniKyNzAfDpdSZBumoW0e5TXyLsct/r4jVbZf6g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778169071; c=relaxed/simple; bh=1aksb3sTv+dD+8oaOpRqkDLM6tobIYl6BhOKTdgJS9Q=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=FK3aI5cNKsrlZGUQE7tb0V/4wAo+wAqI80JLga+jgZKAJLFXi0nBmCsHIC5l34mvEFxlA/x4/Zf+8U0ouIqKrJ2elUwthpZUzQKNKMjA/dCElLLMt1Ws5gGNJBExhSQgZAC9quF1NxvYuESnJG/PHJyNti8FpaodL9b5on+4kdI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gudvfidw; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gudvfidw" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-899a9f445cbso9055416d6.0 for ; Thu, 07 May 2026 08:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778169068; x=1778773868; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OhRvkpgM0QSD3U0j8IgTu/cvPqVZ1+L8TzU92AUGNRY=; b=gudvfidwxcT5uAWIwQYtMfAshQ+ZP3wPGcWVPFq19mbXLeDHzZ0RUB7MMMXvUiUGEn /DqigmzBlS3U88QrgL3sv2oyYmQbbfLcsTgfrfNO8n+khYcwD2MOA1j4mLclfpTHjVU2 tAKwfLbUgb1AhBXP+dFEoC8Us1is7uMKXX/Jfc96KtudYRnT86o7XlTmMaf7V6HlPyY/ bqUuSCqLjksrbyqrL7aT3W1hkb18BmKBSqvR0s2Qlwp1dXmXuzIAblXmG6emFuEkWv5d j4AxI/chPXy8xhaOUs73AVmvi9FF2fcWhCAfvBYrrPUOQuLPZQCIx0iNtJAgGZS/Gd7b K8/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778169068; x=1778773868; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OhRvkpgM0QSD3U0j8IgTu/cvPqVZ1+L8TzU92AUGNRY=; b=NR2VqK003kjQe6ECKkFh4oM3HVBeEYxIcRDWAxGvxzqnDbUCB1obI6ElPDYMpukcCU rKrS+x/cph1j7XtrkPbmmyECcAc6JUer9/Tblibe37b7PgSeHHG7ll9+G8AuTBFrWf1x RzFqYm3fJoIVb7cy7lvG9G2/KTcqjxehU6GZHO13zFLbDqhVYiiwvk2JDvok/zZsFPYC 5HTEaGFiWOKcPEz+tKajd6PywG4GLj0Q6CuysdJpO87U9gk8sb08gvFp3tvEhrG3AUDu 2q9kk+6GqVYbuoKVdETYQRjE9PG2HmYzfGW2NjUZRcItUNbueGoKQC0mVnZaLizqbUJB mAWQ== X-Forwarded-Encrypted: i=1; AFNElJ9zSgVCxuKyW2uIU8Y/LhuR1rC/fNyRVECJkjW4UjVfDPyb7LrpYlHljY2dAKa4pTvFQOS2Gs28w/i9Eow=@vger.kernel.org X-Gm-Message-State: AOJu0YzrGJB3XezrcF1/LaUbuaLlX8rpvoF9Bslwdi9YdT0aZHNyAsb2 uolBn5dYUKTeuNnVP9ff60H9ll7Om7P57Q7dIdtQV9OsDUoBd2KYlL0XZjp7wg== X-Gm-Gg: AeBDieu7fAZ3o0maZT7v/Po2NWK0NJ5Hm3rBREl/Z1iXDgC7E398Ti04dD7I0+38RJ0 PN3yCp3kapTbNGASbuWcZaqDGg6aWQZon+24xC/w1nb3VIAQKj1Zf6bUylBL1Hlg9dcquJBD2h8 CIZhY5qHqsKtJXP+kQNiFSVOptTH963UifyPqESpLDcinpuAThEfDXxrDQV9X/sHwF4zqj8dSmB hFrB/5ve4UXayVHR/eYfFY68lIrbklNIUv+hhFS8xXRskhBgmSgZUTPXa4wQnVDFMlNcEUpG8zs 9ycMgBF6baA0E2tOYOqFk8FAzLC0LGhsM6lJcq36mSa4oPYJaxN62OtJ/7JfDeDeyti4B9fhPlJ UScsZKHS4slVJb1vvtuBhoZV8XpE7tjcI6wFo4q4yB96IzNc2GBgHIyh3UQZepQQj1za0muiBQk tV0yoSSfE5HuA1MW4MaXsTBBVYEmCJamuhIwCRFs5+UgIqKX8k56TOvTDs98jFr+8/ X-Received: by 2002:a05:6214:2308:b0:8be:1620:a98e with SMTP id 6a1803df08f44-8be1620b526mr32917656d6.20.1778169068527; Thu, 07 May 2026 08:51:08 -0700 (PDT) Received: from I4-L-HQH5357-01.ad.psu.edu ([130.203.159.160]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c0e6d72sm234137206d6.26.2026.05.07.08.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 08:51:08 -0700 (PDT) From: Shuangpeng Bai To: Ryusuke Konishi Cc: Viacheslav Dubeyko , Christian Brauner , linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org, Shuangpeng Bai Subject: [PATCH] nilfs2: fix backing_dev_info reference leak Date: Thu, 7 May 2026 11:50:21 -0400 Message-Id: <20260507155021.941895-1-shuangpeng.kernel@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit setup_bdev_super() already initializes sb->s_bdev and takes a reference on the block device backing_dev_info when assigning sb->s_bdi. nilfs_fill_super() takes another reference to the same backing_dev_info and stores it in sb->s_bdi again. The extra reference is not paired with a matching bdi_put(), since generic_shutdown_super() releases sb->s_bdi only once. Drop the redundant bdi_get() in nilfs_fill_super(). The single reference taken by setup_bdev_super() is enough and is released during superblock shutdown. Fixes: c1e012ea9e83 ("nilfs2: use setup_bdev_super to de-duplicate the mount code") Signed-off-by: Shuangpeng Bai --- fs/nilfs2/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 7aa5ef8606cd..893a504cb80c 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -1070,8 +1070,6 @@ nilfs_fill_super(struct super_block *sb, struct fs_context *fc) sb->s_time_gran = 1; sb->s_max_links = NILFS_LINK_MAX; - sb->s_bdi = bdi_get(sb->s_bdev->bd_disk->bdi); - err = load_nilfs(nilfs, sb); if (err) goto failed_nilfs; -- 2.34.1