From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52EF442EEAD for ; Thu, 7 May 2026 16:34:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778171696; cv=none; b=dYu2ramBjrtMclqJ3F9Cl6f1/pNYuzgFzasyr1EeSj6LKqE3ZzS/5kHKWTMhTeSyAy69nvvvNLXIQu+0q02dlK6X9Wo0zWYOnLTf+NrwRjLkD8KJ22Kz6VgSDCPj7h+MjnvOWLzjPh5Q8qlhw/KGC1phdKYjhodER95hSxU77hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778171696; c=relaxed/simple; bh=67jMIhxSZ6IpyO4o5D89+eoatcvd8leasbTpm1BcyGI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ud/2+/NBJFtAFzN4hIBMKonsqxZiJtDLlkZL/SBo00hny6saEHbGb9D6SGAU44gHsbjvSjdNXJP3VCns9Hu9NqlJJVZ/zOVNPyUvUGlalYWm04TakVl2PAWrV/sny/0ND7lWaNo82xD+9aydD14z2uXOZdVNLDBwDjQhuqG6vL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CLmlj65e; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CLmlj65e" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-bc264a50e7fso204429666b.0 for ; Thu, 07 May 2026 09:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778171691; x=1778776491; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gG5C6gXZ/LiIqxaLiBv5dvLMMivS9UIn2zta7LN39yI=; b=CLmlj65ewinVQn5Sg45tMrPfXYD+5JiXKJuvYgKSk7rag090lkITNnWveSfUK/1Moi 3R6jvEalAQtptfJ/apDs0ywpPB5diEg6xim+XqZ0XCY1iv0uOizS+d8++QFa+amLFtRp ZUcvSORoT6Qd0lYUHcdQl0rrwOAvy5qgiw3SKYakAuwAavRFq49NCk59Ub+tWBaGC46K cMOhK1GchPUlgDB7QYeKJHCTsNbdSCnYJ8rd+XLECK/aKXU2hqk69HFPWpmfW6e6ZYvJ RaozdZe0myr1gIWVR3C9VHPRPcZPUG1T6TlX2jV4wdi2YPXiqocgHdIkozDbz/8JcRvs gUcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778171691; x=1778776491; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gG5C6gXZ/LiIqxaLiBv5dvLMMivS9UIn2zta7LN39yI=; b=SIq5ePQOkldPGxJ5/+ofhFNVJ9N/3DhJpemT3gaHQhPHDMYBPWqQKe9qmq5AUrufFN hM5/E4XHCp3slVMXSP8EyOn1B4v6j5xPcK8ORzgXpgENafBgHZSYMt9VyqwY7RanYXEM vGOBFZiYKeyc8nLAJcVDy9NqShihi0WFSOb5Yzu+CsBxrC5aiZVPNtpOFBO3B8d3qHHx k/LVRbOPoNgzlr7V3MBm7L1kLJ5/sAGFcUeZ3fMwyszm9YAWM7y+GZ5kqdFWvB0M+HcX mxfIc3sfxG8gnk0KokaR9Xm16TpjG1/4D6QWKhGoIiYADNtK6iBbPZ63FWOg2Pjtl0cm NBCA== X-Forwarded-Encrypted: i=1; AFNElJ9fhv+j9P5Q7v4cy8OB7SvSiz1VML/Z6MWBB9xVOtoCS3e8mmtL1UzLxbFycivPLnp9AczSf2nhxf781Gw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4gJlmegAo2L7oAKeoGQnW/n6Zv3XI2tDNNUe0wg6K9E+CHJlY u5VVzm88ghwOtsXSYQ0mXeVrvaK0U8wnEkNL5BKIORJP2b93ykWKU1Ra X-Gm-Gg: AeBDievT2hGvleziKlFHz+Q0Qb5z43Zv54Cn3/2xyCGASeYLmbOnG5PJZuGQ4wYLDk+ IxbIcKS6v6T00MJ90XzIpdhiw1IlRLEt7tCwaeSynr6FNHMGcPBi2tmODt0tlCyuTFyYD9RbZ41 HaLUe6IAXbb9WE9wZRuEycw9ihhBS3fn2TW1Qt1MkMm4QjL8miAzrWhRgHmFRCHtRdBNMott3Ob EMEDuXzqbfrFWXOVuo1+nWBkNI9xGxmUpAyGwMqW1GyfiX8sUOPSp+JIGg2F0IiR80kcxYSi3Fn 5OcK4PKOv2UhJ/gpRj3DoOASW14aPp090hgJZ/C11KxvHeU4iLumjZUbXA5OQ9v9Zb4so1pD49Y NphUsG/+JPt9TYfgf8eY/2WCIcnhtK9+2YSE3JFANKrATwxZgA4iIX2lKLwXx0n48GBpOy1psbV PN/dLdi1iDdEw1e1MnS33hKOjk6u0cuyrjfA== X-Received: by 2002:a17:907:3f24:b0:bc6:2bd3:8176 with SMTP id a640c23a62f3a-bc62bd388e2mr413967366b.35.1778171691229; Thu, 07 May 2026 09:34:51 -0700 (PDT) Received: from avt74j0.. ([2a02:8109:8617:d700:d9bb:cdec:69e5:2f8e]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-67eb34dd33fsm8765a12.31.2026.05.07.09.34.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 09:34:50 -0700 (PDT) From: Martin Hecht To: Cc: sakari.ailus@linux.intel.com, martin.hecht@avnet.eu, michael.roeder@avnet.eu, stable@vger.kernel.org, Martin Hecht , Tommaso Merciai , Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1] media: i2c: alvium: fix critical pointer access in alvium_ctrl_init Date: Thu, 7 May 2026 18:34:30 +0200 Message-ID: <20260507163443.39794-1-mhecht73@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current implementation of alvium_ctrl_init creates several controls in function alvium_ctrl_init and uses the returned pointer without check. That can cause write access over NULL-pointer for several controls. The reworked code checks the pointers before adding flags and also it creates controls for V4L2_CID_BLUE_BALANCE and V4L2_CID_RED_BALANCE only if supported by the particular camera model. Fixes: 0a7af872915e ("media: i2c: Add support for alvium camera") Cc: stable@vger.kernel.org Signed-off-by: Martin Hecht --- drivers/media/i2c/alvium-csi2.c | 72 +++++++++++++++++++-------------- 1 file changed, 42 insertions(+), 30 deletions(-) diff --git a/drivers/media/i2c/alvium-csi2.c b/drivers/media/i2c/alvium-csi2.c index b62b45a4f2fc..947b32950efa 100644 --- a/drivers/media/i2c/alvium-csi2.c +++ b/drivers/media/i2c/alvium-csi2.c @@ -2100,34 +2100,41 @@ static int alvium_ctrl_init(struct alvium_dev *alvium) V4L2_CID_PIXEL_RATE, 0, ALVIUM_DEFAULT_PIXEL_RATE_MHZ, 1, ALVIUM_DEFAULT_PIXEL_RATE_MHZ); - ctrls->pixel_rate->flags |= V4L2_CTRL_FLAG_READ_ONLY; + if (ctrls->pixel_rate) + ctrls->pixel_rate->flags |= V4L2_CTRL_FLAG_READ_ONLY; /* Link freq is fixed */ ctrls->link_freq = v4l2_ctrl_new_int_menu(hdl, ops, V4L2_CID_LINK_FREQ, 0, 0, &alvium->link_freq); - ctrls->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; - - /* Auto/manual white balance */ + if (ctrls->link_freq) + ctrls->link_freq->flags |= V4L2_CTRL_FLAG_READ_ONLY; + + /* manual white balance */ + if (alvium->avail_ft.whiteb) { + ctrls->blue_balance = v4l2_ctrl_new_std(hdl, ops, + V4L2_CID_BLUE_BALANCE, + alvium->min_bbalance, + alvium->max_bbalance, + alvium->inc_bbalance, + alvium->dft_bbalance); + + ctrls->red_balance = v4l2_ctrl_new_std(hdl, ops, + V4L2_CID_RED_BALANCE, + alvium->min_rbalance, + alvium->max_rbalance, + alvium->inc_rbalance, + alvium->dft_rbalance); + } + + /* Auto white balance */ if (alvium->avail_ft.auto_whiteb) { ctrls->auto_wb = v4l2_ctrl_new_std(hdl, ops, V4L2_CID_AUTO_WHITE_BALANCE, 0, 1, 1, 1); - v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false); - } - - ctrls->blue_balance = v4l2_ctrl_new_std(hdl, ops, - V4L2_CID_BLUE_BALANCE, - alvium->min_bbalance, - alvium->max_bbalance, - alvium->inc_bbalance, - alvium->dft_bbalance); - ctrls->red_balance = v4l2_ctrl_new_std(hdl, ops, - V4L2_CID_RED_BALANCE, - alvium->min_rbalance, - alvium->max_rbalance, - alvium->inc_rbalance, - alvium->dft_rbalance); + if (ctrls->auto_wb) + v4l2_ctrl_auto_cluster(3, &ctrls->auto_wb, 0, false); + } /* Auto/manual exposure */ if (alvium->avail_ft.auto_exp) { @@ -2136,7 +2143,9 @@ static int alvium_ctrl_init(struct alvium_dev *alvium) V4L2_CID_EXPOSURE_AUTO, V4L2_EXPOSURE_MANUAL, 0, V4L2_EXPOSURE_AUTO); - v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, 1, true); + if (ctrls->auto_exp) + v4l2_ctrl_auto_cluster(2, &ctrls->auto_exp, + V4L2_EXPOSURE_MANUAL, true); } ctrls->exposure = v4l2_ctrl_new_std(hdl, ops, @@ -2145,15 +2154,8 @@ static int alvium_ctrl_init(struct alvium_dev *alvium) alvium->max_exp, alvium->inc_exp, alvium->dft_exp); - ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE; - - /* Auto/manual gain */ - if (alvium->avail_ft.auto_gain) { - ctrls->auto_gain = v4l2_ctrl_new_std(hdl, ops, - V4L2_CID_AUTOGAIN, - 0, 1, 1, 1); - v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true); - } + if (ctrls->exposure) + ctrls->exposure->flags |= V4L2_CTRL_FLAG_VOLATILE; if (alvium->avail_ft.gain) { ctrls->gain = v4l2_ctrl_new_std(hdl, ops, @@ -2162,7 +2164,17 @@ static int alvium_ctrl_init(struct alvium_dev *alvium) alvium->max_gain, alvium->inc_gain, alvium->dft_gain); - ctrls->gain->flags |= V4L2_CTRL_FLAG_VOLATILE; + if (ctrls->gain) + ctrls->gain->flags |= V4L2_CTRL_FLAG_VOLATILE; + } + + /* Auto/manual gain */ + if (alvium->avail_ft.auto_gain) { + ctrls->auto_gain = v4l2_ctrl_new_std(hdl, ops, + V4L2_CID_AUTOGAIN, + 0, 1, 1, 1); + if (ctrls->auto_gain) + v4l2_ctrl_auto_cluster(2, &ctrls->auto_gain, 0, true); } if (alvium->avail_ft.sat) -- 2.43.0