From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B9A63264E4 for ; Thu, 7 May 2026 17:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778174345; cv=none; b=Dixtte7vEkJbElHiDzSZ8tFDCfN3S081/45C2tw+3KIfCt2q0u9woyAEFt2tqDMq5zKbNVYNidhVHjUmiV4+g1oB8NfApHSXG662wJRAXMHeHv7vmXol6Ek2t0MjvNyXrfks5XAFncKRdD+W3yGooitjUctb15KbYOHNhWHKoVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778174345; c=relaxed/simple; bh=u2owr+EhJ49lG8DmRwVM+WWZ7QCWCm5W0O85vXnaFPY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PdvllX3t1meW0/y/Tv1dqQVYVFAvxM+WTxCgWazYdL4EgTUM7PbHy8wS2Qu2tqBOkezBHlLkofnj+lnGo2Gf0n92C2rB8u8tC7IZlbg/qAiditRgh5pMHdKzMvo7gHPikJGmP7A88Gne5TBxB9R0nh0ez58IY+mFLXd3lctpdIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hmCRJfGw; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hmCRJfGw" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so854193f8f.1 for ; Thu, 07 May 2026 10:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778174342; x=1778779142; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Fezay2r8HjjVo5D22ctHOSBNn6B7B3QTgdNNMNjU1ks=; b=hmCRJfGwdiLZWuWYMoI30SAG4QByNJwLisKE8ODpPqtfAts0hvz1CZl49d7H1+HjRp IyEsCnH2PBBbI8sw+DI++XMEe9i+tw9Itz7VjB+OP9+gQ8A3SlDIpwMpQr3m1FeUeW2s iX8Zhk2+SpqT7l9gnoFy42OSlfnIbdazvEhQLZxCHVyv9tv9Scku8DWV2oQrS4xff9Qf gXdtXgz7591ZflbeeKqLk7X4fo1WHDFgAdcaaVlFwZuWookKRnxGvWP5QfYKCFrAt9+A 2qJrGPALKgdkOBEH/xvh7631G0Ie1gE+FCju694JvJPuVTrMCCgOMsA+BA2s3QIJrna5 2h7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778174342; x=1778779142; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Fezay2r8HjjVo5D22ctHOSBNn6B7B3QTgdNNMNjU1ks=; b=RjCJdEn0p76bzRycI0qEIe8TRfboURDehrDBlC/2lxxyveDGseM36ZUVjImbf7vvtx bj+1KDXss0/v7TWroV9NGsdhSClmOQAiH3TkjNO09tefCIb22ZfdKlfpRUr62S1EevSm rRvoIesZaeeirOYDecQfzdEQgd6o/LfbrgQUniDPOYuy7z3XNMTTJiONqyRvn+T2L87d pQW/fkgxD3tin9IUDMQD7XYga16CTvRgf1LSGdOyuu/2NA/qqezGQdKy/mgpN6jeuc72 sGO4TVcb9gUkGs/B4o9iSFFGekwANmmDumPvgfX+MNsgv4CAXKmyC2LjMFmHa8xnhZxE pbQg== X-Gm-Message-State: AOJu0YzSzF5RgUu2LwYyxrD+nLmcc0v3HgH+RV8HWFPOPi0LHtkNw09a rtRwAwMSnT0mpcMup2l9x772Z0y6uO6qZv3vIDukyrF2867OpFjKqniD X-Gm-Gg: Acq92OHLca+In12af2nUXYG9jK3wiSLg7zEijOCBAa+hjfRD/34RyIHnnrTdgH9PemO UBymbQkhDplLqMYmgSSvfuM/aev82MlfNT0us5q8cMzLu2Vq9g9FZ1SNd9EtbrgVRHNL6Dp/4Xp H7NmoI/auboBL9xeOoh3T5cqy6kJ8KDHGt2FdUhrch3Y7rp3gI9MwNMSLNuulvtj5BouczmyHUU wkwP/icKqExykdmyVXIRJGR8o2CikZENyqzzEwlegBoWrqujSYNXs1UGpgF9e/3enP36TtNpOrW Y6KlPwrPZA20upwhUV0Uy2+haAMZZHxrWtZlvjl8xdkkGZZh8ArmWujSPryh65JZkKqwLhg6A7K fVxwa/KXH+GG22/qZB5o4L/pI/N4f5/+R2rlYJ7pjH+tDK02AVcUxe2MXcM9vhdxWKQO776YMxe 8vfehag2QrC4INu3OaLWcTWikBczEhPzPIMuCtoI/1fSDC+36ZooL3H3xUPjU6cXPvkdqf X-Received: by 2002:a05:6000:40da:b0:43f:e452:f391 with SMTP id ffacd0b85a97d-4515b056a89mr15433327f8f.6.1778174341725; Thu, 07 May 2026 10:19:01 -0700 (PDT) Received: from mamamia.internal (a89-182-137-143.net-htp.de. [89.182.137.143]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45416b5c811sm398733f8f.17.2026.05.07.10.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 10:19:01 -0700 (PDT) From: Andre Heider To: Miquel Raynal , Srinivas Kandagatla Cc: linux-kernel@vger.kernel.org Subject: [PATCH] nvmem: layouts: onie-tlv: fix hang on unknown types Date: Thu, 7 May 2026 19:18:59 +0200 Message-ID: <20260507171900.2244151-1-a.heider@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The EEPROM on my board has a vendor specific entry of type 0x41. When stumbling upon that, this driver hangs in an endless loop. Fix it by keep inrementing the offset on unknown entries, so the loop will eventually stop. Signed-off-by: Andre Heider --- drivers/nvmem/layouts/onie-tlv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/nvmem/layouts/onie-tlv.c b/drivers/nvmem/layouts/onie-tlv.c index 0967a32319a28..8b0f3c1b8a0e9 100644 --- a/drivers/nvmem/layouts/onie-tlv.c +++ b/drivers/nvmem/layouts/onie-tlv.c @@ -119,7 +119,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem, cell.name = onie_tlv_cell_name(tlv.type); if (!cell.name) - continue; + goto next; cell.offset = hdr_len + offset + sizeof(tlv.type) + sizeof(tlv.len); cell.bytes = tlv.len; @@ -132,6 +132,7 @@ static int onie_tlv_add_cells(struct device *dev, struct nvmem_device *nvmem, return ret; } +next: offset += sizeof(tlv) + tlv.len; } -- 2.53.0