From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f182.google.com (mail-dy1-f182.google.com [74.125.82.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E789466B4B for ; Thu, 7 May 2026 18:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778177127; cv=none; b=CaIiQ0bSu+/twVH9WoHe0tfshHXw591S5CBNelm+6DHsJmRRFTwS4/P7KIeqEBbatAYRMO/vd0pih8QJ1Wp7PfxE95RWHzH6Bw44wTvJru7NYzKKlc51LpF+mCwcMtJ5ns4p4dXglJI1qwwbl5NYF9aBaUd0kWUNHbL7ILNLJxM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778177127; c=relaxed/simple; bh=Pw+ssuLutbx3g6u/jM5PMxxasbxx9jVlsAJtmVGQOkk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bi7FmjnllowteWrm97280EjoMoK4TRi15VPNkI5XLsD8f1Y0q9Q/bysFImIx7DwTW+j7T++usHwbJJiAOfalntP7FugrFzxPPxH57joX5QZ1SPZHOX/PT4C7/OdJk7Yt1ZEoLu4JBCF4eCugY76KXtdT17gfp7qM3PDSSGnrGrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P7y5f7n1; arc=none smtp.client-ip=74.125.82.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P7y5f7n1" Received: by mail-dy1-f182.google.com with SMTP id 5a478bee46e88-2f7ca62a3c4so566912eec.0 for ; Thu, 07 May 2026 11:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778177125; x=1778781925; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VtTcFBJ7InscTxETiiZ7Szcd4eyMEX33KwP3VapF0JQ=; b=P7y5f7n1h+pr4X/Iy60Gz4zGRAzIb5kycIhtxcsmZtLKy1U2Z3lrtlCA3x70FMe5em wfsAhlopLqLaeUFSWZ7lXq5JEYFlBwp7xweH0XB77cDq4CjhYokpW6TXRCqKE/q6PhSV myp3dGJDGcHuDvuXDOhxJNT5Q6rIEMZcgTw2dKlgrcD6/cJ3x3kKOqEQjd5BTDQtgnv2 D2lyxqRDSc15QPMf5rjFxFxeshNLHt+0WQ9+GgdBmzW6j/x6DXO/Ojv17QPaOVg/JKsW b5d5+NSKQmVWX3RaWoROXB26ahqzhr2+JCdDuTTHpJBEgnNYKL0Wl64Fa7TZzSujBEF6 fmGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778177125; x=1778781925; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=VtTcFBJ7InscTxETiiZ7Szcd4eyMEX33KwP3VapF0JQ=; b=qqzP73Di6+Ljff/SzfsOU5ATY+kPd/h+wgnY23qGmfQQl9hKr+Vy9flOaCcXjSDKbS 4uFC3V5D0ldhKSAyZDY644Ily3eN/puFYuHnH0fjcfvS8sKu1o6J1rviLwRVzxYJol4p zpVH5CD/q/mNpNSScnu3bxZ+MnBebqSaWgmYncUBtjsG8NLF6YX/z2oTNZK92EPQLxrE d/j+w9ObAih4dV7zmptcQcGWUf4Rqdv1w5QODmhdSUODjGUyoM9ZiDidU2/AZ21WzSJk n/LvR/mD5RlcIwyW1/OoiNpDO2Q20ZBEnw47E1SA6wJnG4bVssHW+VLqoUvh92PmHFuG sbiw== X-Forwarded-Encrypted: i=1; AFNElJ+SBXaGOb/AycAjGPLu335Rr8vGPT14pqzSwOxd45P2sFhj6F6+7OK/0xnxvM7copclPdKn0spCtEAe1Yk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/1o1tUMVmIMLlqBg/fdiAh/KzXRY+O2kZBitFo4A9g1fVLO2r UPSIAQRWpuLKiibr4ujIEL3zhikyJnhhkr/v+fnUWIqzqxPMfj8oBXMJ X-Gm-Gg: Acq92OFITNspitGV3pUmd9JxnwYOa6OgomocYfrAhJ3XHeouueIadiYMt1469LrqvXe mIBbr23CLPY+FHgiA/vNJpcxxiVPhpVHHA3UPrI3J9gj7ZqIiAShvvOoM8mU4fWaDRCLN/Lg2V2 QPZPNtWEBmq+jvFlKjIpYHm43g0MyC55sqA+ddeZr9LbgICPKWp3PtriExIdKmAyJDzFdUo1RN3 +zyJRsWaF5WQ2ZesZrsEUcssMDS6HkHjSuc82UMxuitG2oCihE13tSlp8ZZJSX7vrt5DZvo4DVl LQnYiro8XTRYzcpYSGem8g6kQqbRivL6qGCPtoRbjxiBd2fsYyGITpu7VNHGrgT3efiPNctWHAG C0sV4GabdEbJG4TQ5aJl8XXB5wnRw4huP424X8ZVq6k8gYd7yuPxWywiNH5XJ3dQeOpTCq3B8AM WxDZw+M+o7sAAjNQkAqcgucVKqPjzm449JdJ6yysCBJGwrf+s6a4bNSbkVa4P/2dyt0fH4+hJbq IXflS0VDR13PKs= X-Received: by 2002:a05:7300:e82b:b0:2ca:7eb4:3e0f with SMTP id 5a478bee46e88-2f54b897f52mr4549823eec.5.1778177124530; Thu, 07 May 2026 11:05:24 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f82bd73a64sm44332eec.12.2026.05.07.11.05.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 11:05:24 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , "Pierre-Loup A . Griffais" , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , marshall@shzj.cc, hyacinth@shzj.cc, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v11 04/15] platform/x86: lenovo-wmi-other: Zero initialize WMI arguments Date: Thu, 7 May 2026 18:04:56 +0000 Message-ID: <20260507180507.912966-5-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260507180507.912966-1-derekjohn.clark@gmail.com> References: <20260507180507.912966-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Adds explicit initialization of wmi_method_args_32 declarations with zero values to prevent uninitialized data from being sent to the device BIOS when passed. No functional change intended. Reviewed-by: Mark Pearson Fixes: 22024ac5366f ("platform/x86: Add Lenovo Gamezone WMI Driver") Fixes: edc4b183b794 ("platform/x86: Add Lenovo Other Mode WMI Driver") Reported-by: Rong Zhang Closes: https://lore.kernel.org/platform-driver-x86/95c7e7b539dd0af41189c754fcd35cec5b6fe182.camel@rong.moe/ Cc: stable@vger.kernel.org Reviewed-by: Rong Zhang Tested-by: Rong Zhang Signed-off-by: Derek J. Clark --- v7: - Include lwmi_gz_profile_set() fix as well. --- drivers/platform/x86/lenovo/wmi-gamezone.c | 2 +- drivers/platform/x86/lenovo/wmi-other.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-gamezone.c b/drivers/platform/x86/lenovo/wmi-gamezone.c index 381836d29a96..ca559e6c031d 100644 --- a/drivers/platform/x86/lenovo/wmi-gamezone.c +++ b/drivers/platform/x86/lenovo/wmi-gamezone.c @@ -203,7 +203,7 @@ static int lwmi_gz_profile_set(struct device *dev, enum platform_profile_option profile) { struct lwmi_gz_priv *priv = dev_get_drvdata(dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; enum thermal_mode mode; int ret; diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index a6be3463341c..1e06b894cfcc 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -166,7 +166,7 @@ MODULE_PARM_DESC(relax_fan_constraint, */ static int lwmi_om_fan_get_set(struct lwmi_om_priv *priv, int channel, u32 *val, bool set) { - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; u32 method_id, retval; int err; @@ -773,7 +773,7 @@ static ssize_t attr_current_value_store(struct kobject *kobj, struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv = dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; struct capdata01 capdata; enum thermal_mode mode; u32 attribute_id; @@ -836,7 +836,7 @@ static ssize_t attr_current_value_show(struct kobject *kobj, struct tunable_attr_01 *tunable_attr) { struct lwmi_om_priv *priv = dev_get_drvdata(tunable_attr->dev); - struct wmi_method_args_32 args; + struct wmi_method_args_32 args = {}; enum thermal_mode mode; u32 attribute_id; int retval; -- 2.53.0