From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61D65330D50 for ; Thu, 7 May 2026 21:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778188237; cv=none; b=BbTpIQrCrtDSqD+jiU/ELKJ64KFWAlPYWCX8eBSOdyod8srpc+AANv7/KOcjBhW4BCDyKYaL4ZhJTnvX6yhxu1SSaPSLc/ogD+M4yzARAPL9P20mHxHp7N0GSuZRwBBhJUrGfdrVGiJxivBqxvVtPrNwOlKSo998BCwneR4VFl0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778188237; c=relaxed/simple; bh=C1egXataboGD8V7S8nUM75Vxl9j4LaRqMZQEa8H73cA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eBU1UuQ50+SDPf6QV1ID8mbyfaVinSL9Ly0IIvCqymLrf18Pd5500EIZXsvmWmolnT7+tRBt4jnIVdEmiwFxzL4OuXtfiMIafmDWGl0OWwtboAtgzGSrnabMz1a0v6AyqzJcfJmxiqco78jqFGKY45P8LPVrOINv7kS5q98HiP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nRmSSZ8r; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nRmSSZ8r" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48909558b3aso15592585e9.0 for ; Thu, 07 May 2026 14:10:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778188235; x=1778793035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SDB2kynTXrWcwphsOwn0vQehydK3h/uhiBsQVkQ58dY=; b=nRmSSZ8rgeaWkfeK8d84rCgBx91kU8mWWx+q7ksIvWdQzTkzTpMh20Q2If44XGtKZ6 sD60MREIWzhHlV3qMrq0/V928m2g9KVJLxBkOsadK1GNo65/A63G1M0NGoCX4wTVXWBl AicguXBfkBgUl9AhA3Pc7VIBrhqmG5KMuW6sYnJ5zLPI2pY1/lQJb0glKKbB5k4KUW+T ypXiuDBsDB2X/NmCYaormQ/9I8FRUT8PF5ue/RN2KlPr1Eu8KMVq1Ox/apHN0lnGcWxt fqewyT1GNUryFjzvtoqxAXGa/rWcSxIamM0Apkdkp2ug+bQs1WCmimnI5xgtzkz3XgSa wjfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778188235; x=1778793035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SDB2kynTXrWcwphsOwn0vQehydK3h/uhiBsQVkQ58dY=; b=PyetJK9S9QKkSSkVxHHeU4nudRkqqzO+8BnRm2PA9F/TD4wlAFgSD9qkdgVSu3oiMf +n4Poscn0AD2Gb77jkSo/AWKtxY290tjW97+J2XHMqjNRT3wtQODlOhwtO4lDSZu/LlU /CJWnekgDE8g0swtnHQ3+YNp6qjdOCQWRzaHzuFfZ8KAHrp625Jov1Bs+Yve6U5bf8uU PVzcljJSavpTx+j7n+85hhhGytKESvENCkTnT4e326iyalL/rH5BesCQeSgniE1aSKqg RccE1WUsfZIZRuiai+7v5ddNzOtjRhlBYul5H+EXGd/bGUE7tSAf/JKfkaSBG/Dcet+S Ro/g== X-Forwarded-Encrypted: i=1; AFNElJ+Xeu2vTtnT5jsp5e19vRTjoufmcyV6uk6mGIAYoZXQRL9wD7P/kMKgWQeCGX8m/l5xm2A+9vTZ84PnlkI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4TJJ3jcbsmGu+kiLeppMbetg6DrPDBBXfMce4nnqjKrj5PGZb q/YAjwKxS2rZncaYQZpcPq9oH8xlvInbCkQa5+unk5Kn/Wed788VVMsx X-Gm-Gg: AeBDieuFJiKpP3YaeROuAjktgoQw8OhmpZfQxcf8kCSX7G3JXb9gqf15Bc8WDUMfQ4D AN74kWo/nIrTizlMTBlj6CvQUaye/yeZl3nxp/x3ZDSBjzGGC0eektj6OLP/jjY7PTMjJbr3Bpk +4hZ2gkgzAig0CZV+O7MnjVmWOFPITJlTzsLvTng3uZ9Cvcpm33ItmLIzN1VkclhUXOVjWAKJ8E 3XuVP1fosnIizv1FJe5GLH/9Wu2s92VkdkqLUJqi4p22gCu0RvbLLpau6BdLXChT3gS0mh1yzmL tmkRpJXPhrtntGFbRYJHCf7HegKNikAqSR70WNsobQcSkbPOF4z0YTXVAQ8jI+QFcAnFGWqzEoP EoOjjMZY83M2HKPqyZ1fX0RtXNlg5ugeCQJF6uxLuPQJ7/moz/IOz1v8GEB4ZuxNvxE/1jCHtG1 WJJYpD7XwuV7gfhqas0vLU1RVtxD6sFsVW6/x1JUwLK9CQDLRRdajfwAWIT4pVrAR6ZBrp2hm88 vc= X-Received: by 2002:a05:600c:696:b0:489:1c1f:35df with SMTP id 5b1f17b1804b1-48e51e215a4mr87304385e9.10.1778188234385; Thu, 07 May 2026 14:10:34 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6616481asm6938195e9.3.2026.05.07.14.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 14:10:34 -0700 (PDT) Date: Thu, 7 May 2026 22:10:32 +0100 From: David Laight To: Jakub Kicinski Cc: =?UTF-8?B?w4FsdmFybw==?= Costa , jiri@resnulli.us, "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , netdev@vger.kernel.org (open list:DEVLINK), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH] devlink/param: replace deprecated strcpy() with strscpy() Message-ID: <20260507221032.059b29a7@pumpkin> In-Reply-To: <20260507075234.1630060f@kernel.org> References: <20260506211415.16343-1-alvaroc.dev@gmail.com> <20260507090445.3448d536@pumpkin> <20260507075234.1630060f@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 7 May 2026 07:52:34 -0700 Jakub Kicinski wrote: > On Thu, 7 May 2026 09:04:45 +0100 David Laight wrote: > > > case DEVLINK_PARAM_TYPE_STRING: > > > - len = strnlen(nla_data(param_data), nla_len(param_data)); > > > - if (len == nla_len(param_data) || > > > - len >= __DEVLINK_PARAM_MAX_STRING_VALUE) > > > + len = strscpy(value->vstr, nla_data(param_data)); > > > + if (len < 0) > > > return -EINVAL; > > > - strcpy(value->vstr, nla_data(param_data)); > > > > The only sensible thing here is to replace the strcpy() with: > > memcpy(value->vstr, nla_data(param_data), len + 1); > > That'd probably be a good move, to avoid getting the broken strscpy() > conversion submissions. Care to send a patch? I'll lob one in soon. I'm working my way through a compile that errors strcpy() except for constant strings into arrays (ie the safe ones). Why is it that the worst examples is in the 'secerity code' :-) -- David