From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83A7937755A for ; Fri, 8 May 2026 06:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778220655; cv=none; b=MBKuKaUlSK4Rr6MI0NT1dRU7lOOucsGyK+TNRtJ5Z1x/EiI4F224cfeu/GnoJBgTJBs1V7Y1Vuegjq240b3F+IbShlJWA3TR3vpewEjeoOWGOh7crCCTs39ZWhvBNdwR1IWNevbeRWBmdRtf+AF/jftbSvH6Iuzf7Z04R8ba+k8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778220655; c=relaxed/simple; bh=w/NYNMOGty40Xjge/AlbeYBff99DywD2N7X/MGYp6jk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R+Nkcprxi8DPVeRf2T7O8OEvhxzEX2oLtqvO/GEYVSP0f38NEXWPRnL8hBPSzwRHl8y+dP555LdZwb2bhsMK3m/U4Dk28eajzdiIFIBpBwO0uBqJWyY0enmai+layAbwI9ZrLb5Cya/hTD0O8snkZCHV0aZ4qkBkvVv3yYxXh+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=dkQ74ION; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=hIeXEYZS; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="dkQ74ION"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="hIeXEYZS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778220642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=o3FE7cSV3OdBp33Tpylwqyz3x5C7uRSwJlhAfYFOQYY=; b=dkQ74IONttPLTYsC1YlBUtlKJRO0357unmYt/rMRDIFhvVIkG3+knvbuHy0lEtcooQ2Fjw QzO8dzYRV9eT5aulBN4kIFtlW92SilySRGFrVzkajOdyk/psIwyfncClCKVryGsQ7ePuiA 9w52CZrS8QavI7wm73k+lMiyw5HoDYo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-647-OS3B9uFEO0mawCFhI-GVZQ-1; Fri, 08 May 2026 02:10:41 -0400 X-MC-Unique: OS3B9uFEO0mawCFhI-GVZQ-1 X-Mimecast-MFC-AGG-ID: OS3B9uFEO0mawCFhI-GVZQ_1778220640 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-488c0120047so9562015e9.0 for ; Thu, 07 May 2026 23:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778220640; x=1778825440; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=o3FE7cSV3OdBp33Tpylwqyz3x5C7uRSwJlhAfYFOQYY=; b=hIeXEYZSQj2x7ghIO+qilqdOayLZjNG7Ly3oOV5DBRUpjjqBTT2JFXzzxHsVnkBZPX Eo/2hM8q3sI0KWdavm7ifCraWMb7P/K6b/OO+sQCEGkDJqadbOW7vCEmEmJ4wLQflJQ6 6enwMbfQn8ec5rgJn23IYZk3Iv6D37T5z26KwYugoVmtBqxhvWGlz6PuGzLRN9I9Fuhn 5+8KRvcR+81/EtQIxTHrNBIyAcU40zdi85tfLh8rouH80eCdWuMGhAADdagBTrY+jTDk V+FWHS40bwfOaYmjRc7rQenPD7SraSIo9gUxujWKp9+rKwBDMB6CCVAZ+rat0ukzJEJg +CBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778220640; x=1778825440; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o3FE7cSV3OdBp33Tpylwqyz3x5C7uRSwJlhAfYFOQYY=; b=El+zA0aPXA3utT4CEzq6xo5QbmtMQZV63cZT1UNJ6qZ5h1pNFjqQOnt+4OsAuItpeM sgGRZN+V3OsafNKK02sckoq66SVc/bL5s3P4N5wJo8QnWoaYFG5twzfdGXgyoM3pUApo zm0PUGs7BZ2GN94JBpTpLyYxT372D3mWqbXrx7f/AgX7in9JUQ1YZ2abnVIEIlYpmkfl X3/faP7SbZPlaYIg9m2B6/o8w2Hi8vCj6eaUrqkf77iuY86dmnVrAop/0rLHRcD2DH7G +eDvZ2T69SOZNm6Ls3zmPtfH+1Mygjbu1bA0OnRof2lOcGSrLqzzUDEEQKW4IJdHkyZm KeKw== X-Gm-Message-State: AOJu0YwX4tJhzpENncnjp75n0r+PfPka5I6+ebnygf2Kvi+r+zeNbSjy FM3/+o5Xn8MJG8Gh6iL7+zuS3QJ+myKrOgKz/LCxLVx7A565y4rneCOWGLgUTRpcFe6xlPX/iRH HKQR4KiJZUCuMp0xPpPFon67Nd2KsVJp9vRKPXz+zNe2fyI+WjlrwtXPME4Sxvl3DKA== X-Gm-Gg: AeBDieufodw7xcfIbxuIn6muJ4nesJtl8a+f9nkYCoykHACZYBa9loWOYvo+29pOgvg DwnKN5Bzwxz9OE7o8NPYTu1d0hXGHrR/CxLQMCfLHbE2RBZYHcLhgZwN4FFqMzdaYLpW9eIU6j6 potpMvoEZFPFAK0yv8lkcOqpRes/gSZNFWZ5AWNZydv4t1nNMVGKO9Fstb8X1UxVkd0ThTmMS6N Vkfdv8TpU2x3QUB9Mbt1qNCPZ52SaNID10Ad2w93HukuLzm9Nmh/UD6s/T2Bpia+X3Dvl9Le3kr 1cnxpQLpbQSU8C49OZeOzDeYtSsMx8Ucg2ogFCE1hPCM2SR5d5XyltbHqnv7q/7zeunR4FTbCpF S30LdMoa+AitBk3CtxGIaLNbh3w6FeSUOK2KaRk9O X-Received: by 2002:a05:600c:c08b:b0:489:201c:dc46 with SMTP id 5b1f17b1804b1-48e51e204b5mr128573045e9.12.1778220639588; Thu, 07 May 2026 23:10:39 -0700 (PDT) X-Received: by 2002:a05:600c:c08b:b0:489:201c:dc46 with SMTP id 5b1f17b1804b1-48e51e204b5mr128572735e9.12.1778220639067; Thu, 07 May 2026 23:10:39 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e642e5f26sm16991475e9.1.2026.05.07.23.10.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 23:10:38 -0700 (PDT) Date: Fri, 8 May 2026 02:10:35 -0400 From: "Michael S. Tsirkin" To: Dev Jain Cc: linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Lorenzo Stoakes , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org Subject: Re: [PATCH v5 09/28] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Message-ID: <20260508020947-mutt-send-email-mst@kernel.org> References: <96a2f5a938bf65315ac95e75b4e7741bae018cdd.1778192416.git.mst@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 08, 2026 at 09:06:22AM +0530, Dev Jain wrote: > > > On 08/05/26 3:52 am, Michael S. Tsirkin wrote: > > Now that vma_alloc_folio aligns the address internally, drop the > > redundant HPAGE_PMD_MASK alignment at the callsite. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > Hello Michael, > > Could you please send the whole patchset or at least the cover letter > too, to everyone CCed on at least one patch? I only got two patches > from the patchset in my inbox so I have no context :) Will do, for now I bounced the cover letter to you. > > mm/huge_memory.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 8e2746ea74ad..f51c0841ce91 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -1260,7 +1260,7 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > > const int order = HPAGE_PMD_ORDER; > > struct folio *folio; > > > > - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); > > + folio = vma_alloc_folio(gfp, order, vma, addr); > > > > if (unlikely(!folio)) { > > count_vm_event(THP_FAULT_FALLBACK);