From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB40123A561 for ; Fri, 8 May 2026 02:37:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778207848; cv=none; b=WbWzCZQ435X+/SsEyCu7katS37CpoOzIxGAsQVt3sxFmFmasQlNu4642qcyqPH6Ga1ozqlujhC+DmPy5d+nYSKCRMmAl5c4xZnF4UB6FH0XloLC46ZriJfTUZ+jIHJSzv232RgQbYeir4OjgjGpUQTSetxL39faPW9eaexaJ0bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778207848; c=relaxed/simple; bh=eCY9FpLFbmYQZcjaqmApKechLJqDaTc+X7WjzyTrtKk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EqqfzRfqfFUcMEwtjfAKy3HpffQ66TYv1ldIo3OI0HvAcFv/gselmOdvGG0xeggdDnpkZjwlBclc9tYcUlBtC8x/+o1za+JCBGSdsHsD8rTvLBBtssC2IWc/nVnJga6BILLjzrFWTnjCI26gJvEbI48Sgmb+UgK0SRvh1DAZsXg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g921aLFs; arc=none smtp.client-ip=209.85.128.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g921aLFs" Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-7bd65714dcaso16442017b3.3 for ; Thu, 07 May 2026 19:37:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778207846; x=1778812646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=oYsV4EGU0evRUjorMSwFGbp0KIcwFk/DNB3Xry1x+Ew=; b=g921aLFsXVGhDlR3oN54iPlsNN/ZasdZNcjMQthKx0oQn/9x61UgEUohRBWboCgBaI Udvqbu1fYwERN4X6b63gh6ymWSnonOIEM7x8HqUyYhltNyEtyd0Av37WkZ26PWtlXvnv bNGIhrk1Yf/G1GnshwkHj7R2KDB5shYvqZr3P2C1ApQU5buxngoNZWqtD+YSyWY/ofZz 1m52wiLkgTOuGZ/uGUk1sdR+WowChOl0TRogsbV74CI65jADVjh6r27a/hzHPoMcYQfu uK8Yhc2pTB3CjSBlH99chM9/oz2CHmsu+i4bLHgvEWK/LIWpVxyTM/+s2CJrxLjxzliD eaPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778207846; x=1778812646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oYsV4EGU0evRUjorMSwFGbp0KIcwFk/DNB3Xry1x+Ew=; b=BGY1X5VnWSJEabc+LMOYurAPih4eimSvtLZhpHzHYTkNoiQfzQ8EpQeDcFEpFtT0gd RylxFcX3kqheNaFbx+ECa3PuJLPkXVFWva4FXhS9Il6tqKPZD6Ja1FmoBMgakgTqB+1E 9VZ5LhkYtrlV1eWe+FNeusG/nC/FNyobwoLQiwgsO7QLbZrrb0aB5lkM57POPJTZMoJi UaiyB0iEHU4j+74xGGSEKIQ11B+B27y39wdaPWwQwEPxnulBiEcc8DYhy2VhHjPZhIzZ EGqdwJpS5tEqxMg+ITp4F6w+uRT26Tw+bgsL+N7pz0YGcI4e8tBf2s4C03vTckgDt8w5 NUoA== X-Forwarded-Encrypted: i=1; AFNElJ/ZkLijg8rz6QGQkrgZeDIibl8jDwh6h6ysCnLpglcXtx/p5SImRT8+gc+tti3MhXecgkmoCjr8ex998eI=@vger.kernel.org X-Gm-Message-State: AOJu0YyEK/oeqicnwSXwRke3U+EHIHQGfJfGAYxDF7I1xvTANtTSKiPP bOzexaqzlvbA5BrkLeYsEfIUzw7WXUV0QqP16DjVlVBTcI0wqlqlIoUK X-Gm-Gg: Acq92OHN/VTvRGXlqv+DtEiX+peAnHAvDnM/FsGGrsTsgdpxcLcrwE50O5l9TpwvN5b G9fsWMiVsBc6U30pjiyKWGYigybxO4W6dFw0HaM+dqzp4qdxLLH9Mpce/eQAmLJADl84Qp+kkvV mZMeTEcoOMFEW4lWcdNve+zGePuCmS8FB8x8FlQtSAKmIsaI2Zqf+9p19+kLH47J1s4O1No5GMm UnpUd4t8CHdOTPoEg0bsfNV96vH1MgVdo6UNEXNhaU1t3CZZ1jzXXfuh7nk4Pyu6pVl8V8x88aP N95Z8CImPlAvUugbBPdLuJRUA6cLnJBUe+32IPa8sJsu/JRBzxnm89SVt/WyF7xMBT2B9Ie4SMm FIwN/J0o9GpkJaIOBa7NufhbQmtUnC06xOzvlTlsh65QuVUG+o+HHIpBt194rj3VcBSJT6dGKAG SAZ7WqNH40oPItvtTWy+m3T9hvoDBspc8Al7pZY4bwijHUSax1Ow6AB0yxlKvcXMsASHUL7L9U8 jqNbQ62gtR1TipwUin71gJX X-Received: by 2002:a05:690c:c4f1:b0:7b4:f43f:1a23 with SMTP id 00721157ae682-7bdf5e98251mr118033637b3.34.1778207845701; Thu, 07 May 2026 19:37:25 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::111d]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6686fbcdsm100023497b3.40.2026.05.07.19.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 19:37:25 -0700 (PDT) From: Ethan Tidmore To: Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski Cc: Eric Biggers , Linlin Zhang , dm-devel@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] dm-inlinecrypt: Fix signedness bug Date: Thu, 7 May 2026 21:37:16 -0500 Message-ID: <20260508023716.668783-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function get_key_size() returns negative error codes and ctx->key_size is an unsigned integer, so the check (ctx->key_size < 0) is always impossible Assign get_key_size() return value to err, check for error code, then assign ctx->key_size to err. Detected by Smatch: drivers/md/dm-inlinecrypt.c:329 inlinecrypt_ctr() warn: unsigned 'ctx->key_size' is never less than zero. Fixes: 753450f716417 ("dm-inlinecrypt: add target for inline block device encryption") Signed-off-by: Ethan Tidmore --- drivers/md/dm-inlinecrypt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-inlinecrypt.c b/drivers/md/dm-inlinecrypt.c index 6f804f5a4be6..40d48ba73e23 100644 --- a/drivers/md/dm-inlinecrypt.c +++ b/drivers/md/dm-inlinecrypt.c @@ -325,11 +325,13 @@ static int inlinecrypt_ctr(struct dm_target *ti, unsigned int argc, char **argv) } /* */ - ctx->key_size = get_key_size(&argv[1]); - if (ctx->key_size < 0) { + err = get_key_size(&argv[1]); + if (err < 0) { ti->error = "Cannot parse key size"; return -EINVAL; } + ctx->key_size = err; + err = inlinecrypt_get_key(argv[1], raw_key, ctx->key_size); if (err) { ti->error = "Malformed key string"; -- 2.54.0