From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDFAA36E460 for ; Fri, 8 May 2026 06:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778220176; cv=none; b=QFcrP+xxWLuoTd8l+j05Av9CLXA0hX4M09jm3vIFESUl9IbiPbk66YjZCzQzt1O1KjBqCzaQPa2VkgLPhMwfKIaRVgIen38jKYFJHjKY32GK7zWx21PSxsALPIJMdQL/z73AfVr6Maps/LyuGjEmL/D1IX8ebCRy5IsOaOKDou8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778220176; c=relaxed/simple; bh=l99uuCAmCHJNTNIenbXYngUea2lGG+SPAOE6oYEiujU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nqFyOJnNlNtSzlR8Uu7RSUNJfN7V0DJscpTN6ftkkdt4catAs0gN8gXX5a6dZgPdCJJqm1kyO/r5vAqsLreSxqegT10l5t1jJv0L1G7g9JjigLBrVG6y4NaVnZWK8TV9ZXVk2yuWZCYaA2rSuoE27i7bq0Qqenhmrfqd4IPhZAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=WmMp3QfN; arc=none smtp.client-ip=192.198.163.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="WmMp3QfN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778220172; x=1809756172; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=l99uuCAmCHJNTNIenbXYngUea2lGG+SPAOE6oYEiujU=; b=WmMp3QfN99RaT6fp7JnQmzQIXpSu2g8oRasvCiJpAEAZIdPtNaCaSmku fOZGCajT+qss1CQmN1aYSh8Pl3FqRLfzs8Km04s7OAyahkDOGxczN3MRu Sbq9u2MDr9NjzehOdZZwTEgWwgxdjYfGdVApm1nlUI7paVUN7xP3bElhh GNe56XLNPxvcFwcrYHggLBh10Oi0TPLdPttXONl+utGovtjtZoZrnngVw EIXb/7hw1oY8WiKOLWMuvjpqeWOudkgcSamI0Ni3C/T+F7M2SH7RYdp9u t+NDSc+ep2L16YE9l1fuf567vNrhVtH4yQS0KHrEmPumMJ8Gwkmyy1tPA g==; X-CSE-ConnectionGUID: VShT/5OgQrq4hqR7jzgnWA== X-CSE-MsgGUID: ZOa8j/VeSKqWKKhyWTK5tg== X-IronPort-AV: E=McAfee;i="6800,10657,11779"; a="104643666" X-IronPort-AV: E=Sophos;i="6.23,223,1770624000"; d="scan'208";a="104643666" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2026 23:02:48 -0700 X-CSE-ConnectionGUID: yG8eUMx/SFm8L/rU2L21MQ== X-CSE-MsgGUID: AUc2reCkQOKznUAnYJ8bjg== X-ExtLoop1: 1 Received: from ubuntu.bj.intel.com ([10.238.152.35]) by fmviesa003.fm.intel.com with ESMTP; 07 May 2026 23:02:47 -0700 From: Jun Miao To: pbonzini@redhat.com, seanjc@google.com Cc: linux-kernel@vger.kernel.org, jun.miao@intel.com Subject: [PATCH] KVM: Fix stale gfn_to_pfn() reference in kvm_invalidate_memslot() comment Date: Fri, 8 May 2026 14:01:39 +0800 Message-Id: <20260508060139.850444-1-jun.miao@intel.com> X-Mailer: git-send-email 2.32.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 06cdaff80e50 ("KVM: Drop gfn_to_pfn() APIs now that all users are gone") removed gfn_to_pfn(), but kvm_invalidate_memslot() still references gfn_to_pfn() when describing how sp->gfn is validated for guest memory accesses. Update the comment to reference __kvm_faultin_pfn(), which is the actual path involved here. No functional change intended. Fixes: 06cdaff80e50 ("KVM: Drop gfn_to_pfn() APIs now that all users are gone") Signed-off-by: Jun Miao --- virt/kvm/kvm_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 89489996fbc1..f4b3ea970a78 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -1818,7 +1818,7 @@ static void kvm_invalidate_memslot(struct kvm *kvm, /* * From this point no new shadow pages pointing to a deleted, or moved, * memslot will be created. Validation of sp->gfn happens in: - * - gfn_to_hva (kvm_read_guest, gfn_to_pfn) + * - gfn_to_hva (kvm_read_guest, __kvm_faultin_pfn) * - kvm_is_visible_gfn (mmu_check_root) */ kvm_arch_flush_shadow_memslot(kvm, old); -- 2.43.0