From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95D522D0614 for ; Fri, 8 May 2026 06:58:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778223494; cv=none; b=hpYKZEG4+UgtZaZP3AbSpwrNV0fiKZMIsd6mN5Qr3qCDDB31E7dM2hbznRrLqarvJuE3ZNGUcpqrPQ34EXHuLUS4aWSwwdgOfeWrOECgQ9XH61oIoU7jzHzTVzqmOIkKuTuVgUqHAdn+LE3oKTPYF5jSBkxBLxVe0sng84XHWdw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778223494; c=relaxed/simple; bh=3STGZFIGp1QI0P9KYESK3j78npCaPdnySXuzfK9UW/E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a0wdIXPKtrfNZDhzOQ+XWdBAXZamYPHsuUBeE5kqZorUWbyYARsWaeEUD8xoUBrvZzC0dmU4yzHbONaf51VKIGaFsgdVmiZs0XJhDvrG/SKH0yIho01ZZebr6+TvA15XSfyIAEzDrEXmsHfB7FE2B1Ah0Ac1W/iTebu+kHUe+y0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VXg2q+vJ; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VXg2q+vJ" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ba17c8cfacso16922195ad.2 for ; Thu, 07 May 2026 23:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778223488; x=1778828288; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XVeN/tIgR68DwC5ZYD/OpJgnTRgKD56zUbPN+aZwxQg=; b=VXg2q+vJj7ofj3pbGGn9m0Z75t629Mn48TrbmSEn1ZuTIBnPBoYVO6bDBdwJvLKcEn 8Ju4ON/1zyEveUw3lhme/ZEzETFT4qmXeqGDBYPdp06XHpwQ3htMGQljxuEJmqPSK34M nWcwVAoTFHJunsNS91dLoS7+eyyzfo77YbAc61vrBEO6/8HJ331W9qzi9LBtG4U4S2g6 X32pqYdKwm++AirlgdcG2t7vvTp+vTUoHNpdrjivDeBiXL7KDjrfSYk0ns9Cq3Zfmarv nL4sKfjGrzTXf4mB9X0JB6nWrFhXRN5zKx57zR3GHD0duPFhZVc29pXR9a6Goa1t60pM t8lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778223488; x=1778828288; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XVeN/tIgR68DwC5ZYD/OpJgnTRgKD56zUbPN+aZwxQg=; b=J07Banr55LLSw+WICATWRq8lstemCPJ8o6LwHLoB9hINFp9CZ7ZfCYX+vE7j7HMvOp tc4b63E0FTW2sWrf1ssV6Z0DNyi4Rlhnc14uE4MIgIWfmIUX2jd+gFqOOPCJePOaDAvP rwlBd8a1bX+Br8Qr/MC6k+UiZ2oPnzDpV7bjQ1hG/KaSg2nZwhDA0CTcDUwn4lDzGW2p EeyEZhQacz54kmn274MncEQD1spPFnBBZ2o2OKuZO4LWUoire3BPyCnK3r0gM8i/3AM7 qgMNVY/+mApzli97F+JWKx6ZARfWwykgJsGf0C3zOZ0QZkQnQC8pm1ICVKhn+VmWSp6h IfFw== X-Forwarded-Encrypted: i=1; AFNElJ+WCAFGqFtC7fILGuyC3qYbaSnsqkVGfqXa9++6hgqZesy6MNR6vtTjV9Yf95z+QSDBTEmZJKGbZOF21kM=@vger.kernel.org X-Gm-Message-State: AOJu0YxliRtGd2wC0zIarbrgudLNf3aGWJX6rA2ZXJF7AMQrUd3rEuAe apygANkW2sD4pNS0monaOT8IPZn7jwjuwP2FEs6f98Ut0tEkHmLb4Fbf X-Gm-Gg: Acq92OHiuM2wt5ootRHMapBi2cCpWdQ+xfKig/K/ceDowCgPpl1m6LP/rbG+SwCxUW0 bQcpjRBtKksx28NasiDVH4ismcIJdz7JO7QEuG+K4cLJFRfdGa2EYyFa5LQpYtdp550L0O5E7UC ycLOmAdzNvv50mEGRNui6xJNhfyP7AEoBmIO3N5YbUUjGgb0u33DMizJeVEwQ8VXs1v+PxcDCcv FFir3yW2zLyxswCM+Xq+7aVTG6DKTQtYvHn40J7P7wd45NHsHBcCB8J/V8gFvaMP3Jp7N7Be7/i VYi/paciXxhUVcXb6Xk9OytQFPSVgIO9ukPQYiCcC0LvKMIYi4r2nJtfMG1qWziDPcI++hoYTjD ho9gsQNVot2igmgSMOsaJ+XoOodOx8eDtTxhsZF6ceIu2cXvvi1eIx9LBKayTg7T81IBWme2Dqv XbCCSEmZlZIVswve39yJbCXPD5Ukv7IG/X2J262rvuCMHjPlsx8A== X-Received: by 2002:a17:902:d2c9:b0:2ba:fed:7891 with SMTP id d9443c01a7336-2ba79bfca66mr135479575ad.30.1778223487880; Thu, 07 May 2026 23:58:07 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:6619:3046::4cf:90]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e35bcfsm9488785ad.38.2026.05.07.23.58.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 23:58:07 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jamal Hadi Salim , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 1/2] net/sched: tbf: add extack to offload params Date: Fri, 8 May 2026 14:57:52 +0800 Message-ID: <20260508065757.2566258-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260508065757.2566258-1-mmyangfl@gmail.com> References: <20260508065757.2566258-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Drivers might have error messages to propagate to user space. Propagate the netlink extack so that they can inform user space in a verbal way of their limitations. Signed-off-by: David Yang --- include/net/pkt_cls.h | 1 + net/sched/sch_tbf.c | 9 +++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index 99ac747b7906..3bd08d7f39c1 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -1046,6 +1046,7 @@ struct tc_tbf_qopt_offload_replace_params { }; struct tc_tbf_qopt_offload { + struct netlink_ext_ack *extack; enum tc_tbf_command command; u32 handle; u32 parent; diff --git a/net/sched/sch_tbf.c b/net/sched/sch_tbf.c index f2340164f579..4576111fe075 100644 --- a/net/sched/sch_tbf.c +++ b/net/sched/sch_tbf.c @@ -139,7 +139,8 @@ static u64 psched_ns_t2l(const struct psched_ratecfg *r, return len; } -static void tbf_offload_change(struct Qdisc *sch) +static void tbf_offload_change(struct Qdisc *sch, + struct netlink_ext_ack *extack) { struct tbf_sched_data *q = qdisc_priv(sch); struct net_device *dev = qdisc_dev(sch); @@ -148,6 +149,7 @@ static void tbf_offload_change(struct Qdisc *sch) if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) return; + qopt.extack = extack; qopt.command = TC_TBF_REPLACE; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -166,6 +168,7 @@ static void tbf_offload_destroy(struct Qdisc *sch) if (!tc_can_offload(dev) || !dev->netdev_ops->ndo_setup_tc) return; + qopt.extack = NULL; qopt.command = TC_TBF_DESTROY; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -176,6 +179,7 @@ static int tbf_offload_dump(struct Qdisc *sch) { struct tc_tbf_qopt_offload qopt; + qopt.extack = NULL; qopt.command = TC_TBF_STATS; qopt.handle = sch->handle; qopt.parent = sch->parent; @@ -193,6 +197,7 @@ static void tbf_offload_graft(struct Qdisc *sch, struct Qdisc *new, .parent = sch->parent, .child_handle = new->handle, .command = TC_TBF_GRAFT, + .extack = extack, }; qdisc_offload_graft_helper(qdisc_dev(sch), sch, new, old, @@ -477,7 +482,7 @@ static int tbf_change(struct Qdisc *sch, struct nlattr *opt, qdisc_put(old); err = 0; - tbf_offload_change(sch); + tbf_offload_change(sch, extack); done: return err; } -- 2.53.0