From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1780E282F23 for ; Fri, 8 May 2026 08:40:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778229648; cv=none; b=eg9gmoW+fTXx+ZP7epuK0r3+3+hUnrTFegB/IvnNNd+AKTDNUoxtQsXoMOHGxerr2V1tlcUvSxJAn8mC6Prdiz5Ynb/n/V97Dx31zxvqBaF5zjuKRWHw9rrvCmCdOKwpYO3mWw5zxH3XO6mCMxzDHd9ojlW3F67T+3ZksqSxLTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778229648; c=relaxed/simple; bh=EYq2LaRS7/wE9O5fN1xxBdxqWDcVL5HSo4IraNzRrbY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jdQYgRB5AkYzWhsSevd+kO1dmYF+dn88YIN9Knuf2kWvEt7ZDj9jtXj6F3KzDyt+D2mrDQS3zlKbtEkLhbf+xivheKZGOP0cVg2EMtW3qJ2TOuEvnZ9uz938o9wjhehVQJXWjy1dS8urJa3eWa6mv4KtUxh+LSDmjhtuMQ7fOCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JGHbT7MM; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JGHbT7MM" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso10432945e9.3 for ; Fri, 08 May 2026 01:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778229645; x=1778834445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=MBrLMbZ1kBG0nwZ7F1fosUl/09LgLiME1ma02b9cG8I=; b=JGHbT7MMnXk23sSoRY1Z+7bVJfgpsb/OjJuIt/mXHgtAGYs1rP4s+54xTJTFG3bLSG ZaQuTVK3YMOAQYEo3rtxcYw+OB9tSCuejfBqz1HlR71clJY+vdFVYbZUnLsScmSWVvA8 dtalmwm4L7oL5te/hKCt0+nPmq35Tr+wlLQHLSrIYCB1jObHO837cBqhFD1RRofGF59w 5y/toyTrAVdebL05ycBJQE+8AGwYm5fbV/vu6jYEzdqRXcIs4gIbqxL+oETkLuvKYftd rH9fpccaMQN1OQKutp33KJxpCkKUmgmheT2uy/RLgx+ip/MGAJoGIknsar0Hs3YB0nQf /L3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778229645; x=1778834445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MBrLMbZ1kBG0nwZ7F1fosUl/09LgLiME1ma02b9cG8I=; b=ahU4/kh/AFftGpmg8lZZLKf+AXTZXaFiJK/iV5nRcY0aaWf6SCSytWQGf8ON8IFXYP q2z5QvPVM0RzD6iqmapzE3f+aXhRCELQ1iASZkct1K2mUqw+S2+i7e+6Oznlj1uzN6Nh bksK1sPcdt+RyKY0RXXxZ43JtvCne2IDeyDfphnLy8tui5LJ204CRNpq/jP8l9gccjK3 DpwUqmpY1yLQmZ44cwG+48uzNirXYUL3FS0a9W+QciqbmTbJf9xo4u4gv97fMlKrQ+e3 lTVTOFQrbXQVVCUqNESVXdmTGo/fFqIPSenN6jHovpM6nTIjRi10W4Wac3oEcrJ2d6Q7 Nzaw== X-Forwarded-Encrypted: i=1; AFNElJ8C840/5XxOmjvYbY43xn0KDxXeOsf1UMvHGTagSF2CbetlURT/PlByBouAi3OjO3ZXinSkrMGIftxJZjk=@vger.kernel.org X-Gm-Message-State: AOJu0YzL9KSLRASZCQpKyihm2iZC7YZo4LmtW4hNbGlcJfTeGK5YA9jF /51BxkiHfeZvsrsiWA9Obm1aGUqkuC39IguPdTlzFtWE555CRQDMW2KC X-Gm-Gg: AeBDies5OfcNy1qxtWLJOKZZeHjgWNrCkrbYDc/NrOWjymw4zMQh21KL2ndO8YTt4Zd DaYRtI3ceNocozdkTxF+8O4T0YHaOo3M00Cc52x6O+jSU5cZvQrtqXlY+plH18xwdT9XZ1NQFBM FNlL+i4sWPnxqL6pB8sJMsazQsAJ4DrisIM4WT7AEjJIptATflWi43mIVgi+Tow4efZtU73oBpv nYZyXFXAo/fFuX8h5pod3RKywc/5bRuHpq9/y3jCn7xBAjSF5xykh0T6VMjWQhMxgmyRYtmGhS9 bjwHY4XpTiQ9NmWcoEelfgB2kx2tNNpN88spqo2siOIhaflIO3rnGbbxIzhLVNkqOK/nrl7vut4 KGKqf8dExwoMVnQOdE1pU0xgKMWBZOuSVjAgmt5Wqlw/xDFgP/zigR7lI8eS0nRv5vs5+59HpW1 8e96A9edB3XGodSBpIb1o1Z6mpXL10wdeC5kt5XKSeTwKtoif+RE5bLUKg7npHmYB0 X-Received: by 2002:a05:600c:4703:b0:488:936a:6220 with SMTP id 5b1f17b1804b1-48e676ac055mr25431025e9.21.1778229645361; Fri, 08 May 2026 01:40:45 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491bae13csm2688386f8f.29.2026.05.08.01.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 01:40:45 -0700 (PDT) Date: Fri, 8 May 2026 09:40:43 +0100 From: David Laight To: Wei Fang Cc: Greg Ungerer , "linux-m68k@lists.linux-m68k.org" , "linux-kernel@vger.kernel.org" , "arnd@kernel.org" , Greg Ungerer , Frank Li , Shenwei Wang , "netdev@vger.kernel.org" Subject: Re: [RFC 1/4] net: fec: do not use readl()/writel() for ColdFire Message-ID: <20260508094043.20f5f3fc@pumpkin> In-Reply-To: References: <20260506142644.3234270-2-gerg@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 May 2026 02:46:38 +0000 Wei Fang wrote: > > static void > > fec_stop(struct net_device *ndev) > > { > > struct fec_enet_private *fep = netdev_priv(ndev); > > - u32 rmii_mode = readl(fep->hwp + FEC_R_CNTRL) & FEC_RCR_RMII; > > + u32 rmii_mode = fec_readl(fep->hwp + FEC_R_CNTRL) & FEC_RCR_RMII; > > This is not an issue, but since you changed this line, the new code should > follow the "reverse xmas tree" style. Looking rmii_mode isn't even used until much later in the function. (and then not very often) Much better to read it just before it is needed. David > > See: https://elixir.bootlin.com/linux/v7.0.1/source/Documentation/process/maintainer-netdev.rst#L380 > > > u32 val; > > > > /* We cannot expect a graceful transmit stop without link !!! */ > > if (fep->link) { > > - writel(1, fep->hwp + FEC_X_CNTRL); /* Graceful transmit stop */ > > + fec_writel(1, fep->hwp + FEC_X_CNTRL); /* Graceful transmit stop */ > > udelay(10); > > - if (!(readl(fep->hwp + FEC_IEVENT) & FEC_ENET_GRA)) > > + if (!(fec_readl(fep->hwp + FEC_IEVENT) & FEC_ENET_GRA)) > > netdev_err(ndev, "Graceful transmit stop did not complete!\n"); > > } > > > >