From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7691D2D8391 for ; Fri, 8 May 2026 09:02:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778230951; cv=none; b=f1Uhd7JUtWsqY5lBMjp99HvgbAd8XRdYHyGOOamxLzFk4CV/VtKG5D7pRwhlWXONrYSdxgn7MT0v+X3bpi45VoFaEHRkEseiFUfXJE+Crwcevx1Yk2uYJ9XOLiIVQURvTQpPn3sQ9a36bSmRQRl31A1ti0GsE98aefFLnix4Lkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778230951; c=relaxed/simple; bh=WIPNyT+MJITZgScNy15NlVstSPVx6hRR32XdQhokLmY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QYUCvVSEE+1k+48Cr+CjRDQM1NYBndJ+YKhimru7JDvThO/RnLp5eOZ7I+21128fJ7LbIKJsRcUpU0LaYHz5gaQo24oic3ksGRHxDOpDoGk80CFYN+5PC4dtEZhemhSkU9DGJpmTAEodeUEwne4zizU8NzpMpWG4/PMQxmdhm5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Q7Qsovx+; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7Qsovx+" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4891e86fabeso21367995e9.1 for ; Fri, 08 May 2026 02:02:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778230949; x=1778835749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HlYOG3XzQZlo22JT9TgpdXVisycjOjKnbVWOM2UqaHQ=; b=Q7Qsovx+vjB2CNZ4ZmA2+m+ZuI8vwuwxbbdeGJoUUWWBw9hvhSYU6URCEk/d1U4X9e Sm9Kx2yekUieIDnw9LLiiQ4U1aGJMhdyZuqDkCr9ZochQvNtTkuwm9pE1LXVGrCmr1TN GTPK5fvtZtazkSAzSH5XLMxeyKwaV1TIqcRfCMs2CK0MFJ8dmCbYMumqW2yp1gevmXev xOvSutn2JztZ5JFleB1yaGZH0t9ZcUtvhd55sAKsLjyAbxep7tZ2eDw6IWH6yCj4XlIl 0Spu4x3Eh7OT14OrYzVL2gD5Dk8kKHbueUx1OzsfkNttganF5ZGtaEYPR1rLSm8MkilM rCqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778230949; x=1778835749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HlYOG3XzQZlo22JT9TgpdXVisycjOjKnbVWOM2UqaHQ=; b=DFztBtOBEPlegVAvtPT1JiFOBjrVpqvLmUA06v8w7ZyOQq+hR5nt8fwr37ZogLqNJ0 5B94fFb8MYtDaeKtLiyVgNARixZ6giVJqCmeeJOC2XhzcjRRAa7ja7zwVf0/95lEZhoX 5kHAObrPwl8sqBbWS0p7rOqA0aYhV4bo4gCqgJYD1uy9FQ8h/jhNo3RSWr6q0w9ao8iD Txj5L/tjWCesfVrpvAq0uXwILg1NDhkjAV2ZuwVNDNFY4fDqxWMvCLW0he5PXftRtWDb xcV7K1zys6XPdCgMNtF0/hkrXD/hwIE3bxIFbDii28i950OOXm9OuzsdmR4vDR9F4WT+ RKvw== X-Forwarded-Encrypted: i=1; AFNElJ/slzplrqbVNgVZ1np+c8vX/RfdcHEGr72iPVIL0LP7sT5aN/dybA3Oc+ehPpBj9lsXz766WWqeW2+xPJk=@vger.kernel.org X-Gm-Message-State: AOJu0YwyPdgrRLP9bH1Y/17OUsr+qYNlki6XbWzY6y0198ZU/8aBPONd LoADT8QWQeNsnjdcm9ozLqc67Gj19K5AzxvwoLvyNyhGsB/E6CNg77nD X-Gm-Gg: AeBDievj5WrRNUz2Xqj0PyWaJq1sY/8xedGRtGdDXJ3Fvs2dO4QHdqtc/bnqNYrx5DK stGSy4fgQteqU3wMa1HKdRLzvpRDxfoTKJlC1SEhoSyl3ODmsghjH7p5hOoLVRN0mCOkybLq6nM p1zwwS6v1YOza9OcJaYI+V4EfErlXyf4jdxTLYDvQ0+LcS7XOYs9VxcHMvUN2e3JsfVd7nSj8uY 7cIIq6r/mGdSVJvtwR4tv/Hp4nMjMYA8doz2X8OwdvR/rAhyI7/8rWzzdhmUYp+PTUZonGb7O0n 7PLvQsyPRP9LX83u1ShHHhqt+V+FClG0qmHEgV4VNUexrHPA9oOtngKTO9HX3iWwEDcVTuM15Gb +U0ThGHZfk31U55Xko1ULU9WUYV0iwgv6nB3v3rROVFDvJxGRAXNepi3vSI6iL3gYGjqQnjWDXX cXR/bB/RbtICe+epLYQmZZ2/soCvUaK2mwJMU5d+FJmLLZ5oaNUlkoWSZq/9IRQeCO X-Received: by 2002:a05:600c:8011:b0:48a:80cb:1bb4 with SMTP id 5b1f17b1804b1-48e51f3b00emr178439985e9.22.1778230948591; Fri, 08 May 2026 02:02:28 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491bae13csm2842091f8f.29.2026.05.08.02.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 02:02:27 -0700 (PDT) Date: Fri, 8 May 2026 10:02:26 +0100 From: David Laight To: Ratheesh Kannoth Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v12 net-next 2/9] net/mlx5e: trim stack use in PCIe congestion threshold helper Message-ID: <20260508100226.49294dc3@pumpkin> In-Reply-To: <20260508034912.4082520-3-rkannoth@marvell.com> References: <20260508034912.4082520-1-rkannoth@marvell.com> <20260508034912.4082520-3-rkannoth@marvell.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 May 2026 09:19:05 +0530 Ratheesh Kannoth wrote: > union devlink_param_value grew when U64 array parameters were added. > Keeping a four-element array of that union in > mlx5e_pcie_cong_get_thresh_config() inflated the stack frame past the > -Wframe-larger-than limit. > > Read each driverinit value into a single reused union, then store the > four u16 thresholds in struct mlx5e_pcie_cong_thresh field order via a > temporary u16 pointer to config. > > Signed-off-by: Ratheesh Kannoth > --- > .../mellanox/mlx5/core/en/pcie_cong_event.c | 34 +++++++++++-------- > 1 file changed, 19 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c b/drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c > index 2eb666a46f39..88e76be3a73d 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/pcie_cong_event.c > @@ -252,28 +252,32 @@ static int > mlx5e_pcie_cong_get_thresh_config(struct mlx5_core_dev *dev, > struct mlx5e_pcie_cong_thresh *config) > { > + enum { > + INBOUND_HIGH, > + INBOUND_LOW, > + OUTBOUND_HIGH, > + OUTBOUND_LOW, > + }; > + > u32 ids[4] = { Someone will suggest that should be 'static const'. It may make the code smaller. > - MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW, > - MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH, > - MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW, > - MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH, > + [INBOUND_LOW] = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW, > + [INBOUND_HIGH] = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH, > + [OUTBOUND_LOW] = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW, > + [OUTBOUND_HIGH] = MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH, > }; > - struct devlink *devlink = priv_to_devlink(dev); > - union devlink_param_value val[4]; > > - for (int i = 0; i < 4; i++) { > - u32 id = ids[i]; > - int err; > + struct devlink *devlink = priv_to_devlink(dev); > + union devlink_param_value val; > + u16 *dst = (u16 *)config; You can't do that - far too fragile. Maybe &config->inbound_low - but even that assumes the values are in order. A safer way would be using a temporary 'u16 val16[4]'. (Or even overwrite ids[] with the result.) But the code might even be smaller if you just unroll the loop: err = devl_param_driverinit_value_get(devlink, MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_LOW, &val); if (err) return err; config->inbound_low = val.vu16; err = devl_param_driverinit_value_get(devlink, MLX5_DEVLINK_PARAM_ID_PCIE_CONG_IN_HIGH, &val); if (err) return err; config->inbound_high = val.vu16; err = devl_param_driverinit_value_get(devlink, MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_LOW, &val); if (err) return err; config->outbound_low = val.vu16; err = devl_param_driverinit_value_get(devlink, MLX5_DEVLINK_PARAM_ID_PCIE_CONG_OUT_HIGH, &val); if (err) return err; config->outbound_high = val.vu16; -- David > + int err; > > - err = devl_param_driverinit_value_get(devlink, id, &val[i]); > + for (int i = 0; i < ARRAY_SIZE(ids); i++) { > + err = devl_param_driverinit_value_get(devlink, ids[i], &val); > if (err) > return err; > - } > > - config->inbound_low = val[0].vu16; > - config->inbound_high = val[1].vu16; > - config->outbound_low = val[2].vu16; > - config->outbound_high = val[3].vu16; > + dst[i] = val.vu16; > + } > > return 0; > }