From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 632173DA5DC for ; Fri, 8 May 2026 12:19:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242767; cv=none; b=MEg/ZYPtF1FDAnOFYYs2XHjzklDYDepJYHWY9nTcIjJUOC9mXcthlccY3xViq9s17/4Xnx1+CJ0uI+pyCH02MdQD3RfSPB7c0R9Sma14ejUFTZgdfDLSHRm0JkNQhkFfGvE/b0rHIpy98gOmVb3pMSkxEqktIT/xXNNomeag7Aw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242767; c=relaxed/simple; bh=sPuuBoZsJsMQg4Ux+i6kMwWg7G2z365jWoV41M3Piz4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nMnL0KhoU4KiuoSaWJ9f+PmAMfgpckuBKM1ibdIQhmmkGZIthy7Mw3afP6U4a7verbng5HOChSfNhDdp4O1hWO6pvk4f+P2j7u8MZVLp9w+ILH5g04Hh1TpMoCHRl7zJSjAFmPDiUHMykSyJ5ZTxMoIioXNz1svPGPKPO6nb6hw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rgR2cixs; arc=none smtp.client-ip=209.85.208.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rgR2cixs" Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-3939eab114eso2249271fa.1 for ; Fri, 08 May 2026 05:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778242764; x=1778847564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sPuuBoZsJsMQg4Ux+i6kMwWg7G2z365jWoV41M3Piz4=; b=rgR2cixsvK3v6l15zWZhi9EICs3H4c3Bg94x2VmH0kYJa95nd5+HTFDVmd0seIxU90 B5Uclu4pbXNqWxTCV3Ce9OIFkpQMGAEWUo0YGU+P6iRIYkfWxBoXqfmWuKnZZ4SRAEvD VXAGAtTFNAhfDcva09Ob2YZL6iD5O8x1kmzsypN94wGxfs8IkUp5z1ILwLebuuiWWui8 TEEibkCe4mB2QgG3OPPLJqCSo0ZK05WTzy74aeqD08MGj5/0gzolj0ojxMB/ZqqOoNzS ZJ2/s+DkNBrFlNWst1oj4JJjbQh3SUb+ZCNZwo3XbTC7zm0ti4s4MMASUnk4sHiLJntG +Oug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778242764; x=1778847564; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sPuuBoZsJsMQg4Ux+i6kMwWg7G2z365jWoV41M3Piz4=; b=XD7cbhe4wO2+Tx0QactNGYTPAdIZxq0Rd5EKGX0VdlXlKaD/GZnyT6YKGb3PxxGBBG asn2upJbArdAVv1pi5+eE6yT4Ta0hhDYo/OmjKIDqkvGtVRrge/QGBKK3yAanST14qIb CQ38tY0DTbwUqeQzvIGoDAIl5AqCZGJwDjQaefnT5NhR2bj7rvGwDLNzF6ksKk3CH9o7 k0zDCXdXMZKdtuI6nSUWzFjni10CBpZcO+3uPIBDq6DL4qxp+n1i2VHXMfsLVznTIp9P uPQKWTIVDjij+VpKpH7FILaKKUtocLG2Sf4zTrBXjfQKeGByBAXvOM2ZgMMtJG/7Gqaa wBCg== X-Forwarded-Encrypted: i=1; AFNElJ9OizYz5oDZan+eoN+4jRSInMdMuDj7k99u6p3yUzUQpI8ONLo3RHObcv9hw9Nk+tyMMYum8JgWltRaihU=@vger.kernel.org X-Gm-Message-State: AOJu0YxEyCn9iWVCdNEUVBekZ9PIKLyvjTvEztAEC0rFbXu0E8Cab2z5 ZdxDtQIUrlYyYn4FcmVqBl809Qe4JDcbI8Gx8V9q+xLB5iLqq8ysRPN0 X-Gm-Gg: Acq92OExsOkhxfvNBNwzGy2o0w1bKyaXALATT7vWepyLyCVliDSS2D5LD5CI6VZ4KFi UZHPsHMez/MRbds1k5jHc6HAfbiHwUm8f72nmq9+xae5JGEujlxpKOUp3/cHPLXylxutA2CaXdu bicP39EQV2rhPVrYbrjgfJyjVkvRmcvQEfoUfxjk/CUsDg9dRx4fr/HVJAErrrriEUhIOQrjQ/3 v+uImxtbNy0LlLZBUGvNsKvEKB5awc88DNxStB5BXTIMwAzI8lgcZLAhV2I5OZy1aLie5IN9dZh n+d45te6B9DaNkAIDlIKQpomS8Hm2I2MKpTGk5zUebr6Gn8vYdbi9P3Ko6tX9xvjXqZK1/UIE8Y DQgXl+VoY0l/j7RelYrXl80O7a3m0qmcUtI5kOgZRmAPKCwzK+8Wkl18oR2vz0M7xXi2AT9apZo 9y9w0vClyKUm2do9nex8eqL+Ouv4NXTrKS2gyI0VYHvCqzrIw= X-Received: by 2002:a05:6512:3a93:b0:5a8:7396:63e3 with SMTP id 2adb3069b0e04-5a887ce5f21mr1706229e87.5.1778242764182; Fri, 08 May 2026 05:19:24 -0700 (PDT) Received: from localhost.localdomain ([144.124.192.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95652acsm474206e87.56.2026.05.08.05.19.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 05:19:23 -0700 (PDT) From: Stepan Ionichev To: david@kernel.org Cc: akpm@linux-foundation.org, jgg@ziepe.ca, jhubbard@nvidia.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: Re: [PATCH] mm/gup: tolerate NULL unlocked in fixup_user_fault() Date: Fri, 8 May 2026 16:18:49 +0500 Message-Id: <20260508111849.10379-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: References: <20260507083050.416-1-sozdayvek@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 08 May 2026, David Hildenbrand wrote: > That would be completely broken. We must not drop the mmap lock unless > FAULT_FLAG_ALLOW_RETRY was set. Returning VM_FAULT_COMPLETED/VM_FAULT_RETRY > would mean that we did that. Broken. > > And the function documents "If NULL, the caller must guarantee that fault_flags > does not contain FAULT_FLAG_ALLOW_RETRY." You're right -- the contract is already enforced by the surrounding code and documented at the function. Defensive guards against an impossible scenario would just hide future real bugs. Please drop this patch. Thanks for taking the time to explain. Stepan